Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@uclibc.org, "Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built
Date: Mon, 21 Aug 2023 15:13:58 +0200	[thread overview]
Message-ID: <20230821151358.74e9b4b0@windsurf> (raw)
In-Reply-To: <pan$c62b1$e5429c51$8973424f$9abaebbb@ID-313208.user.individual.net>

On Fri, 18 Aug 2023 22:47:15 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Digging further into what first appeared to me as a typo I found your 
> commit adding the double colon to package/Makefile.package.in:
> https://git.buildroot.net/buildroot/commit/package?
> id=e11fe847b2f545446fc3300dd2ba88fd5da05756
> 
> At that time there was another file, package/Makefile.autotools.in, which 
> also included a "$(BUILD_DIR)/%/.stamp_built:" single-colon target:
> https://git.buildroot.net/buildroot/tree/package/Makefile.autotools.in?
> id=e11fe847b2f545446fc3300dd2ba88fd5da05756#n264
> 
> Today only one file, package/pkg-generic.mk, contains a .stamp_built 
> target.
> 
> Maybe, I am only guessing, the double colon was necessary back then, due 
> to two Makefiles containing the same target, and lost their justification 
> when the single-colon target "$(BUILD_DIR)/%/.stamp_built:" was removed 
> with commit https://git.buildroot.net/buildroot/commit/?
> id=d8b55b99095e5eed46d2b95bdaab2e69ccbd7170

Thanks for the additional research. However, I don't think your
explanation that the double colon was necessary back then because there
was a $(BUILD_DIR)/%/.stamp_built rule in package/Makefile.package.in
and another one in package/Makefile.autotools.in really makes sense:
this was also the case for all the other
$(BUILD_DIR)/%/.stamp_<something> rules, and only the .stamp_built one
had this double colon added.

I can really only think about this really being a typo.

Here is a highly convincing explanation: up to a few days ago before
you sent this patch, I had no idea what this "double colon" was doing
exactly. And I really doubt that back in 2009 when I contributed this
change I had a much better idea about it. So I don't see how it could
have been intentional from me, and therefore I believe it indeed is a
typo. I looked up the history of this patch, and it was posted only
once to the mailing list by me, I then did a pull request to Peter, who
merged the whole thing. So there was no particular discussion about
this double colon.

So, unless Yann disagrees, I think I'm going to apply Bernd's patch
with a slightly more detailed explanation.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot