From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built
Date: Fri, 18 Aug 2023 22:03:14 +0200 [thread overview]
Message-ID: <20230818220314.3178c964@windsurf> (raw)
In-Reply-To: <20230818151608.988723-1-bernd@kuhls.net>
On Fri, 18 Aug 2023 17:16:08 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> This fix can be backported because the offending line was added in 2009.
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/pkg-generic.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 5d1c1da128..9d40754939 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -286,7 +286,7 @@ $(BUILD_DIR)/%/.stamp_configured:
> $(Q)touch $@
>
> # Build
> -$(BUILD_DIR)/%/.stamp_built::
> +$(BUILD_DIR)/%/.stamp_built:
Note that double colon rules have a specific meaning in make:
https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
I've read a few times the page, but I'm not sure I fully grasp what it
says, so I don't know if the double colon was intended (and needed at
the time) or was a typo.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-18 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 15:16 [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built Bernd Kuhls
2023-08-18 20:03 ` Thomas Petazzoni via buildroot [this message]
2023-08-18 20:24 ` Yann E. MORIN
2023-08-18 20:44 ` Thomas Petazzoni via buildroot
2023-08-18 21:18 ` Yann E. MORIN
[not found] ` <20230818220314.3178c964__25218.2109326654$1692389025$gmane$org@windsurf>
2023-08-18 20:47 ` Bernd Kuhls
2023-08-21 13:13 ` Thomas Petazzoni via buildroot
2024-07-12 19:47 ` Arnout Vandecappelle via buildroot
2024-08-07 8:54 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818220314.3178c964@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox