Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2023-08-18 22:44 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Fri, 18 Aug 2023 22:24:34 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > On 2023-08-18 22:03 +0200, Thomas Petazzoni via buildroot spake thusly:
> > > On Fri, 18 Aug 2023 17:16:08 +0200
> > > Bernd Kuhls <bernd@kuhls.net> wrote:
> > >   
> > > > This fix can be backported because the offending line was added in 2009.  
> > What is actualy broken?
> > As you noticed, the does has been there for moer than 14 years now, so
> > if something obvious was broken, we'd have notriced by now.
> > So, if this is broken, it is not obvious, and we need to udnerstand how
> > it is broken and why the fix is correct.
> 
> I don't think Bernd claimed anywhere that something is broken.

Right. But if that had just been a typo, then that would have been
invalid Makefile syntax, which it obviously is not, as this code does
not trigger an error from make.

So it is not a typo (so, see below).

> He
> claims there is a typo. I've also seen this double colon several times,
> and it isn't consistent across the other similar make targets, and I
> always wondered if it was needed or not. If it is not needed, we should
> remove it to make this rule consistent with others. If it's needed, it
> should be explained in a comment above it because it's not obvious
> what's going on.

Exactly.

You expressed the same reasoning I was trying to convey, but which I
failed to express properly.

But I agree that either wway, needed or not, the explanations are going
to be... difficult to come up with, too.

As an aside, we use that :: construct in one other place:

    support/kconfig/Makefile.br:42:$(obj)/%:: $(src)/%_shipped 

which is something we inherited from the 2.6.21.5 kernel in
a665ed34960bf1423cba303276161bf44a9851f4... No need to fix that one.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot