[Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Cherniaev Andrei]

Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so script never works... Sorry, it was my mistake...
---
 boot/grub2/readme.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
index d0999ec390..3b7df3a47d 100644
--- a/boot/grub2/readme.txt
+++ b/boot/grub2/readme.txt
@@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
       is enough free space *before* the first partition to
       store Grub2. Leaving 1 MB of free space is safe.
 3. Setup loop device and loop partitions
-   loop_dev=$(sudo losetup -f disk.img)
+   loop_dev=$(sudo losetup -f --show disk.img)
    sudo partx -a "$loop_dev"
 4. Prepare the root partition
    sudo mkfs.ext3 -L root "${loop_dev}p1"
@@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
     - Create a second partition, type 8300, for the root
       filesystem.
 3. Setup loop device and loop partitions
-   loop_dev=$(sudo losetup -f disk.img)
+   loop_dev=$(sudo losetup -f --show disk.img)
    sudo partx -a "$loop_dev"
 4. Prepare the boot partition
    sudo mkfs.vfat -n boot "${loop_dev}p1"
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Thomas Petazzoni via buildroot]

Hello,

On Thu, 15 May 2025 23:42:40 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:

> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so script never works... Sorry, it was my mistake...

Thanks for your patch!

However, it lacks your Signed-off-by line, so we cannot merge it. Also,
could you wrap your commit message, and avoid "personal comments" like
"Sorry it was my mistake" ? Could you send a v2 with those issues fixed?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Peter Korsgaard]

>>>>> "Cherniaev" == Cherniaev Andrei <dungeonlords789@naver.com> writes:

 > Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8
 > Without `--show` loop_dev variable will be empty so script never
 > works... Sorry, it was my mistake...

Thanks for the patch. Can you please add your signed-off-by and resend
(E.G. git commit --amend -s)?


> ---
 >  boot/grub2/readme.txt | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
 > index d0999ec390..3b7df3a47d 100644
 > --- a/boot/grub2/readme.txt
 > +++ b/boot/grub2/readme.txt
 > @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
 >        is enough free space *before* the first partition to
 >        store Grub2. Leaving 1 MB of free space is safe.
 >  3. Setup loop device and loop partitions
 > -   loop_dev=$(sudo losetup -f disk.img)
 > +   loop_dev=$(sudo losetup -f --show disk.img)
 >     sudo partx -a "$loop_dev"
 >  4. Prepare the root partition
 >     sudo mkfs.ext3 -L root "${loop_dev}p1"
 > @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
 >      - Create a second partition, type 8300, for the root
 >        filesystem.
 >  3. Setup loop device and loop partitions
 > -   loop_dev=$(sudo losetup -f disk.img)
 > +   loop_dev=$(sudo losetup -f --show disk.img)
 >     sudo partx -a "$loop_dev"
 >  4. Prepare the boot partition
 >     sudo mkfs.vfat -n boot "${loop_dev}p1"
 > -- 

 > 2.45.2

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Cherniaev Andrei]

Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...

Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
 boot/grub2/readme.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
index d0999ec390..3b7df3a47d 100644
--- a/boot/grub2/readme.txt
+++ b/boot/grub2/readme.txt
@@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
       is enough free space *before* the first partition to
       store Grub2. Leaving 1 MB of free space is safe.
 3. Setup loop device and loop partitions
-   loop_dev=$(sudo losetup -f disk.img)
+   loop_dev=$(sudo losetup -f --show disk.img)
    sudo partx -a "$loop_dev"
 4. Prepare the root partition
    sudo mkfs.ext3 -L root "${loop_dev}p1"
@@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
     - Create a second partition, type 8300, for the root
       filesystem.
 3. Setup loop device and loop partitions
-   loop_dev=$(sudo losetup -f disk.img)
+   loop_dev=$(sudo losetup -f --show disk.img)
    sudo partx -a "$loop_dev"
 4. Prepare the boot partition
    sudo mkfs.vfat -n boot "${loop_dev}p1"
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Peter Korsgaard]

>>>>> "Cherniaev" == Cherniaev Andrei <dungeonlords789@naver.com> writes:

 > Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...

That commit was the cherry-pick of of commit 7dd56b6cd9 to the 2024.08.x
branch, so I have reworded the commit message and applied, thanks.

> ---
 >  boot/grub2/readme.txt | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
 > index d0999ec390..3b7df3a47d 100644
 > --- a/boot/grub2/readme.txt
 > +++ b/boot/grub2/readme.txt
 > @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
 >        is enough free space *before* the first partition to
 >        store Grub2. Leaving 1 MB of free space is safe.
 >  3. Setup loop device and loop partitions
 > -   loop_dev=$(sudo losetup -f disk.img)
 > +   loop_dev=$(sudo losetup -f --show disk.img)
 >     sudo partx -a "$loop_dev"
 >  4. Prepare the root partition
 >     sudo mkfs.ext3 -L root "${loop_dev}p1"
 > @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
 >      - Create a second partition, type 8300, for the root
 >        filesystem.
 >  3. Setup loop device and loop partitions
 > -   loop_dev=$(sudo losetup -f disk.img)
 > +   loop_dev=$(sudo losetup -f --show disk.img)
 >     sudo partx -a "$loop_dev"
 >  4. Prepare the boot partition
 >     sudo mkfs.vfat -n boot "${loop_dev}p1"
 > -- 

 > 2.45.2

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script

[Arnout Vandecappelle via buildroot]

On 16/05/2025 17:08, Cherniaev Andrei wrote:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...
> 
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   boot/grub2/readme.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
> index d0999ec390..3b7df3a47d 100644
> --- a/boot/grub2/readme.txt
> +++ b/boot/grub2/readme.txt
> @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
>         is enough free space *before* the first partition to
>         store Grub2. Leaving 1 MB of free space is safe.
>   3. Setup loop device and loop partitions
> -   loop_dev=$(sudo losetup -f disk.img)
> +   loop_dev=$(sudo losetup -f --show disk.img)
>      sudo partx -a "$loop_dev"
>   4. Prepare the root partition
>      sudo mkfs.ext3 -L root "${loop_dev}p1"
> @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
>       - Create a second partition, type 8300, for the root
>         filesystem.
>   3. Setup loop device and loop partitions
> -   loop_dev=$(sudo losetup -f disk.img)
> +   loop_dev=$(sudo losetup -f --show disk.img)
>      sudo partx -a "$loop_dev"
>   4. Prepare the boot partition
>      sudo mkfs.vfat -n boot "${loop_dev}p1"

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot