* [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
@ 2025-05-15 14:42 Cherniaev Andrei
2025-05-16 9:19 ` Thomas Petazzoni via buildroot
2025-05-16 9:35 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Cherniaev Andrei @ 2025-05-15 14:42 UTC (permalink / raw)
To: buildroot; +Cc: Cherniaev Andrei, Thomas Petazzoni
Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so script never works... Sorry, it was my mistake...
---
boot/grub2/readme.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
index d0999ec390..3b7df3a47d 100644
--- a/boot/grub2/readme.txt
+++ b/boot/grub2/readme.txt
@@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
is enough free space *before* the first partition to
store Grub2. Leaving 1 MB of free space is safe.
3. Setup loop device and loop partitions
- loop_dev=$(sudo losetup -f disk.img)
+ loop_dev=$(sudo losetup -f --show disk.img)
sudo partx -a "$loop_dev"
4. Prepare the root partition
sudo mkfs.ext3 -L root "${loop_dev}p1"
@@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
- Create a second partition, type 8300, for the root
filesystem.
3. Setup loop device and loop partitions
- loop_dev=$(sudo losetup -f disk.img)
+ loop_dev=$(sudo losetup -f --show disk.img)
sudo partx -a "$loop_dev"
4. Prepare the boot partition
sudo mkfs.vfat -n boot "${loop_dev}p1"
--
2.45.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
2025-05-15 14:42 [Buildroot] [PATCH] boot/grub2/readme.txt: fix script Cherniaev Andrei
@ 2025-05-16 9:19 ` Thomas Petazzoni via buildroot
2025-05-16 9:35 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-05-16 9:19 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: buildroot
Hello,
On Thu, 15 May 2025 23:42:40 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so script never works... Sorry, it was my mistake...
Thanks for your patch!
However, it lacks your Signed-off-by line, so we cannot merge it. Also,
could you wrap your commit message, and avoid "personal comments" like
"Sorry it was my mistake" ? Could you send a v2 with those issues fixed?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
2025-05-15 14:42 [Buildroot] [PATCH] boot/grub2/readme.txt: fix script Cherniaev Andrei
2025-05-16 9:19 ` Thomas Petazzoni via buildroot
@ 2025-05-16 9:35 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2025-05-16 9:35 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: buildroot, Thomas Petazzoni
>>>>> "Cherniaev" == Cherniaev Andrei <dungeonlords789@naver.com> writes:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8
> Without `--show` loop_dev variable will be empty so script never
> works... Sorry, it was my mistake...
Thanks for the patch. Can you please add your signed-off-by and resend
(E.G. git commit --amend -s)?
> ---
> boot/grub2/readme.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
> index d0999ec390..3b7df3a47d 100644
> --- a/boot/grub2/readme.txt
> +++ b/boot/grub2/readme.txt
> @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
> is enough free space *before* the first partition to
> store Grub2. Leaving 1 MB of free space is safe.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the root partition
> sudo mkfs.ext3 -L root "${loop_dev}p1"
> @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
> - Create a second partition, type 8300, for the root
> filesystem.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the boot partition
> sudo mkfs.vfat -n boot "${loop_dev}p1"
> --
> 2.45.2
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
@ 2025-05-16 15:08 Cherniaev Andrei
2025-05-16 20:00 ` Peter Korsgaard
2025-05-31 16:53 ` Arnout Vandecappelle via buildroot
0 siblings, 2 replies; 6+ messages in thread
From: Cherniaev Andrei @ 2025-05-16 15:08 UTC (permalink / raw)
To: buildroot; +Cc: Cherniaev Andrei, Thomas Petazzoni
Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...
Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
boot/grub2/readme.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
index d0999ec390..3b7df3a47d 100644
--- a/boot/grub2/readme.txt
+++ b/boot/grub2/readme.txt
@@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
is enough free space *before* the first partition to
store Grub2. Leaving 1 MB of free space is safe.
3. Setup loop device and loop partitions
- loop_dev=$(sudo losetup -f disk.img)
+ loop_dev=$(sudo losetup -f --show disk.img)
sudo partx -a "$loop_dev"
4. Prepare the root partition
sudo mkfs.ext3 -L root "${loop_dev}p1"
@@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
- Create a second partition, type 8300, for the root
filesystem.
3. Setup loop device and loop partitions
- loop_dev=$(sudo losetup -f disk.img)
+ loop_dev=$(sudo losetup -f --show disk.img)
sudo partx -a "$loop_dev"
4. Prepare the boot partition
sudo mkfs.vfat -n boot "${loop_dev}p1"
--
2.45.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
2025-05-16 15:08 Cherniaev Andrei
@ 2025-05-16 20:00 ` Peter Korsgaard
2025-05-31 16:53 ` Arnout Vandecappelle via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2025-05-16 20:00 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: buildroot, Thomas Petazzoni
>>>>> "Cherniaev" == Cherniaev Andrei <dungeonlords789@naver.com> writes:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...
That commit was the cherry-pick of of commit 7dd56b6cd9 to the 2024.08.x
branch, so I have reworded the commit message and applied, thanks.
> ---
> boot/grub2/readme.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
> index d0999ec390..3b7df3a47d 100644
> --- a/boot/grub2/readme.txt
> +++ b/boot/grub2/readme.txt
> @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
> is enough free space *before* the first partition to
> store Grub2. Leaving 1 MB of free space is safe.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the root partition
> sudo mkfs.ext3 -L root "${loop_dev}p1"
> @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
> - Create a second partition, type 8300, for the root
> filesystem.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the boot partition
> sudo mkfs.vfat -n boot "${loop_dev}p1"
> --
> 2.45.2
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
2025-05-16 15:08 Cherniaev Andrei
2025-05-16 20:00 ` Peter Korsgaard
@ 2025-05-31 16:53 ` Arnout Vandecappelle via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2025-05-31 16:53 UTC (permalink / raw)
To: Cherniaev Andrei, buildroot; +Cc: Thomas Petazzoni
On 16/05/2025 17:08, Cherniaev Andrei wrote:
> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so the script never works...
>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
Applied to 2025.02.x, thanks.
Regards,
Arnout
> ---
> boot/grub2/readme.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt
> index d0999ec390..3b7df3a47d 100644
> --- a/boot/grub2/readme.txt
> +++ b/boot/grub2/readme.txt
> @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms
> is enough free space *before* the first partition to
> store Grub2. Leaving 1 MB of free space is safe.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the root partition
> sudo mkfs.ext3 -L root "${loop_dev}p1"
> @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms
> - Create a second partition, type 8300, for the root
> filesystem.
> 3. Setup loop device and loop partitions
> - loop_dev=$(sudo losetup -f disk.img)
> + loop_dev=$(sudo losetup -f --show disk.img)
> sudo partx -a "$loop_dev"
> 4. Prepare the boot partition
> sudo mkfs.vfat -n boot "${loop_dev}p1"
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-31 16:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-15 14:42 [Buildroot] [PATCH] boot/grub2/readme.txt: fix script Cherniaev Andrei
2025-05-16 9:19 ` Thomas Petazzoni via buildroot
2025-05-16 9:35 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2025-05-16 15:08 Cherniaev Andrei
2025-05-16 20:00 ` Peter Korsgaard
2025-05-31 16:53 ` Arnout Vandecappelle via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox