From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 0/2] Checking whether a certain CONFIG_* is set
Date: Sat, 22 Aug 2015 00:17:54 +0200 [thread overview]
Message-ID: <8737zc70bx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150821210519.GB3753@free.fr> (Yann E. MORIN's message of "Fri, 21 Aug 2015 23:05:19 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
>> >> Why not just like the kernel-module infrastructure handle it like I
>> >> proposed? I don't think it is very nice that people have to remember to
>> >> add the select as well (and chances are they won't notice if they
>> >> forget).
>>
>> > Because that would not work for packages in br2-external trees, as I
>> > already explained.
>>
>> Are you sure? I didn't try it, but as we only *USE* the variable when
>> LINUX_KCONFIG_FIXUP_CMDS runs, which is after all the .mk files have
>> been parsed I think it should work?
> Ah, just checking would indeed be doable, something similar (but more
> restrictive) to the patch proposed by Jan:
> https://patchwork.ozlabs.org/patch/508729/
We seemed to be talking past eachother, but got it sorted out on
IRC. For others following, the change I suggested was actually the one
mentioned here:
http://lists.busybox.net/pipermail/buildroot/2015-August/137540.html
--
Venlig hilsen,
Peter Korsgaard
prev parent reply other threads:[~2015-08-21 22:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 16:50 [Buildroot] xtables-addons does not build for arm kernel 4.1.4 Jan Viktorin
2015-08-17 21:52 ` Peter Korsgaard
2015-08-17 22:35 ` Jan Viktorin
2015-08-19 13:14 ` [Buildroot] [PATCH v1 0/2] Checking whether a certain CONFIG_* is set Jan Viktorin
2015-08-19 13:14 ` [Buildroot] [PATCH v1 1/2] pkg-utils: Define KCONFIG_ASSERT_OPT macro Jan Viktorin
2015-08-19 19:16 ` Yann E. MORIN
2015-08-19 13:14 ` [Buildroot] [PATCH v1 2/2] xtables-addons: test CONFIG_MODULES=y in the kernel Jan Viktorin
2015-08-19 17:46 ` [Buildroot] [PATCH v1 0/2] Checking whether a certain CONFIG_* is set Thomas Petazzoni
2015-08-19 19:05 ` Yann E. MORIN
2015-08-19 19:08 ` Thomas Petazzoni
2015-08-19 19:21 ` Yann E. MORIN
2015-08-19 20:23 ` Thomas Petazzoni
2015-08-19 21:05 ` Peter Korsgaard
2015-08-21 13:22 ` Yann E. MORIN
2015-08-21 13:41 ` Jeremy Rosen
2015-08-21 20:28 ` Peter Korsgaard
2015-08-21 21:05 ` Yann E. MORIN
2015-08-21 22:17 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737zc70bx.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox