Re: [PATCH v3 08/13] dmaengine: dw-edma-pcie: Rename vsec_data to dma_data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing pci_free_irq_vectors() cleanup on error paths in dw_edma_pcie_probe().
--

commit de019354672cdd91d71c2d84fb752c9367dce2c3
Author: Koichiro Den <den@valinux.co.jp>

dmaengine: dw-edma-pcie: Rename vsec_data to dma_data

This commit renames the local variable vsec_data to dma_data in
dw_edma_pcie_probe() to reflect that DMA layout data can now be obtained
from device-specific capabilities, not just VSEC.

> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c

[ ... ]

> @@ -454,24 +452,24 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	/* Data structure initialization */
>  	chip->dev = dev;
>  
> -	chip->mf = vsec_data->mf;
> +	chip->mf = dma_data->mf;
>  	chip->irq_mode = DW_EDMA_CH_IRQ_REMOTE;
>  	chip->nr_irqs = nr_irqs;
>  	chip->ops = &dw_edma_pcie_plat_ops;
> -	chip->cfg_non_ll = vsec_data->cfg_non_ll;
> +	chip->cfg_non_ll = dma_data->cfg_non_ll;
>  
> -	chip->ll_wr_cnt = vsec_data->wr_ch_cnt;
> -	chip->ll_rd_cnt = vsec_data->rd_ch_cnt;
> +	chip->ll_wr_cnt = dma_data->wr_ch_cnt;
> +	chip->ll_rd_cnt = dma_data->rd_ch_cnt;
>  
> -	chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar];
> +	chip->reg_base = pcim_iomap_table(pdev)[dma_data->rg.bar];
>  	if (!chip->reg_base)
>  		return -ENOMEM;

[Severity: High]
This is a pre-existing issue, but does this error path leak the IRQ
vectors allocated earlier in the function?

The function dw_edma_pcie_probe() successfully allocates IRQ vectors using
pci_alloc_irq_vectors() before reaching this point, but returning directly
here leaves those resources stranded. 

Are there other error paths further down in this function, such as when
pci_dev_msi_enabled() fails or dw_edma_probe() returns an error, that
might also need a pci_free_irq_vectors() cleanup before returning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620170040.3756043-1-den@valinux.co.jp?part=8