Re: [PATCH v3 13/13] dmaengine: dw-edma-pcie: Add chip flags to match data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing pci_free_irq_vectors() on error paths after successful pci_alloc_irq_vectors() allocation.
--

commit 47790820d57ed923e44318e08b431eee242c2796
Author: Koichiro Den <den@valinux.co.jp>

dmaengine: dw-edma-pcie: Add chip flags to match data

This commit allows PCI ID match data to pass dw_edma_chip flags into
dw_edma_probe(). It keeps per-device policy in the match data instead of
open-coding it in the probe function.

> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c

[ ... ]

> @@ -471,6 +472,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	chip->dev = dev;
>  
>  	chip->mf = dma_data->mf;
> +	chip->flags = match->chip_flags;
>  	chip->irq_mode = DW_EDMA_CH_IRQ_REMOTE;
>  	chip->nr_irqs = nr_irqs;
>  	chip->ops = match->plat_ops;

[Severity: High]
This is a pre-existing issue, but does dw_edma_pcie_probe() leak IRQ
resources on error paths?

Earlier in dw_edma_pcie_probe(), IRQ vectors are successfully allocated:

    nr_irqs = pci_alloc_irq_vectors(pdev, 1, dma_data->irqs,
                                    PCI_IRQ_MSI | PCI_IRQ_MSIX);

However, multiple subsequent error paths return directly without calling
pci_free_irq_vectors(), for instance when mapping fails:

    chip->reg_base = pcim_iomap_table(pdev)[dma_data->rg.bar];
    if (!chip->reg_base)
            return -ENOMEM;

Another instance occurs further down if dw_edma_probe() fails, returning
the error without freeing the vectors. 

Should these error paths be updated to call pci_free_irq_vectors() before
returning to prevent IRQ resource exhaustion?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620170040.3756043-1-den@valinux.co.jp?part=13