Re: [PATCH v3 07/13] dmaengine: dw-edma-pcie: Add capability match data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing pci_free_irq_vectors() cleanup on error paths in dw_edma_pcie_probe()
--

commit abe1646ec71967f21d88dc1513ac61dd2092e6d7
Author: Koichiro Den <den@valinux.co.jp>

dmaengine: dw-edma-pcie: Add capability match data

This commit moves device-specific capability parsing behind per-device match
data, splitting it from static template assignment. No functional change
is intended for the existing Synopsys and AMD matches.

> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 0ea8d59782b44..c08a77c0e5085 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
[ ... ]
> @@ -469,8 +505,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  			return -ENOMEM;
>  
>  		ll_region->vaddr.io += ll_block->off;
> -		ll_region->paddr = dw_edma_get_phys_addr(pdev, vsec_data,
> -							 ll_block->bar);
> +		ll_region->paddr = dw_edma_get_phys_addr(pdev, match,
> +							 vsec_data, ll_block->bar);

[Severity: High]
This is a pre-existing issue, but does dw_edma_pcie_probe() leak IRQ
vectors allocated by pci_alloc_irq_vectors() when it returns directly
on error paths?

Looking at dw_edma_pcie_probe(), after pci_alloc_irq_vectors() succeeds,
there are several error paths that return without calling
pci_free_irq_vectors(pdev).

For example, if mapped BAR addresses are NULL when checking chip->reg_base,
or when returning -ENOMEM inside the region mapping loop shown above:

    chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar];
    if (!chip->reg_base)
        return -ENOMEM;

Since system IRQ capacity is limited, could repeated probe failures on
these paths exhaust system-wide IRQ vectors and prevent other devices
from functioning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620170040.3756043-1-den@valinux.co.jp?part=7