[PATCH] dmaengine: zynqmp_dma: drop redundant label

[PATCH] dmaengine: zynqmp_dma: drop redundant label

[Vinod Koul]

Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
dropped the use of err_disable_pm label causing warning:

drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
 1171 | err_disable_pm:

Drop it

Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/xilinx/zynqmp_dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index d1ee51dde3d1..3b7dfa53f972 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
 
 free_chan_resources:
 	zynqmp_dma_chan_remove(zdev->chan);
-err_disable_pm:
 	if (!pm_runtime_enabled(zdev->dev))
 		zynqmp_dma_runtime_suspend(zdev->dev);
 	pm_runtime_disable(zdev->dev);
-- 
2.43.0

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the `err_disable_pm` label causes a compilation failure because a `goto err_disable_pm;` statement remains in `zynqmp_dma_probe()`.
--

commit b231b06f7a09316d1f0854b835d97d063a04395f
Author: Vinod Koul <vkoul@kernel.org>

dmaengine: zynqmp_dma: drop redundant label

This commit removes the err_disable_pm label from zynqmp_dma_probe() to fix
an unused label warning reported after an earlier runtime PM update.

> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index 2b03584102acf..71a310d50ee33 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1149,7 +1149,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>  
>  free_chan_resources:
>  	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:

[Severity: Low]
Does this change cause a build failure?

Looking at zynqmp_dma_probe(), it appears there is still a jump to this
label earlier in the function:

	ret = zynqmp_dma_chan_probe(zdev, pdev);
	if (ret) {
		dev_err_probe(&pdev->dev, ret, "Probing channel failed\n");
		goto err_disable_pm;
	}

If the label is removed, won't the compiler fail with an undeclared label
error during compilation?

>  	if (!pm_runtime_enabled(zdev->dev))
>  		zynqmp_dma_runtime_suspend(zdev->dev);
>  	pm_runtime_disable(zdev->dev);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903170357.1711462-1-vkoul@kernel.org?part=1

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Frank Li]

On Thu, Sep 03, 2026 at 10:33:57PM +0530, Vinod Koul wrote:
> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> dropped the use of err_disable_pm label causing warning:
>
> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
>  1171 | err_disable_pm:
>
> Drop it
>
> Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/xilinx/zynqmp_dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index d1ee51dde3d1..3b7dfa53f972 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>
>  free_chan_resources:
>  	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:
>  	if (!pm_runtime_enabled(zdev->dev))
>  		zynqmp_dma_runtime_suspend(zdev->dev);
>  	pm_runtime_disable(zdev->dev);
> --
> 2.43.0
>

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Pandey, Radhey Shyam]

On 9/3/2026 10:33 PM, Vinod Koul wrote:
> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> dropped the use of err_disable_pm label causing warning:
> 
> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
>   1171 | err_disable_pm:
> 
> Drop it
> 
> Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")

Seems Fixes tag is incorrect.
Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error 
handling")

Rest looks fine to me.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>   drivers/dma/xilinx/zynqmp_dma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index d1ee51dde3d1..3b7dfa53f972 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>   
>   free_chan_resources:
>   	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:
>   	if (!pm_runtime_enabled(zdev->dev))
>   		zynqmp_dma_runtime_suspend(zdev->dev);
>   	pm_runtime_disable(zdev->dev);

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Pandey, Radhey Shyam]

On 9/5/2026 9:01 PM, Pandey, Radhey Shyam wrote:
> On 9/3/2026 10:33 PM, Vinod Koul wrote:
>> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
>> dropped the use of err_disable_pm label causing warning:
>>
>> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
>> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ 
>> defined but not used [-Werror=unused-label]
>>   1171 | err_disable_pm:
>>
>> Drop it
>>
>> Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> 
> Seems Fixes tag is incorrect.
> Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error 
> handling")
> 
> Rest looks fine to me.
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Thanks!

Just a thought - this bug is present in dmaengine/next and if it isn't 
pushed to external we can squash this patch to fixes commit itself (if
rebase on next is possible)?

>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>> ---
>>   drivers/dma/xilinx/zynqmp_dma.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/ 
>> zynqmp_dma.c
>> index d1ee51dde3d1..3b7dfa53f972 100644
>> --- a/drivers/dma/xilinx/zynqmp_dma.c
>> +++ b/drivers/dma/xilinx/zynqmp_dma.c
>> @@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct 
>> platform_device *pdev)
>>   free_chan_resources:
>>       zynqmp_dma_chan_remove(zdev->chan);
>> -err_disable_pm:
>>       if (!pm_runtime_enabled(zdev->dev))
>>           zynqmp_dma_runtime_suspend(zdev->dev);
>>       pm_runtime_disable(zdev->dev);
> 

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Vinod Koul]

On 06-09-26, 16:49, Pandey, Radhey Shyam wrote:
> On 9/5/2026 9:01 PM, Pandey, Radhey Shyam wrote:
> > On 9/3/2026 10:33 PM, Vinod Koul wrote:
> > > Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> > > dropped the use of err_disable_pm label causing warning:
> > > 
> > > drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> > > drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label
> > > ‘err_disable_pm’ defined but not used [-Werror=unused-label]
> > >   1171 | err_disable_pm:
> > > 
> > > Drop it
> > > 
> > > Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> > 
> > Seems Fixes tag is incorrect.
> > Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error
> > handling")
> > 
> > Rest looks fine to me.
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> > Thanks!
> 
> Just a thought - this bug is present in dmaengine/next and if it isn't
> pushed to external we can squash this patch to fixes commit itself (if
> rebase on next is possible)?

Yes this is for a patch I applied and found while building. So will
apply this...

-- 
~Vinod

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Vinod Koul]

On 05-09-26, 21:01, Pandey, Radhey Shyam wrote:
> On 9/3/2026 10:33 PM, Vinod Koul wrote:
> > Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> > dropped the use of err_disable_pm label causing warning:
> > 
> > drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> > drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
> >   1171 | err_disable_pm:
> > 
> > Drop it
> > 
> > Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> 
> Seems Fixes tag is incorrect.
> Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error
> handling")

Yeah my fixup tool picked the wrong one, I have added this, thanks

-- 
~Vinod

Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[Vinod Koul]

On Thu, 03 Sep 2026 22:33:57 +0530, Vinod Koul wrote:
> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> dropped the use of err_disable_pm label causing warning:
> 
> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
>  1171 | err_disable_pm:
> 
> [...]

Applied, thanks!

[1/1] dmaengine: zynqmp_dma: drop redundant label
      commit: 22f293e054dfe8252cc02cf562d3e9e460f6e83f

Best regards,
-- 
~Vinod