From: Marat Khalili <marat.khalili@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v3 05/25] bpf/validate: introduce debugging interface
Date: Tue, 23 Jun 2026 10:29:58 +0000 [thread overview]
Message-ID: <84ce7f7669404239864c61819267d9b6@huawei.com> (raw)
In-Reply-To: <3BbIFKkFSyOqZrm3k570og@monjalon.net>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday 23 June 2026 11:19
> To: Marat Khalili <marat.khalili@huawei.com>
> Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com>; dev@dpdk.org
> Subject: Re: [PATCH v3 05/25] bpf/validate: introduce debugging interface
>
> 12/06/2026 12:47, Marat Khalili:
> > +#ifndef LIST_FOREACH_SAFE
> > +/* We need this macro which neither Linux nor EAL for Linux include yet. */
> > +#define LIST_FOREACH_SAFE(var, head, field, tvar) \
> > + for ((var) = LIST_FIRST((head)); \
> > + (var) && ((tvar) = LIST_NEXT((var), field), 1); \
> > + (var) = (tvar))
> > +#else
> > +#ifdef RTE_EXEC_ENV_LINUX
> > +#error "Don't need LIST_FOREACH_SAFE in this version of DPDK anymore, remove it."
> > +#endif
> > +#endif
>
> It fails on Alpine Linux.
> Why adding this #error?
>
This is interesting. My mental model was that Linux is never going to have
LIST_FOREACH_SAFE, but DPDK will eventually gain its own polyfill. I was
actually expecting it to happen before my patch is published, so this was a
reminder to remove my own definition since it clearly belongs to some common
library. Turns out I was wrong on both accounts: there are Linuxes that define
LIST_FOREACH_SAFE, and I managed to submit faster. Apart from these
organizational issues the whole else branch can be safely removed. Do you want
me to submit an updated version?
next prev parent reply other threads:[~2026-06-23 10:30 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:38 [PATCH 00/25] bpf: test and fix issues in verifier Marat Khalili
2026-05-06 17:38 ` [PATCH 01/25] bpf: format and dump jlt, jle, jslt, and jsle Marat Khalili
2026-05-06 17:38 ` [PATCH 02/25] bpf: add format instruction function Marat Khalili
2026-05-06 17:38 ` [PATCH 03/25] bpf/validate: break on error in evaluate Marat Khalili
2026-05-06 17:38 ` [PATCH 04/25] bpf/validate: expand comments in evaluate cycle Marat Khalili
2026-05-06 17:38 ` [PATCH 05/25] bpf/validate: introduce debugging interface Marat Khalili
2026-05-06 17:38 ` [PATCH 06/25] bpf/validate: fix BPF_ADD of pointer to a scalar Marat Khalili
2026-05-06 17:38 ` [PATCH 07/25] bpf/validate: fix BPF_LDX | EBPF_DW signed range Marat Khalili
2026-05-06 17:38 ` [PATCH 08/25] test/bpf_validate: add setup and basic tests Marat Khalili
2026-05-06 17:38 ` [PATCH 09/25] test/bpf_validate: add harness for pointer tests Marat Khalili
2026-05-06 17:38 ` [PATCH 10/25] bpf/validate: fix EBPF_JSLT | BPF_X evaluation Marat Khalili
2026-05-06 17:38 ` [PATCH 11/25] bpf/validate: fix BPF_NEG of INT64_MIN and 0 Marat Khalili
2026-05-06 17:38 ` [PATCH 12/25] bpf/validate: fix BPF_DIV and BPF_MOD signed part Marat Khalili
2026-05-06 17:38 ` [PATCH 13/25] bpf/validate: fix BPF_MUL ranges minimum typo Marat Khalili
2026-05-06 17:38 ` [PATCH 14/25] bpf/validate: fix BPF_MUL signed overflow UB Marat Khalili
2026-05-06 17:38 ` [PATCH 15/25] bpf/validate: fix BPF_JGT/EBPF_JSGT no-jump max Marat Khalili
2026-05-06 17:38 ` [PATCH 16/25] bpf/validate: fix BPF_JMP source range calculation Marat Khalili
2026-05-06 17:38 ` [PATCH 17/25] bpf/validate: fix BPF_JMP empty range handling Marat Khalili
2026-05-06 17:38 ` [PATCH 18/25] bpf/validate: fix BPF_AND min calculations Marat Khalili
2026-05-06 17:38 ` [PATCH 19/25] bpf/validate: fix BPF_LSH shift-out-of-bounds UB Marat Khalili
2026-05-06 17:38 ` [PATCH 20/25] bpf/validate: fix BPF_OR min calculations Marat Khalili
2026-05-06 17:38 ` [PATCH 21/25] bpf/validate: fix BPF_SUB signed max zero case Marat Khalili
2026-05-06 17:38 ` [PATCH 22/25] bpf/validate: fix BPF_XOR signed min calculation Marat Khalili
2026-05-06 17:38 ` [PATCH 23/25] bpf/validate: prevent overflow when building graph Marat Khalili
2026-05-06 17:38 ` [PATCH 24/25] doc: add release notes for BPF validation fixes Marat Khalili
2026-05-06 17:38 ` [PATCH 25/25] doc: add BPF validate debug to programmer's guide Marat Khalili
2026-05-08 17:41 ` Stephen Hemminger
2026-05-09 12:36 ` [PATCH 00/25] bpf: test and fix issues in verifier Konstantin Ananyev
2026-05-19 9:31 ` [PATCH v2 " Marat Khalili
2026-05-19 9:31 ` [PATCH v2 01/25] bpf: format and dump jlt, jle, jslt, and jsle Marat Khalili
2026-05-19 9:31 ` [PATCH v2 02/25] bpf: add format instruction function Marat Khalili
2026-05-19 9:31 ` [PATCH v2 03/25] bpf/validate: break on error in evaluate Marat Khalili
2026-05-19 9:31 ` [PATCH v2 04/25] bpf/validate: expand comments in evaluate cycle Marat Khalili
2026-05-19 9:31 ` [PATCH v2 05/25] bpf/validate: introduce debugging interface Marat Khalili
2026-05-19 9:31 ` [PATCH v2 06/25] bpf/validate: fix BPF_ADD of pointer to a scalar Marat Khalili
2026-05-19 9:31 ` [PATCH v2 07/25] bpf/validate: fix BPF_LDX | EBPF_DW signed range Marat Khalili
2026-05-19 9:31 ` [PATCH v2 08/25] test/bpf_validate: add setup and basic tests Marat Khalili
2026-05-19 9:31 ` [PATCH v2 09/25] test/bpf_validate: add harness for pointer tests Marat Khalili
2026-05-19 9:31 ` [PATCH v2 10/25] bpf/validate: fix EBPF_JSLT | BPF_X evaluation Marat Khalili
2026-05-19 9:31 ` [PATCH v2 11/25] bpf/validate: fix BPF_NEG of INT64_MIN and 0 Marat Khalili
2026-05-19 9:31 ` [PATCH v2 12/25] bpf/validate: fix BPF_DIV and BPF_MOD signed part Marat Khalili
2026-05-19 9:31 ` [PATCH v2 13/25] bpf/validate: fix BPF_MUL ranges minimum typo Marat Khalili
2026-05-19 9:31 ` [PATCH v2 14/25] bpf/validate: fix BPF_MUL signed overflow UB Marat Khalili
2026-05-19 9:31 ` [PATCH v2 15/25] bpf/validate: fix BPF_JGT/EBPF_JSGT no-jump max Marat Khalili
2026-05-19 9:31 ` [PATCH v2 16/25] bpf/validate: fix BPF_JMP source range calculation Marat Khalili
2026-05-19 9:31 ` [PATCH v2 17/25] bpf/validate: fix BPF_JMP empty range handling Marat Khalili
2026-05-19 9:31 ` [PATCH v2 18/25] bpf/validate: fix BPF_AND min calculations Marat Khalili
2026-05-19 9:31 ` [PATCH v2 19/25] bpf/validate: fix BPF_LSH shift-out-of-bounds UB Marat Khalili
2026-05-19 9:31 ` [PATCH v2 20/25] bpf/validate: fix BPF_OR min calculations Marat Khalili
2026-05-19 9:31 ` [PATCH v2 21/25] bpf/validate: fix BPF_SUB signed max zero case Marat Khalili
2026-05-19 9:31 ` [PATCH v2 22/25] bpf/validate: fix BPF_XOR signed min calculation Marat Khalili
2026-05-19 9:31 ` [PATCH v2 23/25] bpf/validate: prevent overflow when building graph Marat Khalili
2026-05-19 9:31 ` [PATCH v2 24/25] doc: add release notes for BPF validation fixes Marat Khalili
2026-05-19 9:31 ` [PATCH v2 25/25] doc: add BPF validate debug to programmer's guide Marat Khalili
2026-06-12 10:47 ` [PATCH v3 00/25] bpf: test and fix issues in verifier Marat Khalili
2026-06-12 10:47 ` [PATCH v3 01/25] bpf: format and dump jlt, jle, jslt, and jsle Marat Khalili
2026-06-12 10:47 ` [PATCH v3 02/25] bpf: add format instruction function Marat Khalili
2026-06-12 10:47 ` [PATCH v3 03/25] bpf/validate: break on error in evaluate Marat Khalili
2026-06-12 10:47 ` [PATCH v3 04/25] bpf/validate: expand comments in evaluate cycle Marat Khalili
2026-06-12 10:47 ` [PATCH v3 05/25] bpf/validate: introduce debugging interface Marat Khalili
2026-06-23 10:18 ` Thomas Monjalon
2026-06-23 10:29 ` Marat Khalili [this message]
2026-06-23 12:29 ` Thomas Monjalon
2026-06-23 16:14 ` Marat Khalili
2026-06-12 10:47 ` [PATCH v3 06/25] bpf/validate: fix BPF_ADD of pointer to a scalar Marat Khalili
2026-06-12 10:47 ` [PATCH v3 07/25] bpf/validate: fix BPF_LDX | EBPF_DW signed range Marat Khalili
2026-06-12 10:47 ` [PATCH v3 08/25] test/bpf_validate: add setup and basic tests Marat Khalili
2026-06-12 10:47 ` [PATCH v3 09/25] test/bpf_validate: add harness for pointer tests Marat Khalili
2026-06-12 10:47 ` [PATCH v3 10/25] bpf/validate: fix EBPF_JSLT | BPF_X evaluation Marat Khalili
2026-06-12 10:47 ` [PATCH v3 11/25] bpf/validate: fix BPF_NEG of INT64_MIN and 0 Marat Khalili
2026-06-12 10:47 ` [PATCH v3 12/25] bpf/validate: fix BPF_DIV and BPF_MOD signed part Marat Khalili
2026-06-12 10:47 ` [PATCH v3 13/25] bpf/validate: fix BPF_MUL ranges minimum typo Marat Khalili
2026-06-12 10:47 ` [PATCH v3 14/25] bpf/validate: fix BPF_MUL signed overflow UB Marat Khalili
2026-06-12 10:47 ` [PATCH v3 15/25] bpf/validate: fix BPF_JGT/EBPF_JSGT no-jump max Marat Khalili
2026-06-12 10:47 ` [PATCH v3 16/25] bpf/validate: fix BPF_JMP source range calculation Marat Khalili
2026-06-12 10:47 ` [PATCH v3 17/25] bpf/validate: fix BPF_JMP empty range handling Marat Khalili
2026-06-12 10:47 ` [PATCH v3 18/25] bpf/validate: fix BPF_AND min calculations Marat Khalili
2026-06-12 10:47 ` [PATCH v3 19/25] bpf/validate: fix BPF_LSH shift-out-of-bounds UB Marat Khalili
2026-06-12 10:47 ` [PATCH v3 20/25] bpf/validate: fix BPF_OR min calculations Marat Khalili
2026-06-12 10:47 ` [PATCH v3 21/25] bpf/validate: fix BPF_SUB signed max zero case Marat Khalili
2026-06-12 10:47 ` [PATCH v3 22/25] bpf/validate: fix BPF_XOR signed min calculation Marat Khalili
2026-06-12 10:47 ` [PATCH v3 23/25] bpf/validate: prevent overflow when building graph Marat Khalili
2026-06-12 10:47 ` [PATCH v3 24/25] doc: add release notes for BPF validation fixes Marat Khalili
2026-06-12 10:47 ` [PATCH v3 25/25] doc: add BPF validate debug to programmer's guide Marat Khalili
2026-06-23 14:31 ` [PATCH v4 00/24] bpf: test and fix issues in verifier Marat Khalili
2026-06-23 14:31 ` [PATCH v4 01/24] bpf: format and dump jlt, jle, jslt, and jsle Marat Khalili
2026-06-23 14:31 ` [PATCH v4 02/24] bpf: add format instruction function Marat Khalili
2026-06-23 14:31 ` [PATCH v4 03/24] bpf/validate: break on error in evaluate Marat Khalili
2026-06-23 14:31 ` [PATCH v4 04/24] bpf/validate: expand comments in evaluate cycle Marat Khalili
2026-06-23 14:31 ` [PATCH v4 05/24] bpf/validate: introduce debugging interface Marat Khalili
2026-06-23 14:31 ` [PATCH v4 06/24] bpf/validate: fix BPF_ADD of pointer to a scalar Marat Khalili
2026-06-23 14:31 ` [PATCH v4 07/24] bpf/validate: fix BPF_LDX | EBPF_DW signed range Marat Khalili
2026-06-23 14:31 ` [PATCH v4 08/24] test/bpf_validate: add setup and basic tests Marat Khalili
2026-06-23 14:31 ` [PATCH v4 09/24] test/bpf_validate: add harness for pointer tests Marat Khalili
2026-06-23 14:31 ` [PATCH v4 10/24] bpf/validate: fix EBPF_JSLT | BPF_X evaluation Marat Khalili
2026-06-23 14:31 ` [PATCH v4 11/24] bpf/validate: fix BPF_NEG of INT64_MIN and 0 Marat Khalili
2026-06-23 14:31 ` [PATCH v4 12/24] bpf/validate: fix BPF_DIV and BPF_MOD signed part Marat Khalili
2026-06-23 14:32 ` [PATCH v4 13/24] bpf/validate: fix BPF_MUL ranges minimum typo Marat Khalili
2026-06-23 14:32 ` [PATCH v4 14/24] bpf/validate: fix BPF_MUL signed overflow UB Marat Khalili
2026-06-23 14:32 ` [PATCH v4 15/24] bpf/validate: fix BPF_JGT/EBPF_JSGT no-jump max Marat Khalili
2026-06-23 14:32 ` [PATCH v4 16/24] bpf/validate: fix BPF_JMP source range calculation Marat Khalili
2026-06-23 14:32 ` [PATCH v4 17/24] bpf/validate: fix BPF_JMP empty range handling Marat Khalili
2026-06-23 14:32 ` [PATCH v4 18/24] bpf/validate: fix BPF_AND min calculations Marat Khalili
2026-06-23 14:32 ` [PATCH v4 19/24] bpf/validate: fix BPF_LSH shift-out-of-bounds UB Marat Khalili
2026-06-23 14:32 ` [PATCH v4 20/24] bpf/validate: fix BPF_OR min calculations Marat Khalili
2026-06-23 14:32 ` [PATCH v4 21/24] bpf/validate: fix BPF_SUB signed max zero case Marat Khalili
2026-06-23 14:32 ` [PATCH v4 22/24] bpf/validate: fix BPF_XOR signed min calculation Marat Khalili
2026-06-23 14:32 ` [PATCH v4 23/24] bpf/validate: prevent overflow when building graph Marat Khalili
2026-06-23 14:32 ` [PATCH v4 24/24] doc: add release notes for BPF validation fixes Marat Khalili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ce7f7669404239864c61819267d9b6@huawei.com \
--to=marat.khalili@huawei.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox