Re: [PATCHv3 25/30] drm/omap: poll only connectors where the connect/disconnect can be checked

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Tomi,

Thank you for the patch.

On Tuesday 28 Mar 2017 16:08:11 Tomi Valkeinen wrote:
> From: Peter Ujfalusi <peter.ujfalusi@ti.com>
> 
> When the connector associated detect callback is not provided, we can not
> detect if the display is connected or disconnected. These displays does not

s/does/do/

> support hot plug, they are always connected. Let DRM know that connectors
> w/o detect callback should not be polled.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_connector.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c
> b/drivers/gpu/drm/omapdrm/omap_connector.c index f90e2d22c5ec..50d2b641c28b
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -229,13 +229,11 @@ struct drm_connector *omap_connector_init(struct
> drm_device *dev, connector_type);
>  	drm_connector_helper_add(connector, &omap_connector_helper_funcs);
> 
> -#if 0 /* enable when dss2 supports hotplug */
> -	if (dssdev->caps & OMAP_DSS_DISPLAY_CAP_HPD)
> -		connector->polled = 0;
> -	else
> -#endif
> +	if (dssdev->driver->detect)
>  		connector->polled = DRM_CONNECTOR_POLL_CONNECT |
> -				DRM_CONNECTOR_POLL_DISCONNECT;
> +				    DRM_CONNECTOR_POLL_DISCONNECT;
> +	else
> +		connector->polled = 0;
> 
>  	connector->interlace_allowed = 1;
>  	connector->doublescan_allowed = 0;

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel