Re: [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1579 bytes --]

On 29/03/17 13:30, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Tuesday 28 Mar 2017 16:08:09 Tomi Valkeinen wrote:
>> If omap_plane_atomic_update() is called when the crtc is disabled, and
>> the timings are zero, we'll see the following warning:
>>
>> omapdss DISPC error: cannot calculate scaling settings: pclk is zero
>> omapdrm omapdrm.0: Failed to setup plane vid2
>>
>> It shouldn't cause any issues, as the crtc is disabled so the plane is
>> not used by the HW.
>>
>> To remove the warning, check whether the crtc is enabled at the
>> beginning of omap_plane_atomic_update(), and bail out if not.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>>  drivers/gpu/drm/omapdrm/omap_plane.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
>> b/drivers/gpu/drm/omapdrm/omap_plane.c index 78a92422ede1..27c1902415de
>> 100644
>> --- a/drivers/gpu/drm/omapdrm/omap_plane.c
>> +++ b/drivers/gpu/drm/omapdrm/omap_plane.c
>> @@ -86,6 +86,11 @@ static void omap_plane_atomic_update(struct drm_plane
>> *plane,
>>
>>  	DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb);
>>
>> +	if (!state->crtc->state->enable) {
>> +		priv->dispc_ops->ovl_enable(omap_plane->id, false);
>> +		return;
>> +	}
> 
> I'm a bit puzzled, why is omap_plane_atomic_update() called for a plane on a 
> disabled CRTC ?

I don't remember, and I can't reproduce this on 4.12. Possibly something
has changed since 4.4...

I'll drop this.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel