dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown()
Date: Wed, 29 Mar 2017 11:49:59 +0300	[thread overview]
Message-ID: <7170884.JmdPD2UAPW@avalon> (raw)
In-Reply-To: <1490706496-4959-30-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Tuesday 28 Mar 2017 16:08:15 Tomi Valkeinen wrote:
> Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled
> when unloading the driver.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> 
> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
> b/drivers/gpu/drm/omapdrm/omap_drv.c index ad8d16cf819c..7b917c0c1a27
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -865,6 +865,8 @@ static int pdev_remove(struct platform_device *pdev)
>  	if (priv->fbdev)
>  		omap_fbdev_free(ddev);
> 
> +	drm_atomic_helper_shutdown(ddev);
> +

Can the hardware still be enabled at this point ? If pdev_remove() is called 
we shouldn't have any application holding the device open (otherwise we'll 
crash miserably), and the fbdev compatibility layer is disabled on the 
previous line.

>  	drm_mode_config_cleanup(ddev);
> 
>  	omap_drm_irq_uninstall(ddev);

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-03-29  8:49 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 13:07 [PATCHv3 00/30] drm/omap: miscallaneous improvements Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 01/30] drm/omap: work-around for errata i886 Tomi Valkeinen
2017-03-29  8:00   ` Laurent Pinchart
2017-03-28 13:07 ` [PATCHv3 02/30] drm/omap: refactor CRTC HW property setup Tomi Valkeinen
2017-03-29  8:05   ` Laurent Pinchart
2017-03-29  8:12     ` Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 03/30] drm/omap: remove divider constraint from hsdiv Tomi Valkeinen
2017-03-29  8:09   ` Laurent Pinchart
2017-03-28 13:07 ` [PATCHv3 04/30] drm/omap: decrease min width & height Tomi Valkeinen
2017-03-29  8:13   ` Laurent Pinchart
2017-03-29  8:23     ` Tomi Valkeinen
2017-03-29  8:24       ` Laurent Pinchart
2017-03-29  8:26         ` Tomi Valkeinen
2017-03-29  8:30           ` Laurent Pinchart
2017-03-29  8:43             ` Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 05/30] drm/omap: improve DPI clock selection on DRA7xx Tomi Valkeinen
2017-03-29  8:19   ` Laurent Pinchart
2017-03-29  8:36     ` Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 06/30] drm/omap: Add support for render nodes Tomi Valkeinen
2017-03-29  8:22   ` Laurent Pinchart
2017-03-29  8:58     ` Tomi Valkeinen
2017-03-29 12:20       ` Laurent Pinchart
2017-03-29 12:51         ` David Herrmann
2017-03-29 21:42           ` Laurent Pinchart
2017-03-30  6:44             ` David Herrmann
2017-03-30  7:43               ` Daniel Vetter
2017-03-28 13:07 ` [PATCHv3 07/30] drm/omap: fix HDMI sync polarities Tomi Valkeinen
2017-03-29  8:26   ` Laurent Pinchart
2017-03-28 13:07 ` [PATCHv3 08/30] drm/omap: add omapdss-base.ko Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 09/30] drm/omap: move dss_initialized to omapdss-base Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 10/30] drm/omap: output: use dev_err instead of DSSERR Tomi Valkeinen
2017-03-29  8:32   ` Laurent Pinchart
2017-03-28 13:07 ` [PATCHv3 11/30] drm/omap: display: don't use dsi_get_pixel_size() Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 12/30] drm/omap: move display, dss-of, output to omapdss-base Tomi Valkeinen
2017-03-28 13:07 ` [PATCHv3 13/30] drm/omap: move dispc related dss-feat funcs to dispc Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 14/30] drm/omap: add dispc_ops Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 15/30] drm/omap: fill dispc_ops Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 16/30] drm/omap: use dispc_ops Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 17/30] drm/omap: remove all EXPORT_SYMBOLs from dispc.c Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 18/30] drm/omap: remove unused dispc_wb_enable & dispc_wb_is_enabled Tomi Valkeinen
2017-03-29 11:46   ` Laurent Pinchart
2017-03-28 13:08 ` [PATCHv3 19/30] drm/omap: fix replication logic Tomi Valkeinen
2017-03-29 11:45   ` Laurent Pinchart
2017-03-28 13:08 ` [PATCHv3 20/30] drm/omap: dss: Functions to check components in the display/output list Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 21/30] drm/omap: dss: Support for detecting display stack readiness Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 22/30] drm/omap: Use omapdss_stack_is_ready() to check that the display stack is up Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled Tomi Valkeinen
2017-03-29 10:30   ` Laurent Pinchart
2017-03-30 10:28     ` Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 24/30] drm/omap: display: Add displays in sorted order to the panel_list Tomi Valkeinen
2017-03-29 10:08   ` Laurent Pinchart
2017-03-30 10:58     ` Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 25/30] drm/omap: poll only connectors where the connect/disconnect can be checked Tomi Valkeinen
2017-03-29  9:26   ` Laurent Pinchart
2017-03-28 13:08 ` [PATCHv3 26/30] drm/omap: displays: panel-dpi: Support for handling backlight devices Tomi Valkeinen
2017-03-29  9:13   ` Laurent Pinchart
2017-03-28 13:08 ` [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags Tomi Valkeinen
2017-03-29  9:00   ` Laurent Pinchart
2017-03-29 10:27     ` Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 28/30] drm/omap: fix display SYNC/DE flags Tomi Valkeinen
2017-03-29  8:58   ` Laurent Pinchart
2017-03-29 10:09     ` Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown() Tomi Valkeinen
2017-03-29  8:49   ` Laurent Pinchart [this message]
2017-03-29  9:08     ` Tomi Valkeinen
2017-03-29  9:11       ` Laurent Pinchart
2017-03-29  9:22         ` Tomi Valkeinen
2017-03-28 13:08 ` [PATCHv3 30/30] drm/omap: fix crash on module unload Tomi Valkeinen
2017-03-29  8:38   ` Laurent Pinchart
2017-03-29 12:09 ` [PATCHv3 00/30] drm/omap: miscallaneous improvements Laurent Pinchart
2017-03-29 14:19   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7170884.JmdPD2UAPW@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox