[PATCH] build: workaround build failures with old autoconf version

[PATCH] build: workaround build failures with old autoconf version

[Eryu Guan]

Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due
to old autoreconf didn't pass -I to aclocal -I. This was fixed by
autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I").

So call aclocal, autoheader and autoconf directly instead of
autoreconf, as what's done in xfsprogs Makefile.

Also add include/config.h.in to CONFIGURE, which is generated by
autoheader,  so it also gets removed by make realclean.

Reported-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
---

Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me.

Hi Gwendal, can you please test if cross-compilation still works for chromeOS?
I don't have the chromeOS environment to test.. Thanks!

 Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index ebf5c03..dd8d344 100644
--- a/Makefile
+++ b/Makefile
@@ -41,7 +41,7 @@ endif
 
 SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
 
-CONFIGURE = configure include/builddefs include/config.h \
+CONFIGURE = configure include/builddefs include/config.h include/config.h.in \
 	    aclocal.m4 config.guess config.sub install-sh ltmain.sh \
 	    m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \
 	    m4/lt~obsolete.m4
@@ -79,8 +79,10 @@ clean:  # if configure hasn't run, nothing to clean
 endif
 
 configure: configure.ac
-	autoreconf --include=m4
-	libtoolize -i
+	libtoolize -cfi
+	aclocal -I m4
+	autoheader
+	autoconf
 
 include/builddefs include/config.h: configure
 	./configure \
-- 
2.9.3

Re: [PATCH] build: workaround build failures with old autoconf version

[Xiao Yang]

On 2017/05/16 15:58, Eryu Guan wrote:
> Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due
> to old autoreconf didn't pass -I to aclocal -I. This was fixed by
> autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I").
>
> So call aclocal, autoheader and autoconf directly instead of
> autoreconf, as what's done in xfsprogs Makefile.
>
> Also add include/config.h.in to CONFIGURE, which is generated by
> autoheader,  so it also gets removed by make realclean.
>
> Reported-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>
> Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me.
Hi Eryu

It looks fine and works normally on my RHEL6 host.

Thanks
Xiao Yang
> Hi Gwendal, can you please test if cross-compilation still works for chromeOS?
> I don't have the chromeOS environment to test.. Thanks!
>
>  Makefile | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ebf5c03..dd8d344 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,7 +41,7 @@ endif
>  
>  SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
> -CONFIGURE = configure include/builddefs include/config.h \
> +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \
>  	    aclocal.m4 config.guess config.sub install-sh ltmain.sh \
>  	    m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \
>  	    m4/lt~obsolete.m4
> @@ -79,8 +79,10 @@ clean:  # if configure hasn't run, nothing to clean
>  endif
>  
>  configure: configure.ac
> -	autoreconf --include=m4
> -	libtoolize -i
> +	libtoolize -cfi
> +	aclocal -I m4
> +	autoheader
> +	autoconf
>  
>  include/builddefs include/config.h: configure
>  	./configure \

Re: [PATCH] build: workaround build failures with old autoconf version

[Eryu Guan]

On Tue, May 16, 2017 at 04:26:48PM +0800, Xiao Yang wrote:
> On 2017/05/16 15:58, Eryu Guan wrote:
> > Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due
> > to old autoreconf didn't pass -I to aclocal -I. This was fixed by
> > autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I").
> >
> > So call aclocal, autoheader and autoconf directly instead of
> > autoreconf, as what's done in xfsprogs Makefile.
> >
> > Also add include/config.h.in to CONFIGURE, which is generated by
> > autoheader,  so it also gets removed by make realclean.
> >
> > Reported-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
> >
> > Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me.
> Hi Eryu
> 
> It looks fine and works normally on my RHEL6 host.

Thanks for testing! Can you provide a "Reviewed-by"?

Gwendal, could you please help check if cross-compiling chromeOS still
works after this patch? Thanks a lot!

Eryu

> 
> Thanks
> Xiao Yang
> > Hi Gwendal, can you please test if cross-compilation still works for chromeOS?
> > I don't have the chromeOS environment to test.. Thanks!
> >
> >  Makefile | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index ebf5c03..dd8d344 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -41,7 +41,7 @@ endif
> >  
> >  SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
> >  
> > -CONFIGURE = configure include/builddefs include/config.h \
> > +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \
> >  	    aclocal.m4 config.guess config.sub install-sh ltmain.sh \
> >  	    m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \
> >  	    m4/lt~obsolete.m4
> > @@ -79,8 +79,10 @@ clean:  # if configure hasn't run, nothing to clean
> >  endif
> >  
> >  configure: configure.ac
> > -	autoreconf --include=m4
> > -	libtoolize -i
> > +	libtoolize -cfi
> > +	aclocal -I m4
> > +	autoheader
> > +	autoconf
> >  
> >  include/builddefs include/config.h: configure
> >  	./configure \
> 
> 
> 

Re: [PATCH] build: workaround build failures with old autoconf version

[Xiao Yang]

On 2017/05/25 12:08, Eryu Guan wrote:
> On Tue, May 16, 2017 at 04:26:48PM +0800, Xiao Yang wrote:
>> On 2017/05/16 15:58, Eryu Guan wrote:
>>> Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due
>>> to old autoreconf didn't pass -I to aclocal -I. This was fixed by
>>> autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I").
>>>
>>> So call aclocal, autoheader and autoconf directly instead of
>>> autoreconf, as what's done in xfsprogs Makefile.
>>>
>>> Also add include/config.h.in to CONFIGURE, which is generated by
>>> autoheader,  so it also gets removed by make realclean.
>>>
>>> Reported-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>>> Signed-off-by: Eryu Guan<eguan@redhat.com>
>>> ---
>>>
>>> Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me.
>> Hi Eryu
>>
>> It looks fine and works normally on my RHEL6 host.
> Thanks for testing! Can you provide a "Reviewed-by"?
Hi Eryu

Yeah,  this looks good to me.

Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Thanks,
Xiao Yang.
> Gwendal, could you please help check if cross-compiling chromeOS still
> works after this patch? Thanks a lot!
>
> Eryu
>
>> Thanks
>> Xiao Yang
>>> Hi Gwendal, can you please test if cross-compilation still works for chromeOS?
>>> I don't have the chromeOS environment to test.. Thanks!
>>>
>>>   Makefile | 8 +++++---
>>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index ebf5c03..dd8d344 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -41,7 +41,7 @@ endif
>>>
>>>   SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
>>>
>>> -CONFIGURE = configure include/builddefs include/config.h \
>>> +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \
>>>   	    aclocal.m4 config.guess config.sub install-sh ltmain.sh \
>>>   	    m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \
>>>   	    m4/lt~obsolete.m4
>>> @@ -79,8 +79,10 @@ clean:  # if configure hasn't run, nothing to clean
>>>   endif
>>>
>>>   configure: configure.ac
>>> -	autoreconf --include=m4
>>> -	libtoolize -i
>>> +	libtoolize -cfi
>>> +	aclocal -I m4
>>> +	autoheader
>>> +	autoconf
>>>
>>>   include/builddefs include/config.h: configure
>>>   	./configure \
>>
>>
>
> .
>