Git development
 help / color / mirror / Atom feed
From: tboegi@web.de
To: tboegi@web.de, git@vger.kernel.org, ps@pks.im, taahol@utu.fi
Subject: [PATCH v3 1/1] t1450: use 'mv -f' when overwriting a read-only file
Date: Sun, 25 Oct 2026 19:06:18 +0100	[thread overview]
Message-ID: <20261025180618.16899-1-tboegi@web.de> (raw)
In-Reply-To: <atmvASAoaCIpc_ca@pks.im>

From: Torsten Bögershausen <tboegi@web.de>

Test case 38 in t/t1450-fsck.sh ("rev-list --verify-objects with
truncated loose blob") replaces a loose blob with a truncated
version using `mv obj.tmp "$obj"`.

Because Git creates loose objects as read-only files, this step
attempts to overwrite a read-only file. When running the test,
older versions of macOS `mv(1)` (prior to 12.3)
will prompt the user for confirmation (somewhat shortened):

override r--r--r--  user/staff for .git/objects/fc/a75a5be3823dc0560da5?
(y/n [n]) not overwritten
fca75a5be3823dc0560da57ade678f212aeb33f6

As the answer is not 'y', the file is not overwritten and the
test case fails.

Use `mv -f` to force the overwrite and avoid the interactive
prompt.

Helped-By: Tuomas Ahola <taahol@utu.fi>
Helped-By: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
v3: Use a much shorter commit message, as suggested from Junio.
    Mention that MacOs 12.3 has fixed this.

t/t1450-fsck.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index 16cc5d5dcb..335dcbf0af 100755
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -548,7 +548,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' '
 		# Truncate the loose blob such that its header can still be
 		# parsed, but reading the object data fails mid-stream.
 		test_copy_bytes 64 <"$obj" >obj.tmp &&
-		mv obj.tmp "$obj" &&
+		mv -f obj.tmp "$obj" &&
 
 		test_must_fail git rev-list --verify-objects "$blob" 2>err &&
 		test_grep "hash mismatch" err
-- 
2.53.0.154.g7c02d39fc2


      parent reply	other threads:[~2026-10-25 18:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 23:02 What's cooking in git.git (Oct 2026, #06) Junio C Hamano
2026-10-20 18:51 ` Torsten Bögershausen
2026-10-21  5:45   ` Patrick Steinhardt
2026-10-21 17:46     ` Junio C Hamano
2026-10-22  4:37       ` Torsten Bögershausen
2026-10-22  6:36         ` Patrick Steinhardt
2026-10-24 18:30           ` [PATCH v1 1/1] t1450: use mv -f when overwriting a read only file tboegi
2026-10-24 19:37             ` Tuomas Ahola
2026-10-24 19:43             ` SZEDER Gábor
2026-10-25  4:31             ` Junio C Hamano
2026-10-25  4:33           ` [PATCH v2 " tboegi
2026-10-25  7:06             ` Tuomas Ahola
2026-10-25  9:02               ` Torsten Bögershausen
2026-10-25 16:47                 ` Junio C Hamano
2026-10-25 18:06           ` tboegi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261025180618.16899-1-tboegi@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox