Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: "Tuomas Ahola" <taahol@utu.fi>,
	git@vger.kernel.org, ps@pks.im,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v2 1/1] t1450: use mv -f when overwriting a read only file
Date: Sun, 25 Oct 2026 09:47:03 -0700	[thread overview]
Message-ID: <xmqqv76pybg8.fsf@gitster.g> (raw)
In-Reply-To: <20261025090242.GA25750@tb-raspi4> ("Torsten Bögershausen"'s message of "Sun, 25 Oct 2026 10:02:42 +0100")

Torsten Bögershausen <tboegi@web.de> writes:

> Thanks as well from my side - I will wait a little while before
> sending out v3

Besides typofixes, I wonder if we should tighten the explanation
while keeping only the more important bits, perhaps like

    t1450: use 'mv -f' when overwriting a read-only file

    Test case 38 in t/t1450-fsck.sh ("rev-list --verify-objects with
    truncated loose blob") replaces a loose blob with a truncated
    version using `mv obj.tmp "$obj"`.

    Because Git creates loose objects as read-only files, this step
    attempts to overwrite a read-only file. When running the test
    interactively, older versions of macOS `mv(1)` (prior to 12.3)
    will prompt the user for confirmation, causing the test to hang
    or fail.

    Use `mv -f` to force the overwrite and avoid the interactive
    prompt.

which captures that this is the interactive support of "mv" kicking
in, why the files we replace are read-only, and the fact that 
mv has been fixed since macOS 12.3 (taken from Tuomas's reply).

Thanks.

  reply	other threads:[~2026-10-25 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 23:02 What's cooking in git.git (Oct 2026, #06) Junio C Hamano
2026-10-20 18:51 ` Torsten Bögershausen
2026-10-21  5:45   ` Patrick Steinhardt
2026-10-21 17:46     ` Junio C Hamano
2026-10-22  4:37       ` Torsten Bögershausen
2026-10-22  6:36         ` Patrick Steinhardt
2026-10-24 18:30           ` [PATCH v1 1/1] t1450: use mv -f when overwriting a read only file tboegi
2026-10-24 19:37             ` Tuomas Ahola
2026-10-24 19:43             ` SZEDER Gábor
2026-10-25  4:31             ` Junio C Hamano
2026-10-25  4:33           ` [PATCH v2 " tboegi
2026-10-25  7:06             ` Tuomas Ahola
2026-10-25  9:02               ` Torsten Bögershausen
2026-10-25 16:47                 ` Junio C Hamano [this message]
2026-10-25 18:06           ` [PATCH v3 1/1] t1450: use 'mv -f' when overwriting a read-only file tboegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv76pybg8.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=szeder.dev@gmail.com \
    --cc=taahol@utu.fi \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox