Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: tboegi@web.de
Cc: git@vger.kernel.org,  ps@pks.im
Subject: Re: [PATCH v1 1/1] t1450: use mv -f when overwriting a read only file
Date: Sat, 24 Oct 2026 21:31:31 -0700	[thread overview]
Message-ID: <xmqq5wyqz9i4.fsf@gitster.g> (raw)
In-Reply-To: <20261024183056.6342-1-tboegi@web.de> (tboegi@web.de's message of "Sat, 24 Oct 2026 20:30:56 +0200")

tboegi@web.de writes:

> So it was not the shell being old - but /bin/mv

And the flag you want to use is not -v but -f?

>
> t/t1450-fsck.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> index 16cc5d5dcb..335dcbf0af 100755
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -548,7 +548,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' '
>  		# Truncate the loose blob such that its header can still be
>  		# parsed, but reading the object data fails mid-stream.
>  		test_copy_bytes 64 <"$obj" >obj.tmp &&
> -		mv obj.tmp "$obj" &&
> +		mv -v obj.tmp "$obj" &&
>  
>  		test_must_fail git rev-list --verify-objects "$blob" 2>err &&
>  		test_grep "hash mismatch" err

  parent reply	other threads:[~2026-10-25  4:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 23:02 What's cooking in git.git (Oct 2026, #06) Junio C Hamano
2026-10-20 18:51 ` Torsten Bögershausen
2026-10-21  5:45   ` Patrick Steinhardt
2026-10-21 17:46     ` Junio C Hamano
2026-10-22  4:37       ` Torsten Bögershausen
2026-10-22  6:36         ` Patrick Steinhardt
2026-10-24 18:30           ` [PATCH v1 1/1] t1450: use mv -f when overwriting a read only file tboegi
2026-10-24 19:37             ` Tuomas Ahola
2026-10-24 19:43             ` SZEDER Gábor
2026-10-25  4:31             ` Junio C Hamano [this message]
2026-10-25  4:33           ` [PATCH v2 " tboegi
2026-10-25  7:06             ` Tuomas Ahola
2026-10-25  9:02               ` Torsten Bögershausen
2026-10-25 16:47                 ` Junio C Hamano
2026-10-25 18:06           ` [PATCH v3 1/1] t1450: use 'mv -f' when overwriting a read-only file tboegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5wyqz9i4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox