Git development
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] SubmittingPatches: note that trailer order matters
Date: Tue, 16 Jun 2026 22:18:37 +0200	[thread overview]
Message-ID: <89776d4e-bc61-475f-a12d-167047ddf23e@app.fastmail.com> (raw)
In-Reply-To: <xmqq8q8mt4eo.fsf@gitster.g>

On Thu, Jun 11, 2026, at 00:30, Junio C Hamano wrote:
>>[snip]
>>  Only capitalize the very first letter of the trailer, i.e. favor
>>  `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`.
>>
>> +Note that these trailers should come before your `Signed-off-by:`
>> +trailer. You are signing off to the patch as well as the message. This
>> +also makes it clear who added trailers when multiple people have signed
>> +off on a patch.
>
> Perhaps first mention the underlying rule that they are added in the
> order that helps us to understand the chronological order of events.
> That would avoid giving a wrong impression that the nature of each
> trailer keys determine the order of these lines.

You’re right. It’s best to lead with the time-based order. That
naturally leads into the implication that we can easily read what
trailers that any given person added.

I’ve seen discussions in the past about whether trailers ought to be
sorted by *kind*, and maybe if first e.g. you should first have
Tested-by, then Reviewed-by, then Signed-off-by... best to not give such
an impression by accident.

Thanks.

  reply	other threads:[~2026-06-16 20:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 22:22 [PATCH 0/6] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-11 16:44   ` Junio C Hamano
2026-06-16 20:14     ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 2/6] SubmittingPatches: discuss non-ident trailers kristofferhaugsbakk
2026-06-12 11:35   ` Patrick Steinhardt
2026-06-16 20:02     ` Kristoffer Haugsbakk
2026-06-17  7:32       ` Patrick Steinhardt
2026-06-17 19:43         ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 3/6] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-11 16:46   ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-11 16:52   ` Junio C Hamano
2026-06-16 20:07     ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 5/6] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 6/6] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
2026-06-10 22:30   ` Junio C Hamano
2026-06-16 20:18     ` Kristoffer Haugsbakk [this message]
2026-06-17 20:52 ` [PATCH v2 0/5] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-17 21:41     ` Junio C Hamano
2026-06-17 20:52   ` [PATCH v2 2/5] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 3/5] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 4/5] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 5/5] SubmittingPatches: note that trailer order matters kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89776d4e-bc61-475f-a12d-167047ddf23e@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox