Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org,  Kristoffer Haugsbakk <code@khaugsbakk.name>,
	Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help
Date: Wed, 17 Jun 2026 14:41:36 -0700	[thread overview]
Message-ID: <xmqq4ij0vo8f.fsf@gitster.g> (raw)
In-Reply-To: <V2_encourage_substantial.9b7@msgid.xyz> (kristofferhaugsbakk@fastmail.com's message of "Wed, 17 Jun 2026 22:52:15 +0200")

kristofferhaugsbakk@fastmail.com writes:

> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 176567738d4..0b12badf86d 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -443,8 +443,16 @@ identifying, and not misleading.
>  The goal of this policy is to allow us to have sufficient information to contact
>  you if questions arise about your contribution.
>  
> +=== Commit trailers
>  [[commit-trailers]]
> -If you like, you can put extra trailers at the end:

I think majority of AsciiDoc files in this project places [[anchor]]
before the "=== title" of a section.  For example, here is how the
patch flow section begins in SubmittingPatches:

    [[patch-flow]]
    === A typical life cycle of a patch series

    To help us understand the reason behind various guidelines given later
    in the document, first let's understand how the life cycle of a
    typical patch series for this project goes.

I do not offhand know which way is kosher, but we should be
consistent either way.

Thanks.

  reply	other threads:[~2026-06-17 21:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 22:22 [PATCH 0/6] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-11 16:44   ` Junio C Hamano
2026-06-16 20:14     ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 2/6] SubmittingPatches: discuss non-ident trailers kristofferhaugsbakk
2026-06-12 11:35   ` Patrick Steinhardt
2026-06-16 20:02     ` Kristoffer Haugsbakk
2026-06-17  7:32       ` Patrick Steinhardt
2026-06-17 19:43         ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 3/6] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-11 16:46   ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-11 16:52   ` Junio C Hamano
2026-06-16 20:07     ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 5/6] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 6/6] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
2026-06-10 22:30   ` Junio C Hamano
2026-06-16 20:18     ` Kristoffer Haugsbakk
2026-06-17 20:52 ` [PATCH v2 0/5] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-17 21:41     ` Junio C Hamano [this message]
2026-06-17 20:52   ` [PATCH v2 2/5] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 3/5] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 4/5] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-17 20:52   ` [PATCH v2 5/5] SubmittingPatches: note that trailer order matters kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4ij0vo8f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox