Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: thomas.petazzoni@bootlin.com, luca.ceresoli@bootlin.com,
	 kory.maincent@bootlin.com, markyacoub@google.com,
	 khaled.almahallawy@intel.com,
	Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH i-g-t v10 15/49] lib/monitor_edids: Add helper functions for using monitor_edid objects
Date: Tue, 31 Mar 2026 19:11:32 +0200	[thread overview]
Message-ID: <20260331-unigraf-integration-v10-15-12266c34cc1d@bootlin.com> (raw)
In-Reply-To: <20260331-unigraf-integration-v10-0-12266c34cc1d@bootlin.com>

Introduce the functions edid_from_monitor_edid() and
get_edids_for_connector_type(). The former converts a monitor_edid object
to a struct edid, which can then be utilized by igt_kms helpers. The
latter returns a list of monitor_edid objects for a specific connector
with certain characteristics

Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
---
 lib/monitor_edids/dp_edids.h             |  3 ++
 lib/monitor_edids/hdmi_edids.h           |  3 ++
 lib/monitor_edids/monitor_edids_helper.c | 80 ++++++++++++++++++++++++++++++++
 lib/monitor_edids/monitor_edids_helper.h |  7 ++-
 4 files changed, 92 insertions(+), 1 deletion(-)

diff --git a/lib/monitor_edids/dp_edids.h b/lib/monitor_edids/dp_edids.h
index 144907558be1..07793381257e 100644
--- a/lib/monitor_edids/dp_edids.h
+++ b/lib/monitor_edids/dp_edids.h
@@ -194,4 +194,7 @@ monitor_edid DP_EDIDS_NON_4K[] = {
 
  };
 
+#define DP_EDIDS_4K_COUNT ARRAY_SIZE(DP_EDIDS_4K)
+#define DP_EDIDS_NON_4K_COUNT ARRAY_SIZE(DP_EDIDS_NON_4K)
+
 #endif /* TESTS_CHAMELIUM_MONITOR_EDIDS_DP_EDIDS_H_ */
diff --git a/lib/monitor_edids/hdmi_edids.h b/lib/monitor_edids/hdmi_edids.h
index f6cfe82ff6e1..3984241775c3 100644
--- a/lib/monitor_edids/hdmi_edids.h
+++ b/lib/monitor_edids/hdmi_edids.h
@@ -604,4 +604,7 @@ monitor_edid HDMI_EDIDS_NON_4K[] = {
 		  "1620582c2500baac4200009e0000006b" },
 };
 
+#define HDMI_EDIDS_4K_COUNT ARRAY_SIZE(HDMI_EDIDS_4K)
+#define HDMI_EDIDS_NON_4K_COUNT ARRAY_SIZE(HDMI_EDIDS_NON_4K)
+
 #endif /* TESTS_CHAMELIUM_MONITOR_EDIDS_HDMI_EDIDS_H_ */
diff --git a/lib/monitor_edids/monitor_edids_helper.c b/lib/monitor_edids/monitor_edids_helper.c
index 1cbf1c22f0bb..9cb9c7e1a665 100644
--- a/lib/monitor_edids/monitor_edids_helper.c
+++ b/lib/monitor_edids/monitor_edids_helper.c
@@ -15,6 +15,10 @@
 #include <assert.h>
 
 #include "igt_core.h"
+#include "igt_edid.h"
+#include "dp_edids.h"
+#include "drmtest.h"
+#include "hdmi_edids.h"
 
 static uint8_t convert_hex_char_to_byte(char c)
 {
@@ -90,3 +94,79 @@ void free_chamelium_edid_from_monitor_edid(struct chamelium_edid *edid)
 	free(edid);
 	edid = NULL;
 }
+
+/**
+ * edid_from_monitor_edid:
+ * @mon_edid: Monitor EDID to convert
+ *
+ * Get a struct edid from a monitor_edid. This returns a pointer to a newly allocated struct edid.
+ * The caller is in charge to free this pointer when required.
+ */
+struct edid *edid_from_monitor_edid(const monitor_edid *mon_edid)
+{
+	uint8_t *raw_edid;
+	size_t edid_size;
+	int i;
+
+	edid_size = strlen(mon_edid->edid) / 2; /* each ascii is a nibble. */
+	raw_edid = malloc(edid_size);
+	igt_assert(raw_edid);
+
+	for (i = 0; i < edid_size; i++) {
+		raw_edid[i] = convert_hex_char_to_byte(mon_edid->edid[i * 2]) << 4 |
+			      convert_hex_char_to_byte(mon_edid->edid[i * 2 + 1]);
+	}
+
+	if (edid_get_size((struct edid *)raw_edid) > edid_size) {
+		uint8_t *new_edid;
+
+		igt_debug("The edid size stored in the raw edid is longer than the edid stored in the table.");
+		new_edid = realloc(raw_edid, edid_get_size((struct edid *)raw_edid));
+		igt_assert(new_edid);
+		raw_edid = new_edid;
+	}
+
+	return (struct edid *)raw_edid;
+}
+
+/**
+ * get_edids_for_connector_type:
+ * @type: The connector type to get the EDIDs from
+ * @count: Used to store the number of EDIDs in the returned list
+ * @four_k: Use true to fetch 4k EDIDs, false to fetch non-4k EDIDs
+ *
+ * Get the list of EDIDS for a specific connector type. This returns a pointer to a static list,
+ * so no need to free the pointer.
+ */
+const struct monitor_edid *get_edids_for_connector_type(uint32_t type, size_t *count, bool four_k)
+{
+	if (four_k) {
+		switch (type) {
+		case DRM_MODE_CONNECTOR_DisplayPort:
+			*count = DP_EDIDS_4K_COUNT;
+			return DP_EDIDS_4K;
+		case DRM_MODE_CONNECTOR_HDMIA:
+			*count = HDMI_EDIDS_4K_COUNT;
+			return HDMI_EDIDS_4K;
+		default:
+			*count = 0;
+			igt_debug("No 4k EDID for the connector %s\n",
+				  kmstest_connector_type_str(type));
+			return NULL;
+		}
+	} else {
+		switch (type) {
+		case DRM_MODE_CONNECTOR_DisplayPort:
+			*count = DP_EDIDS_NON_4K_COUNT;
+			return DP_EDIDS_NON_4K;
+		case DRM_MODE_CONNECTOR_HDMIA:
+			*count = HDMI_EDIDS_NON_4K_COUNT;
+			return HDMI_EDIDS_NON_4K;
+		default:
+			*count = 0;
+			igt_debug("No EDID for the connector %s\n",
+				  kmstest_connector_type_str(type));
+			return NULL;
+		}
+	}
+}
diff --git a/lib/monitor_edids/monitor_edids_helper.h b/lib/monitor_edids/monitor_edids_helper.h
index 05679f0897f3..f5f6f6824411 100644
--- a/lib/monitor_edids/monitor_edids_helper.h
+++ b/lib/monitor_edids/monitor_edids_helper.h
@@ -11,6 +11,8 @@
 #ifndef TESTS_CHAMELIUM_MONITOR_EDIDS_MONITOR_EDIDS_HELPER_H_
 #define TESTS_CHAMELIUM_MONITOR_EDIDS_MONITOR_EDIDS_HELPER_H_
 
+#include <stddef.h>
+#include <stdbool.h>
 #include <stdint.h>
 
 #include "igt_chamelium.h"
@@ -30,4 +32,7 @@ get_chameleon_edid_from_monitor_edid(struct chamelium *chamelium,
 				     const monitor_edid *edid);
 void free_chamelium_edid_from_monitor_edid(struct chamelium_edid *edid);
 
-#endif /* TESTS_CHAMELIUM_MONITOR_EDIDS_MONITOR_EDIDS_HELPER_H_ */
\ No newline at end of file
+struct edid *edid_from_monitor_edid(const monitor_edid *monitor_edid);
+const struct monitor_edid *get_edids_for_connector_type(uint32_t type, size_t *count, bool four_k);
+
+#endif /* TESTS_CHAMELIUM_MONITOR_EDIDS_MONITOR_EDIDS_HELPER_H_ */

-- 
2.52.0


  parent reply	other threads:[~2026-03-31 17:15 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 17:11 [PATCH i-g-t v10 00/49] Unigraf integration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 01/49] lib/igt_kms: Add a detect timeout value Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 02/49] lib/igt_kms: Add helper to wait for a specific status on a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 03/49] lib/igt_kms: Add function to list connected connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 04/49] lib/igt_kms: Add helper to obtain a connector by its name or MST path Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 05/49] lib/igt_kms: Add helper to wait for new connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 06/49] lib/tests: Add tests for array manipulations Louis Chauvet
2026-04-20 16:08   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 07/49] lib/igt_kms: Add helper to get a pipe from a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 08/49] lib/igt_kms: Expose dump_connector_attrs Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 09/49] lib/igt_kms: Expose reset_connectors_at_exit Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 10/49] lib/igt_kms: Expose connector_attr_set and igt_connector_attr_set Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 11/49] lib/igt_debugfs: Move debugfs helpers to the proper location Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 12/49] lib/igt_debugfs: Add const when make sense Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 13/49] lib/igt_amd: " Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 14/49] lib/igt_kms: " Louis Chauvet
2026-03-31 17:11 ` Louis Chauvet [this message]
2026-03-31 17:11 ` [PATCH i-g-t v10 16/49] lib/monitor_edids: Add helper to get an EDID by its name Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 17/49] lib/monitor_edids: Add helper to print all available EDID names Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 18/49] lib/unigraf: Add used defines for TSI_Types Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 19/49] lib/unigraf: Add TSI.h Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 20/49] lib/unigraf: Initial Unigraf support Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 21/49] lib/igt_kms: Automatically connect unigraf on display require Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 22/49] lib/unigraf: Introduce device configuration Louis Chauvet
2026-04-20 16:10   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 23/49] lib/unigraf: Introduce role configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 24/49] lib/unigraf: Introduce input configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 25/49] lib/unigraf: Add reset function Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 26/49] lib/unigraf: Add unigraf assert and deassert helpers Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 27/49] lib/unigraf: Add plug/unplug helpers Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 28/49] lib/unigraf: Allows sst/mst configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 29/49] lib/unigraf: Add helpers to read and write edid Louis Chauvet
2026-04-20 16:29   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 30/49] lib/unigraf: Add connector and EDID configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 31/49] tests/unigraf: Add basic unigraf tests Louis Chauvet
2026-04-20 16:49   ` Kory Maincent
2026-04-23  5:45     ` Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 32/49] lib/unigraf: Add unigraf CRC capture Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 33/49] lib/unigraf: Add configuration for CRC usage Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 34/49] lib/unigraf: add unigraf_get_connector_by_stream Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 35/49] lib/unigraf: Add helper to check timings received by unigraf Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 36/49] lib/igt_pipe_crc: Add unigraf crc calculation Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 37/49] lib/i915/dp: Move DP-related function for i915 to proper folder Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 38/49] lib/i915/dp: Rename functions to avoid confusion Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 39/49] lib/i915/dp: Add helper to get maximum supported rate Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 40/49] lib/i915/dp: Properly check sscanf results Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 41/49] lib/i915/dp: Use igt_output_name instead of private field Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 42/49] lib/igt_dp: Create generic helpers for DP information Louis Chauvet
2026-04-24 15:49   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 43/49] lib/igt_kms: Add asserts to avoid null pointer dereference Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 44/49] lib/igt_kms: Add helper to get a CRTC from an output Louis Chauvet
2026-04-20 16:07   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 45/49] lib/unigraf: Add lane count configuration Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 46/49] docs/unigraf: Add unigraf documentation Louis Chauvet
2026-04-20 16:06   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 47/49] lib/unigraf: Add helpers to set maximum link rate Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 48/49] lib/unigraf: Add helpers to get the current LT status Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 49/49] tests/unigraf/unigraf_lt: Add test for link training Louis Chauvet
2026-03-31 17:49 ` ✓ Xe.CI.BAT: success for Unigraf integration (rev9) Patchwork
2026-03-31 18:17 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-31 23:45 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331-unigraf-integration-v10-15-12266c34cc1d@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=khaled.almahallawy@intel.com \
    --cc=kory.maincent@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=markyacoub@google.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox