Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: thomas.petazzoni@bootlin.com, luca.ceresoli@bootlin.com,
	 kory.maincent@bootlin.com, markyacoub@google.com,
	 khaled.almahallawy@intel.com,
	Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH i-g-t v10 28/49] lib/unigraf: Allows sst/mst configuration
Date: Tue, 31 Mar 2026 19:11:45 +0200	[thread overview]
Message-ID: <20260331-unigraf-integration-v10-28-12266c34cc1d@bootlin.com> (raw)
In-Reply-To: <20260331-unigraf-integration-v10-0-12266c34cc1d@bootlin.com>

Unigraf devices can emulate both SST and MST display port. In order to
write tests using both, add fews helper to manipulate them.

The define TSI_DPRX_NOT_DOCUMENTED_SIDEBAND_MSG_SUPPORT is taken from the
python SDK, as it was not defined by the C sdk nor documented.

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
 lib/vendor/unigraf/unigraf.c | 111 +++++++++++++++++++++++++++++++++++++++++++
 lib/vendor/unigraf/unigraf.h |  12 +++++
 2 files changed, 123 insertions(+)

diff --git a/lib/vendor/unigraf/unigraf.c b/lib/vendor/unigraf/unigraf.c
index 1552a90e05b6..930dd129d091 100644
--- a/lib/vendor/unigraf/unigraf.c
+++ b/lib/vendor/unigraf/unigraf.c
@@ -109,6 +109,25 @@ static void unigraf_init(void)
 		unigraf_assert(TSIX_TS_SetConfigItem(unigraf_device, config_id, &v, sizeof(value)));		\
 	})
 
+/**
+ * unigraf_read_u32 - Read a 32-bit value from a TSI configuration item with error handling
+ * @config_id: The configuration item ID to read from
+ *
+ * This macro reads a 32-bit value from the specified TSI configuration item.
+ * It includes error handling and debug output. This is a macro to have the proper
+ * line information when using unigraf_debug.
+ *
+ * Returns: The 32-bit value read from the configuration item
+ */
+#define unigraf_read_u32(config_id)										\
+	({													\
+		uint32_t value;											\
+		igt_assert(unigraf_device);									\
+		unigraf_assert(TSIX_TS_GetConfigItem(unigraf_device, config_id, &value, sizeof(value)));	\
+		unigraf_debug("Value read: " #config_id "=%d\n", value);					\
+		value;												\
+	})
+
 /**
  * unigraf_device_count() - Return the number of scanned devices
  *
@@ -310,6 +329,8 @@ void unigraf_require_device(int drm_fd)
 void unigraf_reset(void)
 {
 	unigraf_plug();
+	unigraf_set_mst_stream_count(1);
+	unigraf_set_sst();
 }
 
 /**
@@ -372,3 +393,93 @@ void unigraf_plug(void)
 
 	unigraf_write_u32(TSI_DPRX_HPD_FORCE, d);
 }
+
+/**
+ * unigraf_set_sst() - Configure the device for Single Stream Transport mode
+ *
+ * This function sets the device to operate in Single Stream Transport (SST) mode.
+ */
+void unigraf_set_sst(void)
+{
+	int link_flags = 0xFFFFFFFF;
+
+	unigraf_assert(TSIX_TS_GetConfigItem(unigraf_device, TSI_DPRX_LINK_FLAGS,
+					     &link_flags, sizeof(link_flags)));
+	link_flags &= ~(TSI_DPRX_LINK_FLAGS_MST | TSI_DPRX_NOT_DOCUMENTED_SIDEBAND_MSG_SUPPORT);
+	unigraf_write_u32(TSI_DPRX_LINK_FLAGS, link_flags);
+}
+
+/**
+ * unigraf_set_mst() - Configure the device for Multi Stream Transport mode
+ *
+ * This function sets the device to operate in Multi Stream Transport (MST) mode.
+ */
+void unigraf_set_mst(void)
+{
+	int link_flags = 0xFFFFFFFF;
+
+	unigraf_assert(TSIX_TS_GetConfigItem(unigraf_device, TSI_DPRX_LINK_FLAGS,
+					     &link_flags, sizeof(link_flags)));
+	link_flags |= TSI_DPRX_LINK_FLAGS_MST | TSI_DPRX_NOT_DOCUMENTED_SIDEBAND_MSG_SUPPORT;
+	unigraf_write_u32(TSI_DPRX_LINK_FLAGS, link_flags);
+}
+
+/**
+ * unigraf_get_mst_stream_max_count() - Get the maximum number of stream count accepted by the
+ * device
+ * Caution: This function can be destructive to some configuration: the only way to get the
+ * information is to try and read the new value.
+ */
+int unigraf_get_mst_stream_max_count(void)
+{
+	struct TSI_DPRX_HW_CAPS_R_s caps;
+
+	unigraf_assert(TSIX_TS_GetConfigItem(unigraf_device, TSI_DPRX_HW_CAPS_R,
+					     &caps, sizeof(caps)));
+
+	return caps.mst_stream_count;
+}
+
+/**
+ * unigraf_get_mst_stream_count() - Get the current number of MST streams
+ *
+ * Returns: The current number of MST streams configured on the device.
+ */
+int unigraf_get_mst_stream_count(void)
+{
+	return unigraf_read_u32(TSI_DPRX_MST_SINK_COUNT);
+}
+
+/**
+ * unigraf_set_mst_stream_count() - Set the number of accepted stream count
+ *
+ * Returns true when the stream count was properly applied, false if the final stream count
+ * is not the one requested
+ */
+bool unigraf_set_mst_stream_count(int count)
+{
+	int new_count;
+
+	igt_assert_lte(count, unigraf_get_mst_stream_max_count());
+
+	unigraf_write_u32(TSI_DPRX_MST_SINK_COUNT, count);
+	new_count = unigraf_get_mst_stream_count();
+
+	igt_warn_on_f(count != new_count,
+		      "IGT:%p: Requested MST stream count (%d) differs from what was applied by the device (%d)\n",
+		      unigraf_device, count, new_count);
+
+	return count == new_count;
+}
+
+/**
+ * unigraf_select_stream() - Select the active stream for the device
+ * @stream: The stream index to select
+ *
+ * This function selects the active stream for the device. The stream index
+ * should be a valid stream number that the device supports.
+ */
+void unigraf_select_stream(int stream)
+{
+	unigraf_write_u32(TSI_DPRX_STREAM_SELECT, stream);
+}
diff --git a/lib/vendor/unigraf/unigraf.h b/lib/vendor/unigraf/unigraf.h
index ae1f0d8955ab..c2caa9c2c54c 100644
--- a/lib/vendor/unigraf/unigraf.h
+++ b/lib/vendor/unigraf/unigraf.h
@@ -52,4 +52,16 @@ void unigraf_plug(void);
 
 void unigraf_unplug(void);
 
+void unigraf_set_sst(void);
+
+void unigraf_set_mst(void);
+
+int unigraf_get_mst_stream_count(void);
+
+bool unigraf_set_mst_stream_count(int count);
+
+int unigraf_get_mst_stream_max_count(void);
+
+void unigraf_select_stream(int stream);
+
 #endif // UNIGRAF_H

-- 
2.52.0


  parent reply	other threads:[~2026-03-31 17:12 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 17:11 [PATCH i-g-t v10 00/49] Unigraf integration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 01/49] lib/igt_kms: Add a detect timeout value Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 02/49] lib/igt_kms: Add helper to wait for a specific status on a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 03/49] lib/igt_kms: Add function to list connected connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 04/49] lib/igt_kms: Add helper to obtain a connector by its name or MST path Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 05/49] lib/igt_kms: Add helper to wait for new connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 06/49] lib/tests: Add tests for array manipulations Louis Chauvet
2026-04-20 16:08   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 07/49] lib/igt_kms: Add helper to get a pipe from a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 08/49] lib/igt_kms: Expose dump_connector_attrs Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 09/49] lib/igt_kms: Expose reset_connectors_at_exit Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 10/49] lib/igt_kms: Expose connector_attr_set and igt_connector_attr_set Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 11/49] lib/igt_debugfs: Move debugfs helpers to the proper location Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 12/49] lib/igt_debugfs: Add const when make sense Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 13/49] lib/igt_amd: " Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 14/49] lib/igt_kms: " Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 15/49] lib/monitor_edids: Add helper functions for using monitor_edid objects Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 16/49] lib/monitor_edids: Add helper to get an EDID by its name Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 17/49] lib/monitor_edids: Add helper to print all available EDID names Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 18/49] lib/unigraf: Add used defines for TSI_Types Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 19/49] lib/unigraf: Add TSI.h Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 20/49] lib/unigraf: Initial Unigraf support Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 21/49] lib/igt_kms: Automatically connect unigraf on display require Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 22/49] lib/unigraf: Introduce device configuration Louis Chauvet
2026-04-20 16:10   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 23/49] lib/unigraf: Introduce role configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 24/49] lib/unigraf: Introduce input configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 25/49] lib/unigraf: Add reset function Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 26/49] lib/unigraf: Add unigraf assert and deassert helpers Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 27/49] lib/unigraf: Add plug/unplug helpers Louis Chauvet
2026-03-31 17:11 ` Louis Chauvet [this message]
2026-03-31 17:11 ` [PATCH i-g-t v10 29/49] lib/unigraf: Add helpers to read and write edid Louis Chauvet
2026-04-20 16:29   ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 30/49] lib/unigraf: Add connector and EDID configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 31/49] tests/unigraf: Add basic unigraf tests Louis Chauvet
2026-04-20 16:49   ` Kory Maincent
2026-04-23  5:45     ` Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 32/49] lib/unigraf: Add unigraf CRC capture Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 33/49] lib/unigraf: Add configuration for CRC usage Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 34/49] lib/unigraf: add unigraf_get_connector_by_stream Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 35/49] lib/unigraf: Add helper to check timings received by unigraf Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 36/49] lib/igt_pipe_crc: Add unigraf crc calculation Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 37/49] lib/i915/dp: Move DP-related function for i915 to proper folder Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 38/49] lib/i915/dp: Rename functions to avoid confusion Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 39/49] lib/i915/dp: Add helper to get maximum supported rate Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 40/49] lib/i915/dp: Properly check sscanf results Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 41/49] lib/i915/dp: Use igt_output_name instead of private field Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 42/49] lib/igt_dp: Create generic helpers for DP information Louis Chauvet
2026-04-24 15:49   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 43/49] lib/igt_kms: Add asserts to avoid null pointer dereference Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 44/49] lib/igt_kms: Add helper to get a CRTC from an output Louis Chauvet
2026-04-20 16:07   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 45/49] lib/unigraf: Add lane count configuration Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 46/49] docs/unigraf: Add unigraf documentation Louis Chauvet
2026-04-20 16:06   ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 47/49] lib/unigraf: Add helpers to set maximum link rate Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 48/49] lib/unigraf: Add helpers to get the current LT status Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 49/49] tests/unigraf/unigraf_lt: Add test for link training Louis Chauvet
2026-03-31 17:49 ` ✓ Xe.CI.BAT: success for Unigraf integration (rev9) Patchwork
2026-03-31 18:17 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-31 23:45 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331-unigraf-integration-v10-28-12266c34cc1d@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=khaled.almahallawy@intel.com \
    --cc=kory.maincent@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=markyacoub@google.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox