From: Louis Chauvet <louis.chauvet@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: thomas.petazzoni@bootlin.com, luca.ceresoli@bootlin.com,
kory.maincent@bootlin.com, markyacoub@google.com,
khaled.almahallawy@intel.com,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH i-g-t v10 41/49] lib/i915/dp: Use igt_output_name instead of private field
Date: Tue, 31 Mar 2026 19:11:58 +0200 [thread overview]
Message-ID: <20260331-unigraf-integration-v10-41-12266c34cc1d@bootlin.com> (raw)
In-Reply-To: <20260331-unigraf-integration-v10-0-12266c34cc1d@bootlin.com>
output->name is a private field, use the common helper igt_output_name
instead of the field directly.
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
lib/i915/i915_dp.c | 43 ++++++++++++++++++++++---------------------
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/lib/i915/i915_dp.c b/lib/i915/i915_dp.c
index c2cddb955d75..e54058580ff2 100644
--- a/lib/i915/i915_dp.c
+++ b/lib/i915/i915_dp.c
@@ -35,6 +35,7 @@
#include "i915_dp.h"
#include "igt_core.h"
+#include "igt_kms.h"
/**
* i915_dp_parse_marked_value:
@@ -78,13 +79,13 @@ int i915_dp_get_current_link_rate(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_link_rate",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_force_link_rate\n",
- output->name);
+ igt_output_name(output));
res = i915_dp_parse_marked_value(buf, '*', &ret);
- igt_assert_f(res == 0, "Output %s not enabled\n", output->name);
+ igt_assert_f(res == 0, "Output %s not enabled\n", igt_output_name(output));
return ret;
}
@@ -100,13 +101,13 @@ int i915_dp_get_current_lane_count(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_lane_count",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_force_lane_count\n",
- output->name);
+ igt_output_name(output));
res = i915_dp_parse_marked_value(buf, '*', &ret);
- igt_assert_f(res == 0, "Output %s not enabled\n", output->name);
+ igt_assert_f(res == 0, "Output %s not enabled\n", igt_output_name(output));
return ret;
}
@@ -122,11 +123,11 @@ int i915_dp_get_max_link_rate(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_max_link_rate",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_max_link_rate\n",
- output->name);
+ igt_output_name(output));
igt_assert_f(sscanf(buf, "%d", &ret) == 1,
"Failed to parse max link rate from %s\n", buf);
@@ -146,11 +147,11 @@ int i915_dp_get_max_lane_count(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_max_lane_count",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_max_lane_count\n",
- output->name);
+ igt_output_name(output));
igt_assert_f(sscanf(buf, "%d", &ret) == 1,
"Failed to parse max lane count from %s\n", buf);
@@ -172,11 +173,11 @@ void i915_dp_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_co
int res;
snprintf(value, sizeof(value), "%d", retrain_count);
- res = igt_debugfs_write_connector_file(drm_fd, output->name,
+ res = igt_debugfs_write_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_link_retrain",
value, strlen(value));
igt_assert_f(res == 0, "Unable to write to %s/i915_dp_force_link_retrain\n",
- output->name);
+ igt_output_name(output));
}
/**
@@ -196,11 +197,11 @@ void i915_dp_force_lt_failure(int drm_fd, igt_output_t *output, int failure_coun
int res;
snprintf(value, sizeof(value), "%d", failure_count);
- res = igt_debugfs_write_connector_file(drm_fd, output->name,
+ res = igt_debugfs_write_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_link_training_failure",
value, strlen(value));
igt_assert_f(res == 0, "Unable to write to %s/i915_dp_force_link_training_failure\n",
- output->name);
+ igt_output_name(output));
}
/**
@@ -215,11 +216,11 @@ bool i915_dp_get_link_retrain_disabled(int drm_fd, igt_output_t *output)
char buf[512];
int res;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_link_retrain_disabled",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_link_retrain_disabled\n",
- output->name);
+ igt_output_name(output));
return strstr(buf, "yes");
}
@@ -238,7 +239,7 @@ bool i915_dp_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *ou
char buf[512];
int res;
- res = igt_debugfs_read_connector_file(drmfd, output->name,
+ res = igt_debugfs_read_connector_file(drmfd, igt_output_name(output),
"i915_dp_link_retrain_disabled",
buf, sizeof(buf));
return res == 0;
@@ -256,11 +257,11 @@ int i915_dp_get_pending_lt_failures(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_link_training_failure",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_force_link_training_failure\n",
- output->name);
+ igt_output_name(output));
igt_assert_f(sscanf(buf, "%d", &ret) == 1,
"Failed to parse pending link training failures from %s\n", buf);
@@ -280,11 +281,11 @@ int i915_dp_get_pending_retrain(int drm_fd, igt_output_t *output)
char buf[512];
int res, ret;
- res = igt_debugfs_read_connector_file(drm_fd, output->name,
+ res = igt_debugfs_read_connector_file(drm_fd, igt_output_name(output),
"i915_dp_force_link_retrain",
buf, sizeof(buf));
igt_assert_f(res == 0, "Unable to read %s/i915_dp_force_link_retrain\n",
- output->name);
+ igt_output_name(output));
igt_assert_f(sscanf(buf, "%d", &ret) == 1,
"Failed to parse pending link retrains from %s\n", buf);
--
2.52.0
next prev parent reply other threads:[~2026-03-31 17:13 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 17:11 [PATCH i-g-t v10 00/49] Unigraf integration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 01/49] lib/igt_kms: Add a detect timeout value Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 02/49] lib/igt_kms: Add helper to wait for a specific status on a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 03/49] lib/igt_kms: Add function to list connected connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 04/49] lib/igt_kms: Add helper to obtain a connector by its name or MST path Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 05/49] lib/igt_kms: Add helper to wait for new connectors Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 06/49] lib/tests: Add tests for array manipulations Louis Chauvet
2026-04-20 16:08 ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 07/49] lib/igt_kms: Add helper to get a pipe from a connector Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 08/49] lib/igt_kms: Expose dump_connector_attrs Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 09/49] lib/igt_kms: Expose reset_connectors_at_exit Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 10/49] lib/igt_kms: Expose connector_attr_set and igt_connector_attr_set Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 11/49] lib/igt_debugfs: Move debugfs helpers to the proper location Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 12/49] lib/igt_debugfs: Add const when make sense Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 13/49] lib/igt_amd: " Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 14/49] lib/igt_kms: " Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 15/49] lib/monitor_edids: Add helper functions for using monitor_edid objects Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 16/49] lib/monitor_edids: Add helper to get an EDID by its name Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 17/49] lib/monitor_edids: Add helper to print all available EDID names Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 18/49] lib/unigraf: Add used defines for TSI_Types Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 19/49] lib/unigraf: Add TSI.h Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 20/49] lib/unigraf: Initial Unigraf support Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 21/49] lib/igt_kms: Automatically connect unigraf on display require Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 22/49] lib/unigraf: Introduce device configuration Louis Chauvet
2026-04-20 16:10 ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 23/49] lib/unigraf: Introduce role configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 24/49] lib/unigraf: Introduce input configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 25/49] lib/unigraf: Add reset function Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 26/49] lib/unigraf: Add unigraf assert and deassert helpers Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 27/49] lib/unigraf: Add plug/unplug helpers Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 28/49] lib/unigraf: Allows sst/mst configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 29/49] lib/unigraf: Add helpers to read and write edid Louis Chauvet
2026-04-20 16:29 ` Kory Maincent
2026-03-31 17:11 ` [PATCH i-g-t v10 30/49] lib/unigraf: Add connector and EDID configuration Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 31/49] tests/unigraf: Add basic unigraf tests Louis Chauvet
2026-04-20 16:49 ` Kory Maincent
2026-04-23 5:45 ` Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 32/49] lib/unigraf: Add unigraf CRC capture Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 33/49] lib/unigraf: Add configuration for CRC usage Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 34/49] lib/unigraf: add unigraf_get_connector_by_stream Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 35/49] lib/unigraf: Add helper to check timings received by unigraf Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 36/49] lib/igt_pipe_crc: Add unigraf crc calculation Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 37/49] lib/i915/dp: Move DP-related function for i915 to proper folder Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 38/49] lib/i915/dp: Rename functions to avoid confusion Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 39/49] lib/i915/dp: Add helper to get maximum supported rate Louis Chauvet
2026-03-31 17:11 ` [PATCH i-g-t v10 40/49] lib/i915/dp: Properly check sscanf results Louis Chauvet
2026-03-31 17:11 ` Louis Chauvet [this message]
2026-03-31 17:11 ` [PATCH i-g-t v10 42/49] lib/igt_dp: Create generic helpers for DP information Louis Chauvet
2026-04-24 15:49 ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 43/49] lib/igt_kms: Add asserts to avoid null pointer dereference Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 44/49] lib/igt_kms: Add helper to get a CRTC from an output Louis Chauvet
2026-04-20 16:07 ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 45/49] lib/unigraf: Add lane count configuration Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 46/49] docs/unigraf: Add unigraf documentation Louis Chauvet
2026-04-20 16:06 ` Kory Maincent
2026-03-31 17:12 ` [PATCH i-g-t v10 47/49] lib/unigraf: Add helpers to set maximum link rate Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 48/49] lib/unigraf: Add helpers to get the current LT status Louis Chauvet
2026-03-31 17:12 ` [PATCH i-g-t v10 49/49] tests/unigraf/unigraf_lt: Add test for link training Louis Chauvet
2026-03-31 17:49 ` ✓ Xe.CI.BAT: success for Unigraf integration (rev9) Patchwork
2026-03-31 18:17 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-31 23:45 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331-unigraf-integration-v10-41-12266c34cc1d@bootlin.com \
--to=louis.chauvet@bootlin.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=khaled.almahallawy@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=markyacoub@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox