Re: [PATCH i-g-t v10 29/49] lib/unigraf: Add helpers to read and write edid

[Kory Maincent <kory.maincent@bootlin.com>]

On Tue, 31 Mar 2026 19:11:46 +0200
Louis Chauvet <louis.chauvet@bootlin.com> wrote:

> Read and writing EDID on unigraf can be useful to emulate different
> screens, add helpers to read and write them.
> 
> There is a limitation on the libTSI.so, it is only possible to read EDID
> using buffers of size multiple of 128 bytes, and there is no way to query
> the actual EDID size. The current implementation can only read EDID up to
> 2048 bytes.
> 
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  lib/vendor/unigraf/unigraf.c | 60
> ++++++++++++++++++++++++++++++++++++++++++++ lib/vendor/unigraf/unigraf.h |
> 4 +++ 2 files changed, 64 insertions(+)
> 
> diff --git a/lib/vendor/unigraf/unigraf.c b/lib/vendor/unigraf/unigraf.c
> index 930dd129d091..68c322a0302b 100644
> --- a/lib/vendor/unigraf/unigraf.c
> +++ b/lib/vendor/unigraf/unigraf.c
> @@ -14,6 +14,7 @@
>  #include "unigraf.h"
>  #include "TSI.h"
>  #include "TSI_types.h"
> +#include "igt_aux.h"
>  #include "igt_rc.h"
>  
>  #define unigraf_debug(fmt, ...)	igt_debug("TSI:%p: " fmt,
> unigraf_device, ##__VA_ARGS__) @@ -57,6 +58,11 @@ static char
> *unigraf_connector_name; */
>  #define UNIGRAF_DEFAULT_INPUT_NAME "DP RX"
>  
> +/**
> + * UNIGRAF_EDID_MAX_SIZE - Max EDID size that can be read from the unigraf.
> The
> + */
> +#define UNIGRAF_EDID_MAX_SIZE 2048
> +
>  static void unigraf_close_device(void)
>  {
>  	if (!unigraf_device)
> @@ -128,6 +134,20 @@ static void unigraf_init(void)
>  		value;
> 						\ })
>  
> +/**
> + * unigraf_write() - Helper to write a value to unigraf
> + * @config: config id to write
> + * @data: data to write
> + * @data_len: length of the data
> + * Returns
> + */

Returns void? ;)
With this removed you can add my Reviewed-by.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com