[igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index

public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed

* [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index
@ 2019-07-25 20:33 Lucas De Marchi
  2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
                   ` (7 more replies)
  0 siblings, 8 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 20:33 UTC (permalink / raw)
  To: igt-dev

This helps to identify which entry is wrong in the table.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/i915/gem_mocs_settings.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index 1a311b8c..7b1718f4 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -322,8 +322,10 @@ static void check_control_registers(int fd,
 	for (int index = 0; index < table.size; index++) {
 		if (!table.table[index].used)
 			continue;
-		igt_assert_eq_u32(read_regs[index],
-				  table.table[index].control_value);
+
+		igt_assert_f(
+			read_regs[index] == table.table[index].control_value,
+			"engine=%u index=%u", engine, index);
 	}
 
 	munmap(read_regs, 4096);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
@ 2019-07-25 20:33 ` Lucas De Marchi
  2019-07-26 20:49   ` Daniele Ceraolo Spurio
  2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 20:33 UTC (permalink / raw)
  To: igt-dev

In the Ice Lake table we are setting all undefined entries to PTE.
With Tiger Lake this won't be true anymore. Even if for test in IGT we
add a new table for Tiger Lake, in kernel they can be shares since they
are supposedly compatible (only unused entries were added or became
unused).

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/i915/gem_mocs_settings.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index 7b1718f4..9f4e1b6d 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -101,7 +101,6 @@ static const struct mocs_entry icelake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
 	[21] = { 0x00000137, 0x0030, 0x1},
 	[22] = { 0x000003b7, 0x0030, 0x1},
 	[23] = { 0x000007b7, 0x0030, 0x1},
-	[24 ... 61] = ICELAKE_MOCS_PTE,
 	[62] = { 0x00000037, 0x0010, 0x1},
 	[63] = { 0x00000037, 0x0010, 0x1},
 };
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE
  2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
@ 2019-07-26 20:49   ` Daniele Ceraolo Spurio
  2019-07-26 20:57     ` Chris Wilson
  0 siblings, 1 reply; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-26 20:49 UTC (permalink / raw)
  To: Lucas De Marchi, igt-dev



On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> In the Ice Lake table we are setting all undefined entries to PTE.
> With Tiger Lake this won't be true anymore. Even if for test in IGT we
> add a new table for Tiger Lake, in kernel they can be shares since they
> are supposedly compatible (only unused entries were added or became
> unused).
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

And we shouldn't be guaranteeing that unused entries are set to 
something sensible as part of the ABI.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   tests/i915/gem_mocs_settings.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 7b1718f4..9f4e1b6d 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -101,7 +101,6 @@ static const struct mocs_entry icelake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
>   	[21] = { 0x00000137, 0x0030, 0x1},
>   	[22] = { 0x000003b7, 0x0030, 0x1},
>   	[23] = { 0x000007b7, 0x0030, 0x1},
> -	[24 ... 61] = ICELAKE_MOCS_PTE,
>   	[62] = { 0x00000037, 0x0010, 0x1},
>   	[63] = { 0x00000037, 0x0010, 0x1},
>   };
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE
  2019-07-26 20:49   ` Daniele Ceraolo Spurio
@ 2019-07-26 20:57     ` Chris Wilson
  0 siblings, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2019-07-26 20:57 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio, Lucas De Marchi, igt-dev

Quoting Daniele Ceraolo Spurio (2019-07-26 21:49:28)
> 
> 
> On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> > In the Ice Lake table we are setting all undefined entries to PTE.
> > With Tiger Lake this won't be true anymore. Even if for test in IGT we
> > add a new table for Tiger Lake, in kernel they can be shares since they
> > are supposedly compatible (only unused entries were added or became
> > unused).
> > 
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> 
> And we shouldn't be guaranteeing that unused entries are set to 
> something sensible as part of the ABI.

Better rephrased as undefined values are undefined.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
  2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
@ 2019-07-25 20:33 ` Lucas De Marchi
  2019-07-27  0:16   ` Daniele Ceraolo Spurio
  2019-07-25 20:33 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Lucas De Marchi
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 20:33 UTC (permalink / raw)
  To: igt-dev

Some small changes compared to Ice Lake, namely:

  - Removed entries 0 and 1: they are now reserved and shouldn't be used
  - Entries 16, 17, 48..61 were previously unused and are now available

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/i915/gem_mocs_settings.c | 38 ++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index 9f4e1b6d..e3da8515 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -78,6 +78,40 @@ struct mocs_table {
 };
 
 /* The first entries in the MOCS tables are defined by uABI */
+
+static const struct mocs_entry tigerlake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
+	[2]  = { 0x00000037, 0x0030, 0x1},
+	[3]  = { 0x00000005, 0x0010, 0x1},
+	[4]  = { 0x00000005, 0x0030, 0x1},
+	[5]  = { 0x00000037, 0x0010, 0x1},
+	[6]  = { 0x00000017, 0x0010, 0x1},
+	[7]  = { 0x00000017, 0x0030, 0x1},
+	[8]  = { 0x00000027, 0x0010, 0x1},
+	[9]  = { 0x00000027, 0x0030, 0x1},
+	[10] = { 0x00000077, 0x0010, 0x1},
+	[11] = { 0x00000077, 0x0030, 0x1},
+	[12] = { 0x00000057, 0x0010, 0x1},
+	[13] = { 0x00000057, 0x0030, 0x1},
+	[14] = { 0x00000067, 0x0010, 0x1},
+	[15] = { 0x00000067, 0x0030, 0x1},
+	[16] = { 0x00004005, 0x0010, 0x1},
+	[17] = { 0x00004005, 0x0030, 0x1},
+	[18] = { 0x00060037, 0x0030, 0x1},
+	[19] = { 0x00000737, 0x0030, 0x1},
+	[20] = { 0x00000337, 0x0030, 0x1},
+	[21] = { 0x00000137, 0x0030, 0x1},
+	[22] = { 0x000003b7, 0x0030, 0x1},
+	[23] = { 0x000007b7, 0x0030, 0x1},
+	[48] = { 0x00000037, 0x0030, 0x1},
+	[49] = { 0x00000005, 0x0030, 0x1},
+	[50] = { 0x00000037, 0x0010, 0x1},
+	[51] = { 0x00000005, 0x0010, 0x1},
+	[60] = { 0x00000037, 0x0010, 0x1},
+	[61] = { 0x00004005, 0x0030, 0x1},
+	[62] = { 0x00000037, 0x0010, 0x1},
+	[63] = { 0x00000037, 0x0010, 0x1},
+};
+
 static const struct mocs_entry icelake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
 	[0]  = { 0x00000005, 0x0010, 0x1},
 	[1]  = ICELAKE_MOCS_PTE,
@@ -158,6 +192,10 @@ static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
 		table->size  = ARRAY_SIZE(icelake_mocs_table);
 		table->table = icelake_mocs_table;
 		result = true;
+	} else if (IS_GEN(devid, 12)) {
+		table->size  = ARRAY_SIZE(tigerlake_mocs_table);
+		table->table = tigerlake_mocs_table;
+		result = true;
 	}
 
 	return result;
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake
  2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
@ 2019-07-27  0:16   ` Daniele Ceraolo Spurio
  0 siblings, 0 replies; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-27  0:16 UTC (permalink / raw)
  To: Lucas De Marchi, igt-dev



On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> Some small changes compared to Ice Lake, namely:
> 
>    - Removed entries 0 and 1: they are now reserved and shouldn't be used
>    - Entries 16, 17, 48..61 were previously unused and are now available
> 

Not related to this patch, but entries 16 and 17 are defined in the 
gen11 table because they're required on EHL, so we need to update the 
test to check those as well.

> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>   tests/i915/gem_mocs_settings.c | 38 ++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 9f4e1b6d..e3da8515 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -78,6 +78,40 @@ struct mocs_table {
>   };
>   
>   /* The first entries in the MOCS tables are defined by uABI */
> +
> +static const struct mocs_entry tigerlake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
> +	[2]  = { 0x00000037, 0x0030, 0x1},
> +	[3]  = { 0x00000005, 0x0010, 0x1},
> +	[4]  = { 0x00000005, 0x0030, 0x1},
> +	[5]  = { 0x00000037, 0x0010, 0x1},
> +	[6]  = { 0x00000017, 0x0010, 0x1},
> +	[7]  = { 0x00000017, 0x0030, 0x1},
> +	[8]  = { 0x00000027, 0x0010, 0x1},
> +	[9]  = { 0x00000027, 0x0030, 0x1},
> +	[10] = { 0x00000077, 0x0010, 0x1},
> +	[11] = { 0x00000077, 0x0030, 0x1},
> +	[12] = { 0x00000057, 0x0010, 0x1},
> +	[13] = { 0x00000057, 0x0030, 0x1},
> +	[14] = { 0x00000067, 0x0010, 0x1},
> +	[15] = { 0x00000067, 0x0030, 0x1},
> +	[16] = { 0x00004005, 0x0010, 0x1},
> +	[17] = { 0x00004005, 0x0030, 0x1},
> +	[18] = { 0x00060037, 0x0030, 0x1},
> +	[19] = { 0x00000737, 0x0030, 0x1},
> +	[20] = { 0x00000337, 0x0030, 0x1},
> +	[21] = { 0x00000137, 0x0030, 0x1},
> +	[22] = { 0x000003b7, 0x0030, 0x1},
> +	[23] = { 0x000007b7, 0x0030, 0x1},
> +	[48] = { 0x00000037, 0x0030, 0x1},
> +	[49] = { 0x00000005, 0x0030, 0x1},
> +	[50] = { 0x00000037, 0x0010, 0x1},
> +	[51] = { 0x00000005, 0x0010, 0x1},
> +	[60] = { 0x00000037, 0x0010, 0x1},
> +	[61] = { 0x00004005, 0x0030, 0x1},
> +	[62] = { 0x00000037, 0x0010, 0x1},
> +	[63] = { 0x00000037, 0x0010, 0x1},
> +};
> +

Matches the specs.

>   static const struct mocs_entry icelake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
>   	[0]  = { 0x00000005, 0x0010, 0x1},
>   	[1]  = ICELAKE_MOCS_PTE,
> @@ -158,6 +192,10 @@ static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
>   		table->size  = ARRAY_SIZE(icelake_mocs_table);
>   		table->table = icelake_mocs_table;
>   		result = true;
> +	} else if (IS_GEN(devid, 12)) {

This should be IS_TIGERLAKE for consistency, since all the other lists 
are assigned with checks per-platform rather than per-gen. With that:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> +		table->size  = ARRAY_SIZE(tigerlake_mocs_table);
> +		table->table = tigerlake_mocs_table;
> +		result = true;
>   	}
>   
>   	return result;
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
  2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
  2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
@ 2019-07-25 20:33 ` Lucas De Marchi
  2019-07-29 20:53   ` Kumar Valsan, Prathap
  2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 20:33 UTC (permalink / raw)
  To: igt-dev

Gen 11 still has the per-context MOCS table. It's gen 12 and later that
only has a global MOCS table available so it doesn't make sense to test
dirtying it per context.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/i915/gem_mocs_settings.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index e3da8515..9ec0b122 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -483,12 +483,13 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
 	uint32_t ctx_clean_id;
 	uint32_t ctx_dirty_id;
 
-	/* As mocs is global for GEN11+, trying privileged write to dirty
+	/*
+	 * As mocs is global for GEN12+, trying privileged write to dirty
 	 * the mocs and testing context save and restore of mocs between
 	 * contexts is bound to fail.
 	 */
 	if (flags & MOCS_DIRTY_VALUES)
-		igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 11);
+		igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 12);
 
 	gem_require_ring(fd, engine);
 
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11
  2019-07-25 20:33 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Lucas De Marchi
@ 2019-07-29 20:53   ` Kumar Valsan, Prathap
  0 siblings, 0 replies; 19+ messages in thread
From: Kumar Valsan, Prathap @ 2019-07-29 20:53 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev

On Thu, Jul 25, 2019 at 01:33:53PM -0700, Lucas De Marchi wrote:
> Gen 11 still has the per-context MOCS table. It's gen 12 and later that
> only has a global MOCS table available so it doesn't make sense to test
> dirtying it per context.
MOCS is global GEN11HP onwards. For GEN11 LP, LLC MOCS are private to
context, however L3 MOCS will not be saved and restored per context.

Better to consider Gen11 MOCS as global and skip the dirty
test.

Thanks,
Prathap
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  tests/i915/gem_mocs_settings.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index e3da8515..9ec0b122 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -483,12 +483,13 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
>  	uint32_t ctx_clean_id;
>  	uint32_t ctx_dirty_id;
>  
> -	/* As mocs is global for GEN11+, trying privileged write to dirty
> +	/*
> +	 * As mocs is global for GEN12+, trying privileged write to dirty
>  	 * the mocs and testing context save and restore of mocs between
>  	 * contexts is bound to fail.
>  	 */
>  	if (flags & MOCS_DIRTY_VALUES)
> -		igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 11);
> +		igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 12);
>  
>  	gem_require_ring(fd, engine);
>  
> -- 
> 2.21.0
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
                   ` (2 preceding siblings ...)
  2019-07-25 20:33 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Lucas De Marchi
@ 2019-07-25 20:33 ` Lucas De Marchi
  2019-07-27  0:23   ` Daniele Ceraolo Spurio
  2019-07-25 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index Patchwork
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 20:33 UTC (permalink / raw)
  To: igt-dev

Gen 12 and later only have global MOCS: use the new offset.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/i915/gem_mocs_settings.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index 9ec0b122..3a593219 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -63,6 +63,7 @@ static const char * const test_modes[] = {
 #define GEN9_MFX1_MOCS_0	(0xcA00)	/* Media 1 MOCS base register*/
 #define GEN9_VEBOX_MOCS_0	(0xcB00)	/* Video MOCS base register*/
 #define GEN9_BLT_MOCS_0		(0xcc00)	/* Blitter MOCS base register*/
+#define GEN12_GLOBAL_MOCS	(0x4000)
 #define ICELAKE_MOCS_PTE	{0x00000004, 0x0030, 0x1}
 #define MOCS_PTE		{0x00000038, 0x0030, 0x1}
 
@@ -165,6 +166,11 @@ static const uint32_t write_values[GEN9_NUM_MOCS_ENTRIES] = {
 	[0 ... GEN9_NUM_MOCS_ENTRIES - 1] = 0xFFFFFFFF,
 };
 
+static bool has_global_mocs(int fd)
+{
+	return intel_gen(intel_get_drm_devid(fd)) >= 12;
+}
+
 static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
 {
 	uint32_t devid = intel_get_drm_devid(fd);
@@ -204,8 +210,11 @@ static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
 #define LOCAL_I915_EXEC_BSD1 (I915_EXEC_BSD | (1<<13))
 #define LOCAL_I915_EXEC_BSD2 (I915_EXEC_BSD | (2<<13))
 
-static uint32_t get_engine_base(uint32_t engine)
+static uint32_t get_engine_base(int fd, uint32_t engine)
 {
+	if (has_global_mocs(fd))
+		return GEN12_GLOBAL_MOCS;
+
 	switch (engine) {
 	case LOCAL_I915_EXEC_BSD1:	return GEN9_MFX0_MOCS_0;
 	case LOCAL_I915_EXEC_BSD2:	return GEN9_MFX1_MOCS_0;
@@ -339,7 +348,7 @@ static void check_control_registers(int fd,
 				    uint32_t ctx_id,
 				    bool dirty)
 {
-	const uint32_t reg_base = get_engine_base(engine);
+	const uint32_t reg_base = get_engine_base(fd, engine);
 	uint32_t dst_handle = gem_create(fd, 4096);
 	uint32_t *read_regs;
 	struct mocs_table table;
@@ -467,7 +476,7 @@ static void write_dirty_mocs(int fd,
 	else
 		num_of_mocs_entries = GEN9_NUM_MOCS_ENTRIES;
 
-	write_registers(fd, ctx_id, get_engine_base(engine),
+	write_registers(fd, ctx_id, get_engine_base(fd, engine),
 			write_values, num_of_mocs_entries,
 			engine, privileged);
 
@@ -494,7 +503,7 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
 	gem_require_ring(fd, engine);
 
 	/* Skip if we don't know where the registers are for this engine */
-	igt_require(get_engine_base(engine));
+	igt_require(get_engine_base(fd, engine));
 
 	if (flags & MOCS_NON_DEFAULT_CTX)
 		ctx_id = gem_context_create(fd);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake
  2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
@ 2019-07-27  0:23   ` Daniele Ceraolo Spurio
  0 siblings, 0 replies; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-27  0:23 UTC (permalink / raw)
  To: Lucas De Marchi, igt-dev



On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> Gen 12 and later only have global MOCS: use the new offset.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   tests/i915/gem_mocs_settings.c | 17 +++++++++++++----
>   1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 9ec0b122..3a593219 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -63,6 +63,7 @@ static const char * const test_modes[] = {
>   #define GEN9_MFX1_MOCS_0	(0xcA00)	/* Media 1 MOCS base register*/
>   #define GEN9_VEBOX_MOCS_0	(0xcB00)	/* Video MOCS base register*/
>   #define GEN9_BLT_MOCS_0		(0xcc00)	/* Blitter MOCS base register*/
> +#define GEN12_GLOBAL_MOCS	(0x4000)
>   #define ICELAKE_MOCS_PTE	{0x00000004, 0x0030, 0x1}
>   #define MOCS_PTE		{0x00000038, 0x0030, 0x1}
>   
> @@ -165,6 +166,11 @@ static const uint32_t write_values[GEN9_NUM_MOCS_ENTRIES] = {
>   	[0 ... GEN9_NUM_MOCS_ENTRIES - 1] = 0xFFFFFFFF,
>   };
>   
> +static bool has_global_mocs(int fd)
> +{
> +	return intel_gen(intel_get_drm_devid(fd)) >= 12;
> +}
> +
>   static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
>   {
>   	uint32_t devid = intel_get_drm_devid(fd);
> @@ -204,8 +210,11 @@ static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
>   #define LOCAL_I915_EXEC_BSD1 (I915_EXEC_BSD | (1<<13))
>   #define LOCAL_I915_EXEC_BSD2 (I915_EXEC_BSD | (2<<13))
>   
> -static uint32_t get_engine_base(uint32_t engine)
> +static uint32_t get_engine_base(int fd, uint32_t engine)
>   {
> +	if (has_global_mocs(fd))
> +		return GEN12_GLOBAL_MOCS;
> +
>   	switch (engine) {
>   	case LOCAL_I915_EXEC_BSD1:	return GEN9_MFX0_MOCS_0;
>   	case LOCAL_I915_EXEC_BSD2:	return GEN9_MFX1_MOCS_0;
> @@ -339,7 +348,7 @@ static void check_control_registers(int fd,
>   				    uint32_t ctx_id,
>   				    bool dirty)
>   {
> -	const uint32_t reg_base = get_engine_base(engine);
> +	const uint32_t reg_base = get_engine_base(fd, engine);
>   	uint32_t dst_handle = gem_create(fd, 4096);
>   	uint32_t *read_regs;
>   	struct mocs_table table;
> @@ -467,7 +476,7 @@ static void write_dirty_mocs(int fd,
>   	else
>   		num_of_mocs_entries = GEN9_NUM_MOCS_ENTRIES;
>   
> -	write_registers(fd, ctx_id, get_engine_base(engine),
> +	write_registers(fd, ctx_id, get_engine_base(fd, engine),
>   			write_values, num_of_mocs_entries,
>   			engine, privileged);
>   
> @@ -494,7 +503,7 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
>   	gem_require_ring(fd, engine);
>   
>   	/* Skip if we don't know where the registers are for this engine */
> -	igt_require(get_engine_base(engine));
> +	igt_require(get_engine_base(fd, engine));
>   
>   	if (flags & MOCS_NON_DEFAULT_CTX)
>   		ctx_id = gem_context_create(fd);
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
                   ` (3 preceding siblings ...)
  2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
@ 2019-07-25 21:12 ` Patchwork
  2019-07-25 21:45 ` [igt-dev] [PATCH 1/5] " Lucas De Marchi
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-07-25 21:12 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev

== Series Details ==

Series: series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
URL   : https://patchwork.freedesktop.org/series/64263/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6553 -> IGTPW_3297
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3297 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-icl-u3/igt@gem_exec_suspend@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-icl-u3/igt@gem_exec_suspend@basic.html

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       [PASS][3] -> [SKIP][4] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html

  * igt@kms_busy@basic-flip-c:
    - fi-kbl-7500u:       [PASS][5] -> [SKIP][6] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html

  
#### Possible fixes ####

  * igt@gem_exec_reloc@basic-gtt:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html

  * igt@i915_selftest@live_contexts:
    - fi-icl-dsi:         [DMESG-WARN][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-icl-dsi/igt@i915_selftest@live_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-icl-dsi/igt@i915_selftest@live_contexts.html

  * igt@i915_selftest@live_hangcheck:
    - fi-kbl-guc:         [INCOMPLETE][11] ([fdo#108744]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html

  
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (55 -> 46)
------------------------------

  Missing    (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5112 -> IGTPW_3297

  CI-20190529: 20190529
  CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
  IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
                   ` (4 preceding siblings ...)
  2019-07-25 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index Patchwork
@ 2019-07-25 21:45 ` Lucas De Marchi
  2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
  2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
  7 siblings, 0 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-25 21:45 UTC (permalink / raw)
  To: igt-dev

I forgot to say: for this series the correspondent TGL changes should be
in the next version of https://patchwork.freedesktop.org/series/63670/

Lucas De Marchi

On Thu, Jul 25, 2019 at 01:33:50PM -0700, Lucas De Marchi wrote:
>This helps to identify which entry is wrong in the table.
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>---
> tests/i915/gem_mocs_settings.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
>index 1a311b8c..7b1718f4 100644
>--- a/tests/i915/gem_mocs_settings.c
>+++ b/tests/i915/gem_mocs_settings.c
>@@ -322,8 +322,10 @@ static void check_control_registers(int fd,
> 	for (int index = 0; index < table.size; index++) {
> 		if (!table.table[index].used)
> 			continue;
>-		igt_assert_eq_u32(read_regs[index],
>-				  table.table[index].control_value);
>+
>+		igt_assert_f(
>+			read_regs[index] == table.table[index].control_value,
>+			"engine=%u index=%u", engine, index);
> 	}
>
> 	munmap(read_regs, 4096);
>-- 
>2.21.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
                   ` (5 preceding siblings ...)
  2019-07-25 21:45 ` [igt-dev] [PATCH 1/5] " Lucas De Marchi
@ 2019-07-26 12:39 ` Patchwork
  2019-07-26 23:26   ` Daniele Ceraolo Spurio
  2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
  7 siblings, 1 reply; 19+ messages in thread
From: Patchwork @ 2019-07-26 12:39 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev

== Series Details ==

Series: series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
URL   : https://patchwork.freedesktop.org/series/64263/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6553_full -> IGTPW_3297_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_3297_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3297_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3297_full:

### IGT changes ###

#### Warnings ####

  * igt@gem_mocs_settings@mocs-settings-dirty-render:
    - shard-iclb:         [SKIP][1] ([fdo#110206]) -> [FAIL][2] +5 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb6/igt@gem_mocs_settings@mocs-settings-dirty-render.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_mocs_settings@mocs-settings-dirty-render.html

  
Known issues
------------

  Here are the changes found in IGTPW_3297_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_exec_balancer@smoke.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
    - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          [PASS][13] -> [FAIL][14] ([fdo#105767])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html

  * igt@kms_flip@2x-flip-vs-expired-vblank:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html

  * igt@kms_flip_tiling@flip-to-y-tiled:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#107931] / [fdo#108134])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb8/igt@kms_flip_tiling@flip-to-y-tiled.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb1/igt@kms_flip_tiling@flip-to-y-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
    - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#103167])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
    - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#103167])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +7 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
    - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#103167])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103665])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html

  * igt@kms_vblank@pipe-a-query-forked-busy-hang:
    - shard-kbl:          [PASS][33] -> [DMESG-WARN][34] ([fdo#103558] / [fdo#105602]) +3 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html

  
#### Possible fixes ####

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [SKIP][35] ([fdo#109271]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +3 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@i915_suspend@sysfs-reader.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@i915_suspend@sysfs-reader.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [FAIL][39] ([fdo#103167]) -> [PASS][40] +6 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

  
#### Warnings ####

  * igt@gem_eio@in-flight-suspend:
    - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> [INCOMPLETE][44] ([fdo#103665])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@gem_eio@in-flight-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl6/igt@gem_eio@in-flight-suspend.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][45] ([fdo#109349]) -> [DMESG-WARN][46] ([fdo#107724])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
    - shard-kbl:          [SKIP][47] ([fdo#109271]) -> [SKIP][48] ([fdo#105602] / [fdo#109271]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
  [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854


Participating hosts (9 -> 6)
------------------------------

  Missing    (3): pig-skl-6260u shard-skl pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5112 -> IGTPW_3297
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
  IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
@ 2019-07-26 23:26   ` Daniele Ceraolo Spurio
  2019-07-26 23:49     ` Lucas De Marchi
  0 siblings, 1 reply; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-26 23:26 UTC (permalink / raw)
  To: igt-dev, Patchwork, Lucas De Marchi



On 7/26/19 5:39 AM, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
> URL   : https://patchwork.freedesktop.org/series/64263/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6553_full -> IGTPW_3297_full
> ====================================================
> 
> Summary
> -------
> 
>    **WARNING**
> 
>    Minor unknown changes coming with IGTPW_3297_full need to be verified
>    manually.
>    
>    If you think the reported changes have nothing to do with the changes
>    introduced in IGTPW_3297_full, please notify your bug team to allow them
>    to document this new failure mode, which will reduce false positives in CI.
> 
>    External URL: https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/
> 
> Possible new issues
> -------------------
> 
>    Here are the unknown changes that may have been introduced in IGTPW_3297_full:
> 
> ### IGT changes ###
> 
> #### Warnings ####
> 
>    * igt@gem_mocs_settings@mocs-settings-dirty-render:
>      - shard-iclb:         [SKIP][1] ([fdo#110206]) -> [FAIL][2] +5 similar issues

Looks like the filter matched this with the wrong fdo, the test is 
actually failing on ICL (after being re-enabled) and not skipping like 
in the fdo.

Daniele

>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb6/igt@gem_mocs_settings@mocs-settings-dirty-render.html
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_mocs_settings@mocs-settings-dirty-render.html
> 
>    
> Known issues
> ------------
> 
>    Here are the changes found in IGTPW_3297_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>    * igt@gem_ctx_isolation@bcs0-s3:
>      - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html
> 
>    * igt@gem_exec_balancer@smoke:
>      - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@gem_exec_balancer@smoke.html
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_exec_balancer@smoke.html
> 
>    * igt@gem_workarounds@suspend-resume-fd:
>      - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +2 similar issues
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
> 
>    * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
>      - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>      - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
> 
>    * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>      - shard-hsw:          [PASS][13] -> [FAIL][14] ([fdo#105767])
>     [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>     [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> 
>    * igt@kms_flip@2x-flip-vs-expired-vblank:
>      - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
>     [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
>     [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
> 
>    * igt@kms_flip_tiling@flip-to-y-tiled:
>      - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#107931] / [fdo#108134])
>     [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb8/igt@kms_flip_tiling@flip-to-y-tiled.html
>     [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb1/igt@kms_flip_tiling@flip-to-y-tiled.html
> 
>    * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>      - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#103167])
>     [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>     [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>      - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#103167])
>     [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>     [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
> 
>    * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
>      - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +7 similar issues
>     [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
>     [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
> 
>    * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
>      - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#103167])
>     [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
>     [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
> 
>    * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>      - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103665])
>     [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>     [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> 
>    * igt@kms_plane_lowres@pipe-a-tiling-y:
>      - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
>     [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
>     [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
> 
>    * igt@kms_psr@psr2_cursor_plane_onoff:
>      - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +3 similar issues
>     [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
>     [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
> 
>    * igt@kms_vblank@pipe-a-query-forked-busy-hang:
>      - shard-kbl:          [PASS][33] -> [DMESG-WARN][34] ([fdo#103558] / [fdo#105602]) +3 similar issues
>     [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
>     [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
> 
>    
> #### Possible fixes ####
> 
>    * igt@i915_pm_rc6_residency@rc6-accuracy:
>      - shard-kbl:          [SKIP][35] ([fdo#109271]) -> [PASS][36]
>     [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
>     [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html
> 
>    * igt@i915_suspend@sysfs-reader:
>      - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +3 similar issues
>     [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@i915_suspend@sysfs-reader.html
>     [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@i915_suspend@sysfs-reader.html
> 
>    * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>      - shard-iclb:         [FAIL][39] ([fdo#103167]) -> [PASS][40] +6 similar issues
>     [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>     [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> 
>    * igt@kms_psr@psr2_no_drrs:
>      - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 similar issues
>     [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
>     [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
> 
>    
> #### Warnings ####
> 
>    * igt@gem_eio@in-flight-suspend:
>      - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> [INCOMPLETE][44] ([fdo#103665])
>     [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@gem_eio@in-flight-suspend.html
>     [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl6/igt@gem_eio@in-flight-suspend.html
> 
>    * igt@kms_dp_dsc@basic-dsc-enable-edp:
>      - shard-iclb:         [SKIP][45] ([fdo#109349]) -> [DMESG-WARN][46] ([fdo#107724])
>     [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>     [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
> 
>    * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
>      - shard-kbl:          [SKIP][47] ([fdo#109271]) -> [SKIP][48] ([fdo#105602] / [fdo#109271]) +1 similar issue
>     [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
>     [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
> 
>    
>    [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>    [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>    [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>    [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>    [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>    [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>    [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>    [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>    [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>    [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
>    [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
>    [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>    [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>    [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>    [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>    [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
>    [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
> 
> 
> Participating hosts (9 -> 6)
> ------------------------------
> 
>    Missing    (3): pig-skl-6260u shard-skl pig-glk-j5005
> 
> 
> Build changes
> -------------
> 
>    * CI: CI-20190529 -> None
>    * IGT: IGT_5112 -> IGTPW_3297
>    * Piglit: piglit_4509 -> None
> 
>    CI-20190529: 20190529
>    CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>    IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-26 23:26   ` Daniele Ceraolo Spurio
@ 2019-07-26 23:49     ` Lucas De Marchi
  2019-07-26 23:54       ` Daniele Ceraolo Spurio
  0 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-26 23:49 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio; +Cc: igt-dev

On Fri, Jul 26, 2019 at 04:26:00PM -0700, Daniele Ceraolo Spurio wrote:
>
>
>On 7/26/19 5:39 AM, Patchwork wrote:
>>== Series Details ==
>>
>>Series: series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
>>URL   : https://patchwork.freedesktop.org/series/64263/
>>State : success
>>
>>== Summary ==
>>
>>CI Bug Log - changes from CI_DRM_6553_full -> IGTPW_3297_full
>>====================================================
>>
>>Summary
>>-------
>>
>>   **WARNING**
>>
>>   Minor unknown changes coming with IGTPW_3297_full need to be verified
>>   manually.
>>   If you think the reported changes have nothing to do with the changes
>>   introduced in IGTPW_3297_full, please notify your bug team to allow them
>>   to document this new failure mode, which will reduce false positives in CI.
>>
>>   External URL: https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/
>>
>>Possible new issues
>>-------------------
>>
>>   Here are the unknown changes that may have been introduced in IGTPW_3297_full:
>>
>>### IGT changes ###
>>
>>#### Warnings ####
>>
>>   * igt@gem_mocs_settings@mocs-settings-dirty-render:
>>     - shard-iclb:         [SKIP][1] ([fdo#110206]) -> [FAIL][2] +5 similar issues
>
>Looks like the filter matched this with the wrong fdo, the test is 
>actually failing on ICL (after being re-enabled) and not skipping like 
>in the fdo.

humn... probably the change to consider global as gen 12+.

Lucas De Marchi

>
>Daniele
>
>>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb6/igt@gem_mocs_settings@mocs-settings-dirty-render.html
>>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_mocs_settings@mocs-settings-dirty-render.html
>>
>>Known issues
>>------------
>>
>>   Here are the changes found in IGTPW_3297_full that come from known issues:
>>
>>### IGT changes ###
>>
>>#### Issues hit ####
>>
>>   * igt@gem_ctx_isolation@bcs0-s3:
>>     - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
>>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
>>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html
>>
>>   * igt@gem_exec_balancer@smoke:
>>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
>>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@gem_exec_balancer@smoke.html
>>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_exec_balancer@smoke.html
>>
>>   * igt@gem_workarounds@suspend-resume-fd:
>>     - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +2 similar issues
>>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
>>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
>>
>>   * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
>>     - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
>>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>     - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
>>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>
>>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>>     - shard-hsw:          [PASS][13] -> [FAIL][14] ([fdo#105767])
>>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>>
>>   * igt@kms_flip@2x-flip-vs-expired-vblank:
>>     - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
>>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
>>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
>>
>>   * igt@kms_flip_tiling@flip-to-y-tiled:
>>     - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#107931] / [fdo#108134])
>>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb8/igt@kms_flip_tiling@flip-to-y-tiled.html
>>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb1/igt@kms_flip_tiling@flip-to-y-tiled.html
>>
>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>>     - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#103167])
>>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>     - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#103167])
>>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>
>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
>>     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +7 similar issues
>>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
>>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
>>
>>   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
>>     - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#103167])
>>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
>>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
>>
>>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>>     - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103665])
>>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>>
>>   * igt@kms_plane_lowres@pipe-a-tiling-y:
>>     - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
>>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
>>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
>>
>>   * igt@kms_psr@psr2_cursor_plane_onoff:
>>     - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +3 similar issues
>>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
>>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
>>
>>   * igt@kms_vblank@pipe-a-query-forked-busy-hang:
>>     - shard-kbl:          [PASS][33] -> [DMESG-WARN][34] ([fdo#103558] / [fdo#105602]) +3 similar issues
>>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
>>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
>>
>>#### Possible fixes ####
>>
>>   * igt@i915_pm_rc6_residency@rc6-accuracy:
>>     - shard-kbl:          [SKIP][35] ([fdo#109271]) -> [PASS][36]
>>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
>>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html
>>
>>   * igt@i915_suspend@sysfs-reader:
>>     - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +3 similar issues
>>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@i915_suspend@sysfs-reader.html
>>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@i915_suspend@sysfs-reader.html
>>
>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>>     - shard-iclb:         [FAIL][39] ([fdo#103167]) -> [PASS][40] +6 similar issues
>>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>>
>>   * igt@kms_psr@psr2_no_drrs:
>>     - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 similar issues
>>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
>>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
>>
>>#### Warnings ####
>>
>>   * igt@gem_eio@in-flight-suspend:
>>     - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> [INCOMPLETE][44] ([fdo#103665])
>>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@gem_eio@in-flight-suspend.html
>>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl6/igt@gem_eio@in-flight-suspend.html
>>
>>   * igt@kms_dp_dsc@basic-dsc-enable-edp:
>>     - shard-iclb:         [SKIP][45] ([fdo#109349]) -> [DMESG-WARN][46] ([fdo#107724])
>>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>>
>>   * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
>>     - shard-kbl:          [SKIP][47] ([fdo#109271]) -> [SKIP][48] ([fdo#105602] / [fdo#109271]) +1 similar issue
>>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
>>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
>>
>>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>>   [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>>   [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>>   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>>   [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
>>   [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
>>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>>   [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>>   [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
>>   [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>>
>>
>>Participating hosts (9 -> 6)
>>------------------------------
>>
>>   Missing    (3): pig-skl-6260u shard-skl pig-glk-j5005
>>
>>
>>Build changes
>>-------------
>>
>>   * CI: CI-20190529 -> None
>>   * IGT: IGT_5112 -> IGTPW_3297
>>   * Piglit: piglit_4509 -> None
>>
>>   CI-20190529: 20190529
>>   CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ git://anongit.freedesktop.org/gfx-ci/linux
>>   IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>   IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>>
>>== Logs ==
>>
>>For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>_______________________________________________
>>igt-dev mailing list
>>igt-dev@lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/igt-dev
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-26 23:49     ` Lucas De Marchi
@ 2019-07-26 23:54       ` Daniele Ceraolo Spurio
  2019-07-27  0:04         ` Lucas De Marchi
  0 siblings, 1 reply; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-26 23:54 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev



On 7/26/19 4:49 PM, Lucas De Marchi wrote:
> On Fri, Jul 26, 2019 at 04:26:00PM -0700, Daniele Ceraolo Spurio wrote:
>>
>>
>> On 7/26/19 5:39 AM, Patchwork wrote:
>>> == Series Details ==
>>>
>>> Series: series starting with [1/5] i915/gem_mocs_settings: log the 
>>> engine and MOCS index
>>> URL   : https://patchwork.freedesktop.org/series/64263/
>>> State : success
>>>
>>> == Summary ==
>>>
>>> CI Bug Log - changes from CI_DRM_6553_full -> IGTPW_3297_full
>>> ====================================================
>>>
>>> Summary
>>> -------
>>>
>>>   **WARNING**
>>>
>>>   Minor unknown changes coming with IGTPW_3297_full need to be verified
>>>   manually.
>>>   If you think the reported changes have nothing to do with the changes
>>>   introduced in IGTPW_3297_full, please notify your bug team to allow 
>>> them
>>>   to document this new failure mode, which will reduce false 
>>> positives in CI.
>>>
>>>   External URL: 
>>> https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/
>>>
>>> Possible new issues
>>> -------------------
>>>
>>>   Here are the unknown changes that may have been introduced in 
>>> IGTPW_3297_full:
>>>
>>> ### IGT changes ###
>>>
>>> #### Warnings ####
>>>
>>>   * igt@gem_mocs_settings@mocs-settings-dirty-render:
>>>     - shard-iclb:         [SKIP][1] ([fdo#110206]) -> [FAIL][2] +5 
>>> similar issues
>>
>> Looks like the filter matched this with the wrong fdo, the test is 
>> actually failing on ICL (after being re-enabled) and not skipping like 
>> in the fdo.
> 
> humn... probably the change to consider global as gen 12+.
> 

Yup, the test seems to be using a global gen9 list in write_dirty_mocs() 
and then checking it against the return of get_mocs_settings(dirty = 
true). To make it work we need to add a dirty list for gen11 to be 
returned by get_mocs_settings() and use it in both places. I'd suggest 
splitting that task off since it isn't really part of TGL enabling.

Daniele

> Lucas De Marchi
> 
>>
>> Daniele
>>
>>>    [1]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb6/igt@gem_mocs_settings@mocs-settings-dirty-render.html 
>>>
>>>    [2]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_mocs_settings@mocs-settings-dirty-render.html 
>>>
>>>
>>> Known issues
>>> ------------
>>>
>>>   Here are the changes found in IGTPW_3297_full that come from known 
>>> issues:
>>>
>>> ### IGT changes ###
>>>
>>> #### Issues hit ####
>>>
>>>   * igt@gem_ctx_isolation@bcs0-s3:
>>>     - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) 
>>> +2 similar issues
>>>    [3]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html 
>>>
>>>    [4]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html 
>>>
>>>
>>>   * igt@gem_exec_balancer@smoke:
>>>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
>>>    [5]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@gem_exec_balancer@smoke.html 
>>>
>>>    [6]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_exec_balancer@smoke.html 
>>>
>>>
>>>   * igt@gem_workarounds@suspend-resume-fd:
>>>     - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) 
>>> +2 similar issues
>>>    [7]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html 
>>>
>>>    [8]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html 
>>>
>>>
>>>   * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
>>>     - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
>>>    [9]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html 
>>>
>>>    [10]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html 
>>>
>>>     - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
>>>    [11]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html 
>>>
>>>    [12]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html 
>>>
>>>
>>>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>>>     - shard-hsw:          [PASS][13] -> [FAIL][14] ([fdo#105767])
>>>    [13]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html 
>>>
>>>    [14]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html 
>>>
>>>
>>>   * igt@kms_flip@2x-flip-vs-expired-vblank:
>>>     - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
>>>    [15]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html 
>>>
>>>    [16]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html 
>>>
>>>
>>>   * igt@kms_flip_tiling@flip-to-y-tiled:
>>>     - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#107931] / 
>>> [fdo#108134])
>>>    [17]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb8/igt@kms_flip_tiling@flip-to-y-tiled.html 
>>>
>>>    [18]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb1/igt@kms_flip_tiling@flip-to-y-tiled.html 
>>>
>>>
>>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>>>     - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#103167])
>>>    [19]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html 
>>>
>>>    [20]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html 
>>>
>>>     - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#103167])
>>>    [21]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html 
>>>
>>>    [22]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html 
>>>
>>>
>>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
>>>     - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +7 
>>> similar issues
>>>    [23]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html 
>>>
>>>    [24]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html 
>>>
>>>
>>>   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
>>>     - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#103167])
>>>    [25]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html 
>>>
>>>    [26]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html 
>>>
>>>
>>>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>>>     - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103665])
>>>    [27]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html 
>>>
>>>    [28]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html 
>>>
>>>
>>>   * igt@kms_plane_lowres@pipe-a-tiling-y:
>>>     - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
>>>    [29]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html 
>>>
>>>    [30]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html 
>>>
>>>
>>>   * igt@kms_psr@psr2_cursor_plane_onoff:
>>>     - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +3 
>>> similar issues
>>>    [31]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html 
>>>
>>>    [32]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html 
>>>
>>>
>>>   * igt@kms_vblank@pipe-a-query-forked-busy-hang:
>>>     - shard-kbl:          [PASS][33] -> [DMESG-WARN][34] 
>>> ([fdo#103558] / [fdo#105602]) +3 similar issues
>>>    [33]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html 
>>>
>>>    [34]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html 
>>>
>>>
>>> #### Possible fixes ####
>>>
>>>   * igt@i915_pm_rc6_residency@rc6-accuracy:
>>>     - shard-kbl:          [SKIP][35] ([fdo#109271]) -> [PASS][36]
>>>    [35]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html 
>>>
>>>    [36]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html 
>>>
>>>
>>>   * igt@i915_suspend@sysfs-reader:
>>>     - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> 
>>> [PASS][38] +3 similar issues
>>>    [37]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@i915_suspend@sysfs-reader.html 
>>>
>>>    [38]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@i915_suspend@sysfs-reader.html 
>>>
>>>
>>>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>>>     - shard-iclb:         [FAIL][39] ([fdo#103167]) -> [PASS][40] +6 
>>> similar issues
>>>    [39]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html 
>>>
>>>    [40]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html 
>>>
>>>
>>>   * igt@kms_psr@psr2_no_drrs:
>>>     - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 
>>> similar issues
>>>    [41]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb1/igt@kms_psr@psr2_no_drrs.html 
>>>
>>>    [42]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_psr@psr2_no_drrs.html 
>>>
>>>
>>> #### Warnings ####
>>>
>>>   * igt@gem_eio@in-flight-suspend:
>>>     - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> 
>>> [INCOMPLETE][44] ([fdo#103665])
>>>    [43]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@gem_eio@in-flight-suspend.html 
>>>
>>>    [44]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl6/igt@gem_eio@in-flight-suspend.html 
>>>
>>>
>>>   * igt@kms_dp_dsc@basic-dsc-enable-edp:
>>>     - shard-iclb:         [SKIP][45] ([fdo#109349]) -> 
>>> [DMESG-WARN][46] ([fdo#107724])
>>>    [45]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html 
>>>
>>>    [46]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html 
>>>
>>>
>>>   * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
>>>     - shard-kbl:          [SKIP][47] ([fdo#109271]) -> [SKIP][48] 
>>> ([fdo#105602] / [fdo#109271]) +1 similar issue
>>>    [47]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html 
>>>
>>>    [48]: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html 
>>>
>>>
>>>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>>>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>>>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>>>   [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>>>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>>>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>>>   [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>>>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>>>   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>>>   [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
>>>   [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
>>>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>>>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>>>   [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>>>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>>>   [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
>>>   [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>>>
>>>
>>> Participating hosts (9 -> 6)
>>> ------------------------------
>>>
>>>   Missing    (3): pig-skl-6260u shard-skl pig-glk-j5005
>>>
>>>
>>> Build changes
>>> -------------
>>>
>>>   * CI: CI-20190529 -> None
>>>   * IGT: IGT_5112 -> IGTPW_3297
>>>   * Piglit: piglit_4509 -> None
>>>
>>>   CI-20190529: 20190529
>>>   CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ 
>>> git://anongit.freedesktop.org/gfx-ci/linux
>>>   IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>>   IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ 
>>> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>>>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ 
>>> git://anongit.freedesktop.org/piglit
>>>
>>> == Logs ==
>>>
>>> For more details see: 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>> _______________________________________________
>>> igt-dev mailing list
>>> igt-dev@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-26 23:54       ` Daniele Ceraolo Spurio
@ 2019-07-27  0:04         ` Lucas De Marchi
  0 siblings, 0 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-27  0:04 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio; +Cc: igt-dev

On Fri, Jul 26, 2019 at 04:54:20PM -0700, Daniele Ceraolo Spurio wrote:
>
>
>On 7/26/19 4:49 PM, Lucas De Marchi wrote:
>>On Fri, Jul 26, 2019 at 04:26:00PM -0700, Daniele Ceraolo Spurio wrote:
>>>
>>>
>>>On 7/26/19 5:39 AM, Patchwork wrote:
>>>>== Series Details ==
>>>>
>>>>Series: series starting with [1/5] i915/gem_mocs_settings: log 
>>>>the engine and MOCS index
>>>>URL   : https://patchwork.freedesktop.org/series/64263/
>>>>State : success
>>>>
>>>>== Summary ==
>>>>
>>>>CI Bug Log - changes from CI_DRM_6553_full -> IGTPW_3297_full
>>>>====================================================
>>>>
>>>>Summary
>>>>-------
>>>>
>>>>  **WARNING**
>>>>
>>>>  Minor unknown changes coming with IGTPW_3297_full need to be verified
>>>>  manually.
>>>>  If you think the reported changes have nothing to do with the changes
>>>>  introduced in IGTPW_3297_full, please notify your bug team to 
>>>>allow them
>>>>  to document this new failure mode, which will reduce false 
>>>>positives in CI.
>>>>
>>>>  External URL: https://patchwork.freedesktop.org/api/1.0/series/64263/revisions/1/mbox/
>>>>
>>>>Possible new issues
>>>>-------------------
>>>>
>>>>  Here are the unknown changes that may have been introduced in 
>>>>IGTPW_3297_full:
>>>>
>>>>### IGT changes ###
>>>>
>>>>#### Warnings ####
>>>>
>>>>  * igt@gem_mocs_settings@mocs-settings-dirty-render:
>>>>    - shard-iclb:         [SKIP][1] ([fdo#110206]) -> [FAIL][2] 
>>>>+5 similar issues
>>>
>>>Looks like the filter matched this with the wrong fdo, the test is 
>>>actually failing on ICL (after being re-enabled) and not skipping 
>>>like in the fdo.
>>
>>humn... probably the change to consider global as gen 12+.
>>
>
>Yup, the test seems to be using a global gen9 list in 
>write_dirty_mocs() and then checking it against the return of 
>get_mocs_settings(dirty = true). To make it work we need to add a 
>dirty list for gen11 to be returned by get_mocs_settings() and use it 
>in both places. I'd suggest splitting that task off since it isn't 
>really part of TGL enabling.

yes, I'll drop that patch.

thanks
Lucas De Marchi

>
>Daniele
>
>>Lucas De Marchi
>>
>>>
>>>Daniele
>>>
>>>>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb6/igt@gem_mocs_settings@mocs-settings-dirty-render.html
>>>>
>>>>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_mocs_settings@mocs-settings-dirty-render.html
>>>>
>>>>
>>>>Known issues
>>>>------------
>>>>
>>>>  Here are the changes found in IGTPW_3297_full that come from 
>>>>known issues:
>>>>
>>>>### IGT changes ###
>>>>
>>>>#### Issues hit ####
>>>>
>>>>  * igt@gem_ctx_isolation@bcs0-s3:
>>>>    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] 
>>>>([fdo#108566]) +2 similar issues
>>>>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
>>>>
>>>>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html
>>>>
>>>>
>>>>  * igt@gem_exec_balancer@smoke:
>>>>    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
>>>>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@gem_exec_balancer@smoke.html
>>>>
>>>>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb3/igt@gem_exec_balancer@smoke.html
>>>>
>>>>
>>>>  * igt@gem_workarounds@suspend-resume-fd:
>>>>    - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] 
>>>>([fdo#108566]) +2 similar issues
>>>>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
>>>>
>>>>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
>>>>
>>>>
>>>>  * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
>>>>    - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
>>>>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>>>
>>>>   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>>>
>>>>    - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
>>>>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>>>
>>>>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
>>>>
>>>>
>>>>  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>>>>    - shard-hsw:          [PASS][13] -> [FAIL][14] ([fdo#105767])
>>>>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>>>>
>>>>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>>>>
>>>>
>>>>  * igt@kms_flip@2x-flip-vs-expired-vblank:
>>>>    - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
>>>>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
>>>>
>>>>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
>>>>
>>>>
>>>>  * igt@kms_flip_tiling@flip-to-y-tiled:
>>>>    - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#107931] 
>>>>/ [fdo#108134])
>>>>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb8/igt@kms_flip_tiling@flip-to-y-tiled.html
>>>>
>>>>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb1/igt@kms_flip_tiling@flip-to-y-tiled.html
>>>>
>>>>
>>>>  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>>>>    - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#103167])
>>>>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>>>
>>>>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>>>
>>>>    - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#103167])
>>>>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>>>
>>>>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
>>>>
>>>>
>>>>  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
>>>>    - shard-iclb:         [PASS][23] -> [FAIL][24] 
>>>>([fdo#103167]) +7 similar issues
>>>>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
>>>>
>>>>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
>>>>
>>>>
>>>>  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
>>>>    - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#103167])
>>>>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
>>>>
>>>>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt.html
>>>>
>>>>
>>>>  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>>>>    - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103665])
>>>>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>>>>
>>>>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>>>>
>>>>
>>>>  * igt@kms_plane_lowres@pipe-a-tiling-y:
>>>>    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
>>>>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
>>>>
>>>>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
>>>>
>>>>
>>>>  * igt@kms_psr@psr2_cursor_plane_onoff:
>>>>    - shard-iclb:         [PASS][31] -> [SKIP][32] 
>>>>([fdo#109441]) +3 similar issues
>>>>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
>>>>
>>>>   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
>>>>
>>>>
>>>>  * igt@kms_vblank@pipe-a-query-forked-busy-hang:
>>>>    - shard-kbl:          [PASS][33] -> [DMESG-WARN][34] 
>>>>([fdo#103558] / [fdo#105602]) +3 similar issues
>>>>   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
>>>>
>>>>   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_vblank@pipe-a-query-forked-busy-hang.html
>>>>
>>>>
>>>>#### Possible fixes ####
>>>>
>>>>  * igt@i915_pm_rc6_residency@rc6-accuracy:
>>>>    - shard-kbl:          [SKIP][35] ([fdo#109271]) -> [PASS][36]
>>>>   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
>>>>
>>>>   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html
>>>>
>>>>
>>>>  * igt@i915_suspend@sysfs-reader:
>>>>    - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> 
>>>>[PASS][38] +3 similar issues
>>>>   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-apl5/igt@i915_suspend@sysfs-reader.html
>>>>
>>>>   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-apl5/igt@i915_suspend@sysfs-reader.html
>>>>
>>>>
>>>>  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>>>>    - shard-iclb:         [FAIL][39] ([fdo#103167]) -> 
>>>>[PASS][40] +6 similar issues
>>>>   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>>>>
>>>>   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>>>>
>>>>
>>>>  * igt@kms_psr@psr2_no_drrs:
>>>>    - shard-iclb:         [SKIP][41] ([fdo#109441]) -> 
>>>>[PASS][42] +3 similar issues
>>>>   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
>>>>
>>>>   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
>>>>
>>>>
>>>>#### Warnings ####
>>>>
>>>>  * igt@gem_eio@in-flight-suspend:
>>>>    - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> 
>>>>[INCOMPLETE][44] ([fdo#103665])
>>>>   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@gem_eio@in-flight-suspend.html
>>>>
>>>>   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl6/igt@gem_eio@in-flight-suspend.html
>>>>
>>>>
>>>>  * igt@kms_dp_dsc@basic-dsc-enable-edp:
>>>>    - shard-iclb:         [SKIP][45] ([fdo#109349]) -> 
>>>>[DMESG-WARN][46] ([fdo#107724])
>>>>   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>>>>
>>>>   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>>>>
>>>>
>>>>  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
>>>>    - shard-kbl:          [SKIP][47] ([fdo#109271]) -> 
>>>>[SKIP][48] ([fdo#105602] / [fdo#109271]) +1 similar issue
>>>>   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6553/shard-kbl2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
>>>>
>>>>   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
>>>>
>>>>
>>>>  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>>>>  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>>>>  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>>>>  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>>>>  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>>>>  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>>>>  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>>>>  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>>>>  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>>>>  [fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
>>>>  [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
>>>>  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>>>>  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>>>>  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>>>>  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>>>>  [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
>>>>  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>>>>
>>>>
>>>>Participating hosts (9 -> 6)
>>>>------------------------------
>>>>
>>>>  Missing    (3): pig-skl-6260u shard-skl pig-glk-j5005
>>>>
>>>>
>>>>Build changes
>>>>-------------
>>>>
>>>>  * CI: CI-20190529 -> None
>>>>  * IGT: IGT_5112 -> IGTPW_3297
>>>>  * Piglit: piglit_4509 -> None
>>>>
>>>>  CI-20190529: 20190529
>>>>  CI_DRM_6553: 2480f03103d155b398d2a4f3bb8245877f9b1b8e @ 
>>>>git://anongit.freedesktop.org/gfx-ci/linux
>>>>  IGTPW_3297: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>>>  IGT_5112: 7e4d10507088055413769a020dd674f52b4bc1b0 @ 
>>>>git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>>>>  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ 
>>>>git://anongit.freedesktop.org/piglit
>>>>
>>>>== Logs ==
>>>>
>>>>For more details see: 
>>>>https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3297/
>>>>_______________________________________________
>>>>igt-dev mailing list
>>>>igt-dev@lists.freedesktop.org
>>>>https://lists.freedesktop.org/mailman/listinfo/igt-dev
>>>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
                   ` (6 preceding siblings ...)
  2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
@ 2019-07-26 23:23 ` Daniele Ceraolo Spurio
  2019-07-26 23:35   ` Lucas De Marchi
  7 siblings, 1 reply; 19+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-07-26 23:23 UTC (permalink / raw)
  To: Lucas De Marchi, igt-dev



On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> This helps to identify which entry is wrong in the table.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>   tests/i915/gem_mocs_settings.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 1a311b8c..7b1718f4 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -322,8 +322,10 @@ static void check_control_registers(int fd,
>   	for (int index = 0; index < table.size; index++) {
>   		if (!table.table[index].used)
>   			continue;
> -		igt_assert_eq_u32(read_regs[index],
> -				  table.table[index].control_value);
> +
> +		igt_assert_f(
> +			read_regs[index] == table.table[index].control_value,
> +			"engine=%u index=%u", engine, index);

But like this you're not printing the values anymore, which was useful. 
Also, you're missing a "\n".

Daniele

>   	}
>   
>   	munmap(read_regs, 4096);
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index
  2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
@ 2019-07-26 23:35   ` Lucas De Marchi
  0 siblings, 0 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-07-26 23:35 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio; +Cc: igt-dev

On Fri, Jul 26, 2019 at 04:23:25PM -0700, Daniele Ceraolo Spurio wrote:
>
>
>On 7/25/19 1:33 PM, Lucas De Marchi wrote:
>>This helps to identify which entry is wrong in the table.
>>
>>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>---
>>  tests/i915/gem_mocs_settings.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>>diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
>>index 1a311b8c..7b1718f4 100644
>>--- a/tests/i915/gem_mocs_settings.c
>>+++ b/tests/i915/gem_mocs_settings.c
>>@@ -322,8 +322,10 @@ static void check_control_registers(int fd,
>>  	for (int index = 0; index < table.size; index++) {
>>  		if (!table.table[index].used)
>>  			continue;
>>-		igt_assert_eq_u32(read_regs[index],
>>-				  table.table[index].control_value);
>>+
>>+		igt_assert_f(
>>+			read_regs[index] == table.table[index].control_value,
>>+			"engine=%u index=%u", engine, index);
>
>But like this you're not printing the values anymore, which was 
>useful. Also, you're missing a "\n".

Yep, I'm going to fix this in next iteration.

Lucas De Marchi

>
>Daniele
>
>>  	}
>>  	munmap(read_regs, 4096);
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2019-07-29 20:37 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
2019-07-26 20:49   ` Daniele Ceraolo Spurio
2019-07-26 20:57     ` Chris Wilson
2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
2019-07-27  0:16   ` Daniele Ceraolo Spurio
2019-07-25 20:33 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Lucas De Marchi
2019-07-29 20:53   ` Kumar Valsan, Prathap
2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
2019-07-27  0:23   ` Daniele Ceraolo Spurio
2019-07-25 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index Patchwork
2019-07-25 21:45 ` [igt-dev] [PATCH 1/5] " Lucas De Marchi
2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
2019-07-26 23:26   ` Daniele Ceraolo Spurio
2019-07-26 23:49     ` Lucas De Marchi
2019-07-26 23:54       ` Daniele Ceraolo Spurio
2019-07-27  0:04         ` Lucas De Marchi
2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
2019-07-26 23:35   ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox