Re: [PATCH v4 05/13] media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Frank,

Thank you for the patch.

On Tue, Apr 08, 2025 at 05:53:03PM -0400, Frank Li wrote:
> dma_set_mask_and_coherent() never return failure when mask bigger than
> 32bit.
> 
> See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code")
> 
> So remove return value check for dma_set_mask_and_coherent().
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 015350c6f2784..073ea5912de3b 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev)
>  	}
>  
>  	dma_size = isi->pdata->has_36bit_dma ? 36 : 32;
> -	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
> -	if (ret) {
> -		dev_err(dev, "failed to set DMA mask\n");
> -		return ret;
> -	}
> +	dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
>  
>  	pm_runtime_enable(dev);
>  

-- 
Regards,

Laurent Pinchart