Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@mleia.com>
To: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/LPC32XX SOC SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus
Date: Fri, 14 Nov 2025 01:55:50 +0200	[thread overview]
Message-ID: <af66cc8a-051a-4512-9a02-468b17550775@mleia.com> (raw)
In-Reply-To: <20251029202801.3963952-1-Frank.Li@nxp.com>

Hi Frank.

On 10/29/25 22:27, Frank Li wrote:
> add bus surfix for simple-bus to fix below CHECK_DTBS warnings:

typo in the subject and in the commit message above, s/surfix/suffix/

> arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: usb (simple-bus): $nodename:0: 'usb' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
>          from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 2236901a00313..9790b0a1d6537 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -86,7 +86,7 @@ dma: dma-controller@31000000 {
>   			#dma-cells = <2>;
>   		};
>   
> -		usb {
> +		usb-bus {

Device nodes under "usb" should be just elevated, the "simple-bus" here
was used only to group some controllers together.

>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			compatible = "simple-bus";
> @@ -307,14 +307,14 @@ mpwm: pwm@400e8000 {
>   			};
>   		};
>   
> -		fab {
> +		fab-bus {

FAB shall find its place in the AXI/AHB/APB/... list, isn't it?

>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			compatible = "simple-bus";
>   			ranges = <0x20000000 0x20000000 0x30000000>;
>   
>   			/* System Control Block */
> -			scb {
> +			scb-bus {
>   				compatible = "simple-bus";
>   				ranges = <0x0 0x40004000 0x00001000>;
>   				#address-cells = <1>;

Here "simple-bus" is also unjustified...

-- 
Best wishes,
Vladimir

  parent reply	other threads:[~2025-11-13 23:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 20:27 [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus Frank Li
2025-10-29 20:27 ` [PATCH 2/5] ARM: dts: lpc32xx: add sspclk clock for SPI[0,1] Frank Li
2025-11-13 23:12   ` Vladimir Zapolskiy
2025-10-29 20:27 ` [PATCH 3/5] ARM: dts: lpc3250-ea3250: add key- prefix for gpio-keys Frank Li
2025-11-14  0:02   ` Vladimir Zapolskiy
2025-10-29 20:28 ` [PATCH 4/5] ARM: dts: lpc3250-phy3250: add at25 required properties Frank Li
2025-11-13 23:47   ` Vladimir Zapolskiy
2025-11-14 16:14     ` Frank Li
2025-11-14 16:32       ` Vladimir Zapolskiy
2025-10-29 20:28 ` [PATCH 5/5] ARM: dts: lpc32xx: update #address-cells of arm,pl175 to 2 Frank Li
2025-11-13 23:44   ` Vladimir Zapolskiy
2025-11-13 23:55 ` Vladimir Zapolskiy [this message]
2025-11-14 16:19   ` [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus Frank Li
2025-11-14 16:44     ` Vladimir Zapolskiy
2025-11-14 16:56       ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af66cc8a-051a-4512-9a02-468b17550775@mleia.com \
    --to=vz@mleia.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox