From: Vladimir Zapolskiy <vz@mleia.com>
To: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/LPC32XX SOC SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH 5/5] ARM: dts: lpc32xx: update #address-cells of arm,pl175 to 2
Date: Fri, 14 Nov 2025 01:44:04 +0200 [thread overview]
Message-ID: <eb9fa1ab-07d7-4f9d-add4-e6fff015ff44@mleia.com> (raw)
In-Reply-To: <20251029202801.3963952-5-Frank.Li@nxp.com>
Hi Frank.
On 10/29/25 22:28, Frank Li wrote:
> Change #address-cells of arm,pl175 to 2 to fix below CHECK_DTBS warnings:
> arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: memory-controller@31080000 (arm,pl175): #address-cells: 2 was expected
> from schema $id: http://devicetree.org/schemas/memory-controllers/arm,pl172.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 77f210a2152dc..0249a1838ee0d 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -155,7 +155,7 @@ emc: memory-controller@31080000 {
> reg = <0x31080000 0x1000>;
> clocks = <&clk LPC32XX_CLK_DDRAM>, <&clk LPC32XX_CLK_DDRAM>;
> clock-names = "mpmcclk", "apb_pclk";
> - #address-cells = <1>;
> + #address-cells = <2>;
> #size-cells = <1>;
>
> ranges = <0 0xe0000000 0x01000000>,
Recently you've made a conversion to YAML for arm,pl17x memory controllers
and now this warning is reported - and by the way I believe and it's
opposite to the commit message, the warning is not reported in the upstream,
because lpc3250-ea3250.dts does not enable the controller.
I wonder and let me ask you, why two address cells are needed here?
My default preference is to get one address cell for NOR flash ICs, and
I'd suggest to make a change to the dt binding of the controller.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2025-11-13 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 20:27 [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus Frank Li
2025-10-29 20:27 ` [PATCH 2/5] ARM: dts: lpc32xx: add sspclk clock for SPI[0,1] Frank Li
2025-11-13 23:12 ` Vladimir Zapolskiy
2025-10-29 20:27 ` [PATCH 3/5] ARM: dts: lpc3250-ea3250: add key- prefix for gpio-keys Frank Li
2025-11-14 0:02 ` Vladimir Zapolskiy
2025-10-29 20:28 ` [PATCH 4/5] ARM: dts: lpc3250-phy3250: add at25 required properties Frank Li
2025-11-13 23:47 ` Vladimir Zapolskiy
2025-11-14 16:14 ` Frank Li
2025-11-14 16:32 ` Vladimir Zapolskiy
2025-10-29 20:28 ` [PATCH 5/5] ARM: dts: lpc32xx: update #address-cells of arm,pl175 to 2 Frank Li
2025-11-13 23:44 ` Vladimir Zapolskiy [this message]
2025-11-13 23:55 ` [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus Vladimir Zapolskiy
2025-11-14 16:19 ` Frank Li
2025-11-14 16:44 ` Vladimir Zapolskiy
2025-11-14 16:56 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb9fa1ab-07d7-4f9d-add4-e6fff015ff44@mleia.com \
--to=vz@mleia.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox