From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches
Date: Fri, 19 Feb 2021 19:35:35 +0000 [thread overview]
Message-ID: <00cf44dc72095f5861102e94919838947c418721.camel@intel.com> (raw)
In-Reply-To: <YC6wMEIOfYOfLeKB@intel.com>
On Thu, 2021-02-18 at 20:21 +0200, Ville Syrjälä wrote:
> On Thu, Feb 18, 2021 at 05:25:54PM +0000, Souza, Jose wrote:
> > On Thu, 2021-02-18 at 00:14 +0200, Ville Syrjälä wrote:
> > > On Wed, Feb 17, 2021 at 05:24:03PM +0000, Souza, Jose wrote:
> > > > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote:
> > > > > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote:
> > > > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote:
> > > > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote:
> > > > > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l
> > > > > > > > set with non-zero values for disable planes.
> > > > > > >
> > > > > > > It pretty much happens always since the reset value is not zero.
> > > > > > > IIRC we made the state chcker pedantic enough to complain about
> > > > > > > that, so we need to clean it up.
> > > > > >
> > > > > > Are you planning to fix it soon?
> > > > >
> > > > > Fix what exactly? I guess you're seeing an actual problem of some sort?
> > > >
> > > > Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what
> > > > this patch does.
> > > > Or should we proceed with this solution?
> > >
> > > There should be no mismatches with the current scheme.
> > > We explicitly program wms to 0 for disabled planes.
> > >
> >
> > It still happens when we take over the state that BIOS/firmware left.
>
> That would seem to imply skl_wm_add_affected_planes() isn't working
> right for some reason.
>
Reading out watermark state during initial readout fixed it:
drm/i915/display: Read planes watermarks during initial state readout
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-19 19:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza
2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza
2021-02-12 18:33 ` Ville Syrjälä
2021-02-12 18:22 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches José Roberto de Souza
2021-02-12 18:35 ` Ville Syrjälä
2021-02-12 19:44 ` Souza, Jose
2021-02-12 21:13 ` Ville Syrjälä
2021-02-17 17:24 ` Souza, Jose
2021-02-17 22:14 ` Ville Syrjälä
2021-02-18 17:25 ` Souza, Jose
2021-02-18 18:21 ` Ville Syrjälä
2021-02-19 19:35 ` Souza, Jose [this message]
2021-02-12 18:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping Patchwork
2021-02-12 18:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-02-12 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-12 19:15 ` [Intel-gfx] [PATCH 1/3] " Aditya Swarup
2021-02-12 19:20 ` Ville Syrjälä
2021-02-12 19:42 ` Souza, Jose
2021-02-12 21:17 ` Ville Syrjälä
2021-02-17 17:25 ` Souza, Jose
2021-02-12 20:15 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2021-02-17 17:32 ` Souza, Jose
2021-02-18 20:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00cf44dc72095f5861102e94919838947c418721.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox