public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Indan Zupancic <indan@nul.nu>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/4] drm/i915: save/restore the legacy backlight control
Date: Tue, 28 Aug 2012 08:16:54 +0100	[thread overview]
Message-ID: <051c15$44688s@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <179a19e78c99201a9ec18967c122a5a3aedbf555.1346136448.git.jani.nikula@intel.com>

On Tue, 28 Aug 2012 09:53:36 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> From: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> This is a prep patch to stop drm/i915 from changing the LBPC registers
> itself - but we still need to properly save/restore it on
> suspend/resume.

My presumption was that there were BIOSes out there that only adjusted
the LBPC values, and so any device setting that flag would likely only
with it through the BIOS hotkeys. I couldn't see any other rational
reason for the hardware maintaining multiple interfaces...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-08-28  7:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  6:53 [PATCH 0/4] drm/i915: backlight fixes and cleanup Jani Nikula
2012-08-28  6:53 ` [PATCH 1/4] drm/i915: save/restore the legacy backlight control Jani Nikula
2012-08-28  7:16   ` Chris Wilson [this message]
2012-08-28  7:48     ` Daniel Vetter
2012-08-28 13:56   ` Indan Zupancic
2012-08-28 14:14     ` Daniel Vetter
2012-08-28 14:49       ` Indan Zupancic
2012-08-28 15:15         ` Daniel Vetter
2012-08-30  8:32           ` Indan Zupancic
2012-08-30  8:50             ` Daniel Vetter
2012-08-28  6:53 ` [PATCH 2/4] drm/i915: remove combination mode for backlight control, again Jani Nikula
2012-08-28 14:39   ` Indan Zupancic
2012-08-28 14:55     ` Daniel Vetter
2012-08-30  9:29       ` Indan Zupancic
2012-11-14 16:48         ` Jesse Barnes
2012-08-28  6:53 ` [PATCH 3/4] drm/i915: remove brightness inversion quirk for acer aspire 5734z Jani Nikula
2012-08-28  6:53 ` [PATCH 4/4] drm/i915: remove module parameter and quirk for inverting brightness Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='051c15$44688s@AZSMGA002.ch.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=indan@nul.nu \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox