From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly
Date: Tue, 24 Apr 2012 21:39:21 +0100 [thread overview]
Message-ID: <1335299995_41089@CP5-2952> (raw)
In-Reply-To: <20120424125035.6a495e85@jbarnes-desktop>
On Tue, 24 Apr 2012 12:50:35 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > + /* "flip pending" bit means done if this bit is set */
> > + I915_WRITE(ECOSKPD, _MASKED_BIT_DISABLE(ECO_FLIP_DONE));
> > +
>
> Aha. I hope this works across platforms. I don't even know why this
> bit exists, so I hope it's safe to change on a given chipset & platform.
Patch splitting to come. So far I've tested on a 945gm and PineView and
both are happy with the legacy PendingFlip status mode. And Daniel has
tested on a 915g which was demonstrating the same trouble as our dear
bugzilla reporter. One person I'd like to see I can get testing is Simon
Farnsworth if he still has only of his 945s available for testing.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-24 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 17:31 [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers Chris Wilson
2012-04-24 17:31 ` [PATCH 2/6] drm/i915: Remove redundant initialisation of per-ring IRQ waitqueues Chris Wilson
2012-04-24 19:14 ` Jesse Barnes
2012-04-24 17:31 ` [PATCH 3/6] drm/i915: pending_flip_is_done is gen3, name it so Chris Wilson
2012-04-24 19:15 ` Jesse Barnes
2012-04-24 17:31 ` [PATCH 4/6] drm/i915: Duplicate and split the gen3/4 irq handler Chris Wilson
2012-04-24 17:31 ` [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly Chris Wilson
2012-04-24 19:50 ` Jesse Barnes
2012-04-24 19:58 ` Daniel Vetter
2012-04-24 20:39 ` Chris Wilson [this message]
2012-04-24 17:31 ` [PATCH 6/6] drm/i915: Remove gen3 irq code from gen4 irq routine Chris Wilson
2012-04-24 19:51 ` Jesse Barnes
2012-04-24 19:12 ` [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335299995_41089@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox