From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers
Date: Tue, 24 Apr 2012 12:12:36 -0700 [thread overview]
Message-ID: <20120424121236.68196e3e@jbarnes-desktop> (raw)
In-Reply-To: <1335288691-21819-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, 24 Apr 2012 18:31:26 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Rather than duplicate similar code across the IRQ installers, perform
> the initialisation of the workers upfront. This will lead to simpler
> teardown and quiescent code as we can assume that the workers have
> been initialised.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
Looks nice, and also gives me warm fuzzies about the potential races
between setting up the work queues and interrupts arriving since it
would be all too easy to accidentally call these in postinstall on some
new hw platform.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2012-04-24 19:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 17:31 [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers Chris Wilson
2012-04-24 17:31 ` [PATCH 2/6] drm/i915: Remove redundant initialisation of per-ring IRQ waitqueues Chris Wilson
2012-04-24 19:14 ` Jesse Barnes
2012-04-24 17:31 ` [PATCH 3/6] drm/i915: pending_flip_is_done is gen3, name it so Chris Wilson
2012-04-24 19:15 ` Jesse Barnes
2012-04-24 17:31 ` [PATCH 4/6] drm/i915: Duplicate and split the gen3/4 irq handler Chris Wilson
2012-04-24 17:31 ` [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly Chris Wilson
2012-04-24 19:50 ` Jesse Barnes
2012-04-24 19:58 ` Daniel Vetter
2012-04-24 20:39 ` Chris Wilson
2012-04-24 17:31 ` [PATCH 6/6] drm/i915: Remove gen3 irq code from gen4 irq routine Chris Wilson
2012-04-24 19:51 ` Jesse Barnes
2012-04-24 19:12 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424121236.68196e3e@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox