Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/13] Use VRR timing generator for fixed refresh rate modes
@ 2024-09-02  8:06 Ankit Nautiyal
  2024-09-02  8:06 ` [PATCH 01/13] drm/i915/dp: Avoid vrr compute config for HDMI sink Ankit Nautiyal
                   ` (15 more replies)
  0 siblings, 16 replies; 29+ messages in thread
From: Ankit Nautiyal @ 2024-09-02  8:06 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula, ville.syrjala, mitulkumar.ajitkumar.golani

Even though the VRR timing generator (TG) is primarily used for
variable refresh rates, it can be used for fixed refresh rates as
well. For a fixed refresh rate the Flip Line and Vmax must be equal
(TRANS_VRR_FLIPLINE = TRANS_VRR_VMAX). Beyond that, there are some
dependencies between the VRR timings and the legacy timing generator
registers.

This series is an attempt to use VRR TG for fixed refresh rate.
For platforms XELPD+, always go with VRR timing generator for both fixed and
variable refresh rate cases.

Rev2:
-Added support from MTL+ and for HDMI too.
-Changed VRR VSYNC programming which is required for HDMI.
-Modified vrr compute config for bigjoiner case. (Still to be tested).

Rev3:
-Start support from XELPD+ as MTL needs a WA to have PSR +VRR (fixed
refresh rate)
-Add changes to enable PSR with VRR with fixed refresh rate.

Rev4:
-Addressed review comments from Mitul and rebased.

Rev5:
-Avoid MSA Ignore PAR timing enable bit for fixed refresh rate
with VRR TG.
-Skip VRR compute config for HDMI connected via DP-HDMI2.1 PCON.
-Print fixed_rr along with other VRR parameters in crtc state dump.
-Rebase

Ankit Nautiyal (13):
  drm/i915/dp: Avoid vrr compute config for HDMI sink
  drm/i915/dp: fix the Adaptive sync Operation mode for SDP
  drm/i915/display: Add member fixed_rr to denote Fixed refresh rate
    with VRRTG
  drm/i915/display: Enable MSA Ignore Timing PAR only when in not
    fixed_rr mode
  drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate
  drm/i915/vrr: Compute vrr vsync if platforms support it
  drm/i915/hdmi: Use VRR Timing generator for HDMI
  drm/i915/display: Disable PSR before disabling VRR
  drm/i915/psr: Allow PSR for fixed refrsh rate with VRR TG
  drm/i915/vrr: Avoid sending PUSH when VRR TG is used with Fixed
    refresh rate
  drm/i915/vrr: Handle joiner with vrr
  drm/i915/vrr: Always use VRR timing generator for XELPD+
  drm/i915/display: Add fixed_rr to crtc_state_dump

 .../drm/i915/display/intel_crtc_state_dump.c  |  3 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  8 +-
 .../drm/i915/display/intel_display_types.h    |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 14 ++-
 .../drm/i915/display/intel_dp_link_training.c |  8 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  3 +
 drivers/gpu/drm/i915/display/intel_psr.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_vrr.c      | 91 ++++++++++++-------
 9 files changed, 88 insertions(+), 45 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2024-09-04 13:08 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02  8:06 [PATCH 00/13] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 01/13] drm/i915/dp: Avoid vrr compute config for HDMI sink Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 02/13] drm/i915/dp: fix the Adaptive sync Operation mode for SDP Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 03/13] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG Ankit Nautiyal
2024-09-03 12:51   ` Ville Syrjälä
2024-09-04 12:54     ` Nautiyal, Ankit K
2024-09-02  8:06 ` [PATCH 04/13] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode Ankit Nautiyal
2024-09-03  3:15   ` kernel test robot
2024-09-03  7:52   ` kernel test robot
2024-09-02  8:06 ` [PATCH 05/13] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 06/13] drm/i915/vrr: Compute vrr vsync if platforms support it Ankit Nautiyal
2024-09-03 12:45   ` Ville Syrjälä
2024-09-04 12:55     ` Nautiyal, Ankit K
2024-09-02  8:06 ` [PATCH 07/13] drm/i915/hdmi: Use VRR Timing generator for HDMI Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 08/13] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 09/13] drm/i915/psr: Allow PSR for fixed refrsh rate with VRR TG Ankit Nautiyal
2024-09-02  8:06 ` [PATCH 10/13] drm/i915/vrr: Avoid sending PUSH when VRR TG is used with Fixed refresh rate Ankit Nautiyal
2024-09-03 13:02   ` Ville Syrjälä
2024-09-04 12:57     ` Nautiyal, Ankit K
2024-09-02  8:06 ` [PATCH 11/13] drm/i915/vrr: Handle joiner with vrr Ankit Nautiyal
2024-09-03 13:04   ` Ville Syrjälä
2024-09-04 13:02     ` Nautiyal, Ankit K
2024-09-02  8:06 ` [PATCH 12/13] drm/i915/vrr: Always use VRR timing generator for XELPD+ Ankit Nautiyal
2024-09-03 13:25   ` Ville Syrjälä
2024-09-04 13:08     ` Nautiyal, Ankit K
2024-09-02  8:06 ` [PATCH 13/13] drm/i915/display: Add fixed_rr to crtc_state_dump Ankit Nautiyal
2024-09-02 12:23 ` ✗ Fi.CI.SPARSE: warning for Use VRR timing generator for fixed refresh rate modes (rev5) Patchwork
2024-09-02 12:43 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-02 18:08 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox