From: Chris Wilson <chris@chris-wilson.co.uk>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 7/7] drm/i915: fix gtt space allocated for tiled objects
Date: Tue, 08 Jan 2013 09:59:26 +0000 [thread overview]
Message-ID: <1f4a33$5k1ho3@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1357588059-6631-8-git-send-email-imre.deak@intel.com>
On Mon, 7 Jan 2013 21:47:39 +0200, Imre Deak <imre.deak@intel.com> wrote:
> @@ -361,13 +363,15 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
> obj->map_and_fenceable =
> obj->gtt_space == NULL ||
> (obj->gtt_offset + obj->base.size <= dev_priv->mm.gtt_mappable_end &&
> - i915_gem_object_fence_ok(obj, args->tiling_mode));
> + i915_gem_object_fence_ok(obj, args->tiling_mode,
> + args->stride));
This is a big problem as this will now cause stalls where the code
expects none.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2013-01-08 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 16:41 [PATCH 0/5] drm/i915: fix gtt space allocated for tiled objects Imre Deak
2013-01-04 16:41 ` [PATCH 1/5] drm/i915: merge get_gtt_alignment/get_unfenced_gtt_alignment() Imre Deak
2013-01-04 16:41 ` [PATCH 2/5] drm/i915: merge {i965, sandybridge}_write_fence_reg() Imre Deak
2013-01-04 16:41 ` [PATCH 3/5] drm/i915: use gtt_get_size() instead of open coding it Imre Deak
2013-01-04 16:41 ` [PATCH 4/5] drm/i915: factor out i915_gem_get_tile_width() Imre Deak
2013-01-04 16:42 ` [PATCH 5/5] drm/i915: fix gtt space allocated for tiled objects Imre Deak
2013-01-04 17:07 ` Chris Wilson
2013-01-04 17:23 ` Imre Deak
2013-01-04 17:47 ` Chris Wilson
2013-01-04 19:18 ` Imre Deak
2013-01-04 20:32 ` Chris Wilson
2013-01-04 20:54 ` Imre Deak
2013-01-07 19:47 ` [PATCH v2 0/7] " Imre Deak
2013-01-07 19:47 ` [PATCH v2 1/7] drm/i915: merge get_gtt_alignment/get_unfenced_gtt_alignment() Imre Deak
2013-01-07 19:47 ` [PATCH v2 2/7] drm/i915: merge {i965, sandybridge}_write_fence_reg() Imre Deak
2013-01-07 19:47 ` [PATCH v2 3/7] drm/i915: use gtt_get_size() instead of open coding it Imre Deak
2013-01-14 16:14 ` Daniel Vetter
2013-01-14 16:28 ` Imre Deak
2013-01-07 19:47 ` [PATCH v2 4/7] drm/i915: factor out i915_gem_get_tile_width() Imre Deak
2013-01-07 19:47 ` [PATCH v2 5/7] drm/i915: reject tiling for objects smaller than their tile row size Imre Deak
2013-01-09 15:18 ` [PATCH v3 " Imre Deak
2013-01-07 19:47 ` [PATCH v2 6/7] drm/i915: check tile object alignment explicitly Imre Deak
2013-01-07 19:47 ` [PATCH v2 7/7] drm/i915: fix gtt space allocated for tiled objects Imre Deak
2013-01-08 9:59 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1f4a33$5k1ho3@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox