From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: Force sync command ordering (Gen6+)
Date: Thu, 13 Oct 2011 10:44:25 +0200 [thread overview]
Message-ID: <20111013084425.GD2938@phenom.ffwll.local> (raw)
In-Reply-To: <1318460182-21302-3-git-send-email-ben@bwidawsk.net>
On Wed, Oct 12, 2011 at 03:56:20PM -0700, Ben Widawsky wrote:
> The docs say this is required for Gen7, and since the bit was added for
> Gen6, we are also setting it there pit pf paranoia. Particularly as
> Chris points out, if PIPE_CONTROL counts as a 3d state packet.
>
> This was found through doc inspection by Ken and applies to Gen6+;
>
> Reported-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Now even I get it, thanks to the comment ;-)
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-13 8:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 4:43 [PATCH 0/5] execbuffer cleanups + fixes Ben Widawsky
2011-10-12 4:43 ` [PATCH 1/5] drm/i915: execbuffer simplification Ben Widawsky
2011-10-12 4:43 ` [PATCH 2/5] drm/i915: extract constant offset setting Ben Widawsky
2011-10-12 16:46 ` Ben Widawsky
2011-10-12 4:43 ` [PATCH 3/5] drm/i915: make eb structure do more Ben Widawsky
2011-10-12 4:43 ` [PATCH 4/5] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-10-12 4:43 ` [PATCH 5/5] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
2011-10-12 8:01 ` Ben Widawsky
2011-10-12 9:51 ` Daniel Vetter
2011-10-12 16:59 ` [PATCH 0/5] execbuffer cleanups + fixes Ben Widawsky
2011-10-12 22:56 ` [PATCH 0/4] pre-v2 series Ben Widawsky
2011-10-12 22:56 ` [PATCH 1/4] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-10-13 8:35 ` Daniel Vetter
2011-10-13 17:25 ` Ben Widawsky
2011-10-12 22:56 ` [PATCH 2/4] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
2011-10-13 8:44 ` Daniel Vetter [this message]
2011-10-12 22:56 ` [PATCH 3/4] drm/i915: extract constant offset setting Ben Widawsky
2011-10-13 8:46 ` Daniel Vetter
2011-10-13 17:14 ` Ben Widawsky
2011-10-12 22:56 ` [PATCH 4/4] drm/i915: Use eb for more stuff Ben Widawsky
2011-10-13 8:58 ` Daniel Vetter
2011-10-13 12:00 ` Chris Wilson
2011-10-13 12:49 ` Daniel Vetter
2011-10-13 17:31 ` Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2011-12-13 3:21 [PATCH 0/4] patches for -next Ben Widawsky
2011-12-13 3:21 ` [PATCH 2/4] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013084425.GD2938@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox