From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: extract constant offset setting
Date: Thu, 13 Oct 2011 10:14:10 -0700 [thread overview]
Message-ID: <20111013171409.GA32465@bolo_yeung.jf.intel.com> (raw)
In-Reply-To: <20111013084629.GE2938@phenom.ffwll.local>
On Thu, Oct 13, 2011 at 10:46:29AM +0200, Daniel Vetter wrote:
> On Wed, Oct 12, 2011 at 03:56:21PM -0700, Ben Widawsky wrote:
> > Simple refactor.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Imo you can fold this in with the fix. Usually it's good to separate fixes
> from refactoring, but it this special case of just moving around code
> blocks, it doesn't add anything.
>
I agree, and I had it like this locally, but Chris suggested that he
preferred the separation as it highlighted the fix.
I largely do not care, I just want an r-b. So you two can fight it out.
Ben
next prev parent reply other threads:[~2011-10-13 17:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 4:43 [PATCH 0/5] execbuffer cleanups + fixes Ben Widawsky
2011-10-12 4:43 ` [PATCH 1/5] drm/i915: execbuffer simplification Ben Widawsky
2011-10-12 4:43 ` [PATCH 2/5] drm/i915: extract constant offset setting Ben Widawsky
2011-10-12 16:46 ` Ben Widawsky
2011-10-12 4:43 ` [PATCH 3/5] drm/i915: make eb structure do more Ben Widawsky
2011-10-12 4:43 ` [PATCH 4/5] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-10-12 4:43 ` [PATCH 5/5] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
2011-10-12 8:01 ` Ben Widawsky
2011-10-12 9:51 ` Daniel Vetter
2011-10-12 16:59 ` [PATCH 0/5] execbuffer cleanups + fixes Ben Widawsky
2011-10-12 22:56 ` [PATCH 0/4] pre-v2 series Ben Widawsky
2011-10-12 22:56 ` [PATCH 1/4] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-10-13 8:35 ` Daniel Vetter
2011-10-13 17:25 ` Ben Widawsky
2011-10-12 22:56 ` [PATCH 2/4] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
2011-10-13 8:44 ` Daniel Vetter
2011-10-12 22:56 ` [PATCH 3/4] drm/i915: extract constant offset setting Ben Widawsky
2011-10-13 8:46 ` Daniel Vetter
2011-10-13 17:14 ` Ben Widawsky [this message]
2011-10-12 22:56 ` [PATCH 4/4] drm/i915: Use eb for more stuff Ben Widawsky
2011-10-13 8:58 ` Daniel Vetter
2011-10-13 12:00 ` Chris Wilson
2011-10-13 12:49 ` Daniel Vetter
2011-10-13 17:31 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013171409.GA32465@bolo_yeung.jf.intel.com \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox