From: Daniel Vetter <daniel@ffwll.ch>
To: Eugeni Dodonov <eugeni.dodonov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 6/6] drm/i915: make gpu hangman more resilient
Date: Thu, 26 Apr 2012 10:25:27 +0200 [thread overview]
Message-ID: <20120426082527.GB5156@phenom.ffwll.local> (raw)
In-Reply-To: <CAC7LmnuSWGfup9Vd9dnH_4BanFguRUj_y8Q1L+Jx-RoaUK2KsA@mail.gmail.com>
On Wed, Apr 25, 2012 at 11:30:24PM -0300, Eugeni Dodonov wrote:
> On Apr 25, 2012 9:01 AM, "Daniel Vetter" <daniel.vetter@ffwll.ch> wrote:
> > + /* Also reset the gpu hangman. */
> > + if (dev_priv->stop_rings) {
> > + DRM_DEBUG("Simulated gpu hang, resetting stop_rings\n");
>
> Maybe also print the stop_ring value here?
>
> > + dev_priv->stop_rings = 0;
> > + if (ret) {
> > + DRM_ERROR("Ignoring reset failure in simulated
> gpu hang\n");
>
> ...and error value here as well?
>
> If we are simulating hangs, I'd guess that we are interested in those
> values..
Well, I think I'll check for -ENODEV only instead because I simply don't
want to kill the gpu and force a module reload just because we don't have
the reset code implemented.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-26 8:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 11:57 [PATCH 0/6] gpu hangman support Daniel Vetter
2012-04-25 11:57 ` [PATCH 1/6] drm/i915: add interface to simulate gpu hangs Daniel Vetter
2012-04-26 0:03 ` Eugeni Dodonov
2012-04-25 11:57 ` [PATCH 2/6] drm/i915: rework dev->first_error locking Daniel Vetter
2012-04-25 11:57 ` [PATCH 3/6] drm/i915: destroy existing error_state when simulating a gpu hang Daniel Vetter
2012-04-25 20:20 ` [PATCH] drm/i915: allow the existing error_state to be destroyed Daniel Vetter
2012-04-25 11:57 ` [PATCH 4/6] drm/i915: simplify i915_reset a bit Daniel Vetter
2012-04-25 16:18 ` Jesse Barnes
2012-04-25 20:27 ` Daniel Vetter
2012-04-25 20:34 ` Jesse Barnes
2012-04-25 21:04 ` Daniel Vetter
2012-04-25 23:14 ` Eric Anholt
2012-04-25 11:57 ` [PATCH 5/6] drm/i915: extract i915_do_reset Daniel Vetter
2012-04-25 13:14 ` [PATCH] drm/i915: extract intel_gpu_reset Daniel Vetter
2012-04-25 16:43 ` Ben Widawsky
2012-04-25 11:57 ` [PATCH 6/6] drm/i915: make gpu hangman more resilient Daniel Vetter
[not found] ` <CAC7LmnuSWGfup9Vd9dnH_4BanFguRUj_y8Q1L+Jx-RoaUK2KsA@mail.gmail.com>
2012-04-26 8:25 ` Daniel Vetter [this message]
2012-04-25 12:42 ` [PATCH 0/6] gpu hangman support Chris Wilson
2012-04-27 0:03 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426082527.GB5156@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox