From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel@ffwll.ch>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/6] drm/i915: simplify i915_reset a bit
Date: Wed, 25 Apr 2012 16:14:28 -0700 [thread overview]
Message-ID: <87ehrbqu97.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20120425202712.GH5079@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 1479 bytes --]
On Wed, 25 Apr 2012 22:27:12 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Apr 25, 2012 at 09:18:21AM -0700, Jesse Barnes wrote:
> > On Wed, 25 Apr 2012 13:57:11 +0200
> > Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >
> > > - need_display is always true, scrap it.
> > > - don't reacquire the mutex to do nothing after having restored the
> > > gem state.
> > >
> >
> > Actually I think we generally *don't* need to reset display. It's
> > currently there just because we haven't tried reset handling without
> > it. But not resetting display would make resets a little less visible,
> > which would be nice. Now that you have a nice test setup, can you try
> > testing without the display engine bit set (i.e. only reset render and
> > media at hang time)?
>
> Imo 'less visible' and gpu hang don't go well together, the 3 second
> freeze plus screen flicker at least ensure that users report bugs. And I
> have no idea whether resetting the entire gpu or just the render portion
> has a greater chance of survival. So I'm not sure whether working on this
> has much benefit ... at least opposed to working on the bugs ;-)
I've been hanging my system every couple of minutes most of today, and
this DP panel takes about 15 seconds to light up after a modeset.
Please stop resetting display when I hang the GPU.
(Then if we could get rid of the random decision to fallback to sw in
the 2d driver on a gpu hang, I'd be happy)
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-04-25 23:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 11:57 [PATCH 0/6] gpu hangman support Daniel Vetter
2012-04-25 11:57 ` [PATCH 1/6] drm/i915: add interface to simulate gpu hangs Daniel Vetter
2012-04-26 0:03 ` Eugeni Dodonov
2012-04-25 11:57 ` [PATCH 2/6] drm/i915: rework dev->first_error locking Daniel Vetter
2012-04-25 11:57 ` [PATCH 3/6] drm/i915: destroy existing error_state when simulating a gpu hang Daniel Vetter
2012-04-25 20:20 ` [PATCH] drm/i915: allow the existing error_state to be destroyed Daniel Vetter
2012-04-25 11:57 ` [PATCH 4/6] drm/i915: simplify i915_reset a bit Daniel Vetter
2012-04-25 16:18 ` Jesse Barnes
2012-04-25 20:27 ` Daniel Vetter
2012-04-25 20:34 ` Jesse Barnes
2012-04-25 21:04 ` Daniel Vetter
2012-04-25 23:14 ` Eric Anholt [this message]
2012-04-25 11:57 ` [PATCH 5/6] drm/i915: extract i915_do_reset Daniel Vetter
2012-04-25 13:14 ` [PATCH] drm/i915: extract intel_gpu_reset Daniel Vetter
2012-04-25 16:43 ` Ben Widawsky
2012-04-25 11:57 ` [PATCH 6/6] drm/i915: make gpu hangman more resilient Daniel Vetter
[not found] ` <CAC7LmnuSWGfup9Vd9dnH_4BanFguRUj_y8Q1L+Jx-RoaUK2KsA@mail.gmail.com>
2012-04-26 8:25 ` Daniel Vetter
2012-04-25 12:42 ` [PATCH 0/6] gpu hangman support Chris Wilson
2012-04-27 0:03 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehrbqu97.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox