From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, "Kilarski,
Bernard R" <bernard.r.kilarski@intel.com>
Subject: Re: [PATCH] drm/i915: set IDICOS to medium uncore resources
Date: Sun, 6 May 2012 23:02:53 -0700 [thread overview]
Message-ID: <20120506230253.3f0bac8d@bwidawsk.net> (raw)
In-Reply-To: <20120504210032.GI5443@phenom.ffwll.local>
On Fri, 4 May 2012 23:00:32 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, May 04, 2012 at 01:40:27PM -0700, Jesse Barnes wrote:
> > On Fri, 4 May 2012 18:58:59 -0700
> > Ben Widawsky <ben@bwidawsk.net> wrote:
> >
> > > I'm seeing about a 5% FPS improvement across various benchmarks on my
> > > IVB i3. Rumor has it that the higher end parts show even more benefit.
> > >
> > > This derives from a patch originally given to me by Bernard. The docs
> > > are confusing about the definition names (ie. medium really seems
> > > like max), but it would seem it gives more cache to the GT at the
> > > expense of uncore. This configuration makes the split most in favor
> > > of the GT. I've not tried the other IDICOS values.
> >
> > Bringing the IRC discussion here. I think this is really at the
> > expense (though not really) of the CPU, since it allows the GPU to use
> > more of the shared CPU/GPU cache in the uncore.
> >
> > You can fix up the #define names if you want; the MEDIUM etc may be
> > from an old, incorrect doc. They were added awhile back.
>
> Another perk from me: Can you do some benchmarking of this for snb, too?
> -Daniel
I didn't see such gains on my SNB. I ran half as many benchmarks, one
had almost 2% improvement, the other had a slight performance
regression.
Honestly, I'm a bit surprised by this, I may spend some more time to see
what happens.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-05-07 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 1:58 [PATCH] drm/i915: set IDICOS to medium uncore resources Ben Widawsky
2012-05-04 20:40 ` Jesse Barnes
2012-05-04 21:00 ` Daniel Vetter
2012-05-07 6:02 ` Ben Widawsky [this message]
2012-05-06 3:04 ` Ben Widawsky
2012-05-07 6:51 ` Eric Anholt
2012-05-07 16:32 ` Ben Widawsky
2012-06-14 6:36 ` Eric Anholt
2012-06-18 8:35 ` Daniel Vetter
2012-07-16 10:29 ` Chris Wilson
2012-07-18 16:07 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506230253.3f0bac8d@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=bernard.r.kilarski@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox