From: Damien Lespiau <damien.lespiau@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/i915: Don't clobber CHICKEN_PIPESL_1 on BDW
Date: Wed, 5 Mar 2014 12:09:17 +0000 [thread overview]
Message-ID: <20140305120917.GA23022@strange.icx.intel.com> (raw)
In-Reply-To: <1394017547-18234-2-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Mar 05, 2014 at 01:05:45PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Misplaced parens cause us to totally clobber the CHICKEN_PIPESL_1
> registers with 0xffffffff. Move the parens to the correct place
> to avoid this.
>
> In particular this caused bit 30 of said registers to be set, which
> caused the sprite CSC to produce incorrect results.
>
> Cc: stable@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72220
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 6436b70..245d3ae 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4832,8 +4832,8 @@ static void gen8_init_clock_gating(struct drm_device *dev)
> /* WaPsrDPRSUnmaskVBlankInSRD:bdw */
> for_each_pipe(i) {
> I915_WRITE(CHICKEN_PIPESL_1(i),
> - I915_READ(CHICKEN_PIPESL_1(i) |
> - DPRS_MASK_VBLANK_SRD));
> + I915_READ(CHICKEN_PIPESL_1(i)) |
> + DPRS_MASK_VBLANK_SRD);
> }
>
> /* Use Force Non-Coherent whenever executing a 3D context. This is a
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-03-05 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:05 [PATCH 0/3] drm/i915: Fix BDW sprite colors and a few cleanups ville.syrjala
2014-03-05 11:05 ` [PATCH 1/3] drm/i915: Don't clobber CHICKEN_PIPESL_1 on BDW ville.syrjala
2014-03-05 12:09 ` Damien Lespiau [this message]
2014-03-05 11:05 ` [PATCH 2/3] drm/i915: Use RMW to update chicken bits in gen7_enable_fbc() ville.syrjala
2014-03-05 14:31 ` Damien Lespiau
2014-03-21 18:52 ` Ben Widawsky
2014-03-05 11:05 ` [PATCH 3/3] drm/i915: Unify CHICKEN_PIPESL_1 register definitions ville.syrjala
2014-03-05 14:40 ` Damien Lespiau
2014-03-05 18:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305120917.GA23022@strange.icx.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox