Re: [PATCH] tests/gen7_forcewake_mt: Don't set the GGTT bit in SRM command

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Apr 09, 2014 at 07:20:30AM +0100, Chris Wilson wrote:
> On Tue, Apr 08, 2014 at 02:22:16PM -0700, bradley.d.volkin@intel.com wrote:
> > From: Brad Volkin <bradley.d.volkin@intel.com>
> > 
> > The command parser in newer kernels will reject it and setting this
> > bit is not required for the actual test case.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76670
> > Signed-off-by: Brad Volkin <bradley.d.volkin@intel.com>
> 
> This was written how I did in the ddx...

Oops, sounds like the cmd parser needs to transparently set this when
copying to the hidden batch ... We could of course do some magic in the
kernel and let it pass, but my current plan is that we'll enable the cmd
parser for secure batches only (to avoid the heft perf hit and that's
essentially no worse than what we have already), so that Xorg and mesa
don't need to be run as root on hsw.

But that means for at least sensible test coverage we should still
scan/copy even root batches since until fc22 (or whatever it was) ships we
won't have many systems with non-root X out there yet for testing.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch