From: Daniel Vetter <daniel@ffwll.ch>
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/gen7_forcewake_mt: Don't set the GGTT bit in SRM command
Date: Wed, 9 Apr 2014 18:47:57 +0200 [thread overview]
Message-ID: <20140409164757.GZ9262@phenom.ffwll.local> (raw)
In-Reply-To: <20140409151228.GB9346@bdvolkin-ubuntu-desktop>
On Wed, Apr 09, 2014 at 08:12:28AM -0700, Volkin, Bradley D wrote:
> On Tue, Apr 08, 2014 at 11:20:30PM -0700, Chris Wilson wrote:
> > On Tue, Apr 08, 2014 at 02:22:16PM -0700, bradley.d.volkin@intel.com wrote:
> > > From: Brad Volkin <bradley.d.volkin@intel.com>
> > >
> > > The command parser in newer kernels will reject it and setting this
> > > bit is not required for the actual test case.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76670
> > > Signed-off-by: Brad Volkin <bradley.d.volkin@intel.com>
> >
> > This was written how I did in the ddx...
>
> Oh, I thought you had said that the ddx didn't use MI_STORE_REGISTER_MEM, and
> I didn't see it used in the current ddx code, so I thought that part of the
> test wasn't relevant to the actual workaround. It looked like it was just a
> write so we could see the values and check that they were updated. But if it
> is, then yeah, I don't want to change the test behavior.
Hm right I think Chris said that in the ended he never released a ddx
version with this code. Now I'm indeed rather confused what's going on. If
we don't need it I obviously prefer less complexity in the kernel cmd
parser.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-09 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 21:22 [PATCH] tests/gen7_forcewake_mt: Don't set the GGTT bit in SRM command bradley.d.volkin
2014-04-09 6:20 ` Chris Wilson
2014-04-09 13:32 ` Daniel Vetter
2014-04-09 15:12 ` Volkin, Bradley D
2014-04-09 16:47 ` Daniel Vetter [this message]
2014-04-22 16:45 ` Volkin, Bradley D
-- strict thread matches above, loose matches on Subject: below --
2014-05-10 21:11 bradley.d.volkin
2014-05-12 16:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409164757.GZ9262@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bradley.d.volkin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox