From: Daniel Vetter <daniel@ffwll.ch>
To: akash.goel@intel.com
Cc: intel-gfx@lists.freedesktop.org, sourab.gupta@intel.com
Subject: Re: [PATCH v5] drm/i915: Added write-enable pte bit support
Date: Tue, 17 Jun 2014 09:22:07 +0200 [thread overview]
Message-ID: <20140617072207.GN5821@phenom.ffwll.local> (raw)
In-Reply-To: <1402982982-7185-1-git-send-email-akash.goel@intel.com>
On Tue, Jun 17, 2014 at 10:59:42AM +0530, akash.goel@intel.com wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> This adds support for a write-enable bit in the entry of GTT.
> This is handled via a read-only flag in the GEM buffer object which
> is then used to see how to set the bit when writing the GTT entries.
> Currently by default the Batch buffer & Ring buffers are marked as read only.
>
> v2: Moved the pte override code for read-only bit to 'byt_pte_encode'. (Chris)
> Fixed the issue of leaving 'gt_old_ro' as unused. (Chris)
>
> v3: Removed the 'gt_old_ro' field, now setting RO bit only for Ring Buffers(Daniel).
>
> v4: Added a new 'flags' parameter to all the pte(gen6) encode & insert_entries functions,
> in lieu of overloading the cache_level enum (Daniel).
>
> v5: Removed the superfluous VLV check & changed the definition location of PTE_READ_ONLY flag (Imre)
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Akash Goel <akash.goel@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-17 7:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 8:49 [PATCH v3] drm/i915: Added write-enable pte bit support akash.goel
2014-04-24 9:44 ` Goel, Akash
2014-05-13 22:05 ` Jesse Barnes
2014-05-13 22:30 ` Daniel Vetter
2014-05-13 22:43 ` Jesse Barnes
2014-05-14 8:14 ` Daniel Vetter
2014-05-18 5:57 ` Akash Goel
2014-05-19 6:56 ` Daniel Vetter
2014-05-19 7:33 ` Akash Goel
2014-06-01 6:42 ` Akash Goel
2014-06-02 8:19 ` Daniel Vetter
2014-06-04 4:46 ` Akash Goel
2014-06-09 3:06 ` [PATCH v4] " akash.goel
2014-06-16 19:50 ` Imre Deak
2014-06-17 5:29 ` [PATCH v5] " akash.goel
2014-06-17 7:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617072207.GN5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox