From: Daniel Vetter <daniel@ffwll.ch>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/8] drm/i915: Setting legacy palette correctly for different platforms
Date: Mon, 21 Jul 2014 17:49:07 +0200 [thread overview]
Message-ID: <20140721154907.GX15237@phenom.ffwll.local> (raw)
In-Reply-To: <1405936425-17341-5-git-send-email-sonika.jindal@intel.com>
On Mon, Jul 21, 2014 at 03:23:41PM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c89b4ac..442d8ba 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3847,7 +3847,7 @@ static void intel_crtc_load_lut(struct drm_crtc *crtc)
> }
>
> /* use legacy palette for Ironlake */
> - if (HAS_PCH_SPLIT(dev))
> + if (INTEL_INFO(dev)->gen >= 5 && !IS_VALLEYVIEW(dev))
Imo we should check for !HAS_GMCH_DISPLAY here.
-Daniel
> palreg = LGC_PALETTE(pipe);
>
> /* Workaround : Do not read or write the pipe palette/gamma data while
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-21 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 9:53 [PATCH 0/8 v2] Future preparation patches sonika.jindal
2014-07-21 9:53 ` [PATCH 1/8] drm/i915: Adding HAS_GMCH_DISPLAY macro sonika.jindal
2014-07-21 9:53 ` [PATCH 2/8] drm/i915: Allowing changing of wm latencies for valid platforms sonika.jindal
2014-07-21 9:53 ` [PATCH 3/8] drm/i915: Returning the right VGA control reg for platforms sonika.jindal
2014-07-21 9:53 ` [PATCH 4/8] drm/i915: Setting legacy palette correctly for different platforms sonika.jindal
2014-07-21 15:49 ` Daniel Vetter [this message]
2014-07-22 5:48 ` [PATCH v2] " sonika.jindal
2014-07-21 9:53 ` [PATCH 5/8] drm/i915: Returning from increase/decrease of pllclock when invalid sonika.jindal
2014-07-21 15:50 ` Daniel Vetter
2014-07-22 5:46 ` [PATCH v2] " sonika.jindal
2014-07-21 9:53 ` [PATCH 6/8] drm/i915: Writing proper check for reading of pipe status reg sonika.jindal
2014-07-21 9:53 ` [PATCH 7/8] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in sonika.jindal
2014-07-21 15:51 ` Daniel Vetter
2014-07-22 5:43 ` [PATCH v2] " sonika.jindal
2014-07-22 7:13 ` Daniel Vetter
2014-07-21 9:53 ` [PATCH 8/8] drm/i915: Avoid incorrect returning for some platforms sonika.jindal
2014-07-21 15:52 ` [PATCH 0/8 v2] Future preparation patches Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721154907.GX15237@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox