✗ Fi.CI.CHECKPATCH: warning for series starting with [01/19] drm/i915: Move request->ctx aside

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [01/19] drm/i915: Move request->ctx aside
URL   : https://patchwork.freedesktop.org/series/43307/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
61b8422e1e2d drm/i915: Move request->ctx aside
2bb24771dc50 drm/i915: Move fiddling with engine->last_retired_context
e413648660a8 drm/i915: Store a pointer to intel_context in i915_request
cdb7874e5959 drm/i915: Pull the context->pin_count dec into the common intel_context_unpin
881c9a393191 drm/i915: Be irqsafe inside reset
7f53d8f97784 drm/i915: Make intel_engine_dump irqsafe
22e514de28e8 drm/i915/execlists: Handle copying default context state for atomic reset
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
References: 5692251c254a ("drm/i915/lrc: Scrub the GPU state of the guilty hanging request")

-:17: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 5692251c254a ("drm/i915/lrc: Scrub the GPU state of the guilty hanging request")'
#17: 
References: 5692251c254a ("drm/i915/lrc: Scrub the GPU state of the guilty hanging request")

total: 1 errors, 1 warnings, 0 checks, 55 lines checked
4510e41550db drm/i915: Allow init_breadcrumbs to be used from irq context
90e61963b796 drm/i915/execlists: HWACK checking superseded checking port[0].count
838e29f5244a drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler
1a251707029f drm/i915/execlists: Double check rpm wakeref
3a17d4cca75a drm/i915: After reset on sanitization, reset the engine backends
17100b91e099 drm/i915/execlists: Reset the CSB head tracking on reset/sanitization
-:41: WARNING:LONG_LINE: line over 100 characters
#41: FILE: drivers/gpu/drm/i915/intel_lrc.c:995:
+				(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_BUF_LO(engine, 0)));

total: 0 errors, 1 warnings, 0 checks, 52 lines checked
4fc2d904fb93 drm/i915/execlists: Pull submit after dequeue under timeline lock
97b89d846cee drm/i915/execlists: Process one CSB interrupt at a time
-:40: WARNING:MEMORY_BARRIER: memory barrier without comment
#40: FILE: drivers/gpu/drm/i915/intel_lrc.c:982:
+	smp_mb__after_atomic();

-:82: WARNING:LONG_LINE: line over 100 characters
#82: FILE: drivers/gpu/drm/i915/intel_lrc.c:1006:
+		  head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?",

-:83: WARNING:LONG_LINE: line over 100 characters
#83: FILE: drivers/gpu/drm/i915/intel_lrc.c:1007:
+		  tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?");

-:145: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#145: FILE: drivers/gpu/drm/i915/intel_lrc.c:1038:
+			  status, buf[2*head + 1],
 			               ^

-:181: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#181: FILE: drivers/gpu/drm/i915/intel_lrc.c:1056:
+		    buf[2*head + 1] == execlists->preempt_complete_status) {
 		         ^

total: 0 errors, 3 warnings, 2 checks, 305 lines checked
0764078e971c drm/i915/execlists: Unify CSB access pointers
c3ad3709a86e drm/i915/execlists: Process the CSB directly from inside the irq handler
9af36d245179 drm/i915/execlists: Direct submission (avoid tasklet/ksoftirqd)
-:52: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#52: 
References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")

-:52: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")'
#52: 
References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")

total: 1 errors, 1 warnings, 0 checks, 126 lines checked
caac3766a115 drm/i915: Combine gt irq ack/handlers

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx