From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 10/19] drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler
Date: Thu, 17 May 2018 14:13:49 +0100 [thread overview]
Message-ID: <51e4585b-66b5-aa6b-df00-818817e91581@linux.intel.com> (raw)
In-Reply-To: <152655629121.26696.15701983221996316297@mail.alporthouse.com>
On 17/05/2018 12:24, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-05-17 11:58:21)
>>
>> On 17/05/2018 08:40, Chris Wilson wrote:
>>> Store whether or not we need to kick the guc's execlists emulation on
>>> the engine itself to avoid chasing the device info.
>>
>> We do not chase device info but modparams in this case.
>>
>>> gen8_cs_irq_handler 512 428 -84
>>
>> I guess my point from before, (unfortunately I forgot to reply), was how
>> much of the saving remains if GEM_BUG_ON is compiled out?
>
> Remember the motto of killing off checking globals and only checking
> derived state? :) (I'm definitely not in favour of sprinkling more global
> checking CAPS over the code.)
>
> Out of the debug build
>
> gen8_cs_irq_handler 170 185 +15
> gen8_cs_irq_handler 170 128 -42 (later)
> gen8_cs_irq_handler 170 128 -42 (+ USES_GUC_SUBMISSION)
I don't get which is which.
[snip]
>> If nothing or almost nothing, I don't see a need to fiddle with this now.
>
> Also please consider later patches which also need conditionals as
> execlists is unfortunately gaining new tricks that are harder to pull
> off with the current guc submission :|
> (Might be time to stop mixing the two backends?)
I might say fine if the commit message contained truth. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-17 13:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 7:40 [PATCH 01/19] drm/i915: Move request->ctx aside Chris Wilson
2018-05-17 7:40 ` [PATCH 02/19] drm/i915: Move fiddling with engine->last_retired_context Chris Wilson
2018-05-17 7:40 ` [PATCH 03/19] drm/i915: Store a pointer to intel_context in i915_request Chris Wilson
2018-05-17 7:40 ` [PATCH 04/19] drm/i915: Pull the context->pin_count dec into the common intel_context_unpin Chris Wilson
2018-05-17 10:20 ` Tvrtko Ursulin
2018-05-17 10:35 ` Chris Wilson
2018-05-17 7:40 ` [PATCH 05/19] drm/i915: Be irqsafe inside reset Chris Wilson
2018-05-17 10:27 ` Tvrtko Ursulin
2018-05-17 10:46 ` Chris Wilson
2018-05-17 7:40 ` [PATCH 06/19] drm/i915: Make intel_engine_dump irqsafe Chris Wilson
2018-05-17 10:28 ` Tvrtko Ursulin
2018-05-17 7:40 ` [PATCH 07/19] drm/i915/execlists: Handle copying default context state for atomic reset Chris Wilson
2018-05-17 10:37 ` Tvrtko Ursulin
2018-05-17 7:40 ` [PATCH 08/19] drm/i915: Allow init_breadcrumbs to be used from irq context Chris Wilson
2018-05-17 10:40 ` Tvrtko Ursulin
2018-05-17 7:40 ` [PATCH 09/19] drm/i915/execlists: HWACK checking superseded checking port[0].count Chris Wilson
2018-05-17 10:55 ` Tvrtko Ursulin
2018-05-17 17:03 ` Chris Wilson
2018-05-17 7:40 ` [PATCH 10/19] drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler Chris Wilson
2018-05-17 10:58 ` Tvrtko Ursulin
2018-05-17 11:24 ` Chris Wilson
2018-05-17 13:13 ` Tvrtko Ursulin [this message]
2018-05-17 7:40 ` [PATCH 11/19] drm/i915/execlists: Double check rpm wakeref Chris Wilson
2018-05-17 11:04 ` Tvrtko Ursulin
2018-05-17 7:40 ` [PATCH 12/19] drm/i915: After reset on sanitization, reset the engine backends Chris Wilson
2018-05-17 7:40 ` [PATCH 13/19] drm/i915/execlists: Reset the CSB head tracking on reset/sanitization Chris Wilson
2018-05-17 7:40 ` [PATCH 14/19] drm/i915/execlists: Pull submit after dequeue under timeline lock Chris Wilson
2018-05-17 7:40 ` [PATCH 15/19] drm/i915/execlists: Process one CSB interrupt at a time Chris Wilson
2018-05-17 7:40 ` [PATCH 16/19] drm/i915/execlists: Unify CSB access pointers Chris Wilson
2018-05-17 7:40 ` [PATCH 17/19] drm/i915/execlists: Process the CSB directly from inside the irq handler Chris Wilson
2018-05-17 7:40 ` [PATCH 18/19] drm/i915/execlists: Direct submission (avoid tasklet/ksoftirqd) Chris Wilson
2018-05-17 13:13 ` Tvrtko Ursulin
2018-05-17 17:07 ` Chris Wilson
2018-05-18 8:06 ` Tvrtko Ursulin
2018-05-18 8:18 ` Chris Wilson
2018-05-18 19:36 ` Chris Wilson
2018-05-18 21:21 ` Chris Wilson
2018-05-17 7:40 ` [PATCH 19/19] drm/i915: Combine gt irq ack/handlers Chris Wilson
2018-05-17 8:01 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/19] drm/i915: Move request->ctx aside Patchwork
2018-05-17 8:06 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-17 8:16 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-17 11:05 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51e4585b-66b5-aa6b-df00-818817e91581@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox