public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [v3 2/7] drm/dp/fec: DRM helper for Forward Error Correction
Date: Thu, 25 Oct 2018 21:49:38 -0700	[thread overview]
Message-ID: <20181026044943.29334-3-anusha.srivatsa@intel.com> (raw)
In-Reply-To: <20181026044943.29334-1-anusha.srivatsa@intel.com>

DP 1.4 has Forward Error Correction Support(FEC).
Add helper function to check if the sink device
supports FEC.

v2: Separate the helper and the code that uses the helper into
two separate patches. (Manasi)

v3:
- Move the code to drm_dp_helper.c (Manasi)
- change the return type, code style changes (Gaurav)
- Use drm_dp_dpcd_readb instead of drm_dp_dpcd_read. (Jani)

v4:
- Avoid aux reads everytime, instead read cached
values of dpcd register (jani)
- Move helper to drm_dp_helper.h like other dsc
helpers.(Anusha)

v5: rebased. Change the helper parameter suitably.

Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 include/drm/drm_dp_helper.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2649529d0d8f..b08f50b852f5 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1101,6 +1101,13 @@ drm_dp_dsc_sink_max_slice_width(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
 		DP_DSC_SLICE_WIDTH_MULTIPLIER;
 }
 
+/* Forward Error Correction Support on DP 1.4 */
+static inline bool
+drm_dp_sink_supports_fec(const u8 fec_capable)
+{
+	return fec_capable & DP_FEC_CAPABLE;
+}
+
 /*
  * DisplayPort AUX channel
  */
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-10-26  4:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  4:49 [v3 0/7] Forward Error Correction Anusha Srivatsa
2018-10-26  4:49 ` [v3 1/7] i915/dp/fec: Cache the FEC_CAPABLE DPCD register Anusha Srivatsa
2018-10-30  2:29   ` Manasi Navare
2018-10-26  4:49 ` Anusha Srivatsa [this message]
2018-10-30  2:30   ` [v3 2/7] drm/dp/fec: DRM helper for Forward Error Correction Manasi Navare
2018-10-26  4:49 ` [v3 3/7] i915/dp/fec: Check for FEC Support Anusha Srivatsa
2018-10-26  4:49 ` [v3 4/7] i915/dp/fec: Add can_fec to the crtc state Anusha Srivatsa
2018-10-30  2:44   ` Manasi Navare
2018-10-30 18:57   ` Ville Syrjälä
2018-10-30 19:38     ` Ville Syrjälä
2018-10-26  4:49 ` [v3 5/7] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION Anusha Srivatsa
2018-10-26  4:49 ` [v3 6/7] i915/dp/fec: Configure the Forward Error Correction bits Anusha Srivatsa
2018-10-26  4:49 ` [v3 7/7] drm/i915/fec: Disable FEC state Anusha Srivatsa
2018-10-26  5:07 ` ✗ Fi.CI.BAT: failure for Forward Error Correction (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026044943.29334-3-anusha.srivatsa@intel.com \
    --to=anusha.srivatsa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox