* [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in
@ 2018-11-16 14:44 Joonas Lahtinen
2018-11-16 14:49 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2018-11-16 14:44 UTC (permalink / raw)
To: Intel graphics driver community testing & development
Hide the enable_gvt modparam in the default scenario where
support has not been compiled in.
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_params.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 8d71886b5f03..2e0356561839 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
i915_param_named(enable_dpcd_backlight, bool, 0600,
"Enable support for DPCD backlight control (default:false)");
+#if IS_ENABLED(CONFIG_DRM_I915_GVT)
i915_param_named(enable_gvt, bool, 0400,
"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
+#endif
static __always_inline void _print_param(struct drm_printer *p,
const char *name,
--
2.17.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in
2018-11-16 14:44 [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Joonas Lahtinen
@ 2018-11-16 14:49 ` Chris Wilson
2018-11-16 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-11-16 14:49 UTC (permalink / raw)
To: Intel graphics driver community testing & development,
Joonas Lahtinen
Quoting Joonas Lahtinen (2018-11-16 14:44:47)
> Hide the enable_gvt modparam in the default scenario where
> support has not been compiled in.
>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Alternative would be to move the param into a gvt-only file.c
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Random thought: Also a lot of the error state will be garbage for gvt
clients.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Hide enable_gvt modparam when not compiled in
2018-11-16 14:44 [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Joonas Lahtinen
2018-11-16 14:49 ` Chris Wilson
@ 2018-11-16 15:31 ` Patchwork
2018-11-19 11:19 ` Joonas Lahtinen
2018-11-16 23:46 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-19 2:02 ` [PATCH] " Zhenyu Wang
3 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-11-16 15:31 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Hide enable_gvt modparam when not compiled in
URL : https://patchwork.freedesktop.org/series/52616/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5151 -> Patchwork_10841 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52616/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10841:
=== IGT changes ===
==== Possible regressions ====
{igt@runner@aborted}:
fi-icl-u: NOTRUN -> FAIL
== Known issues ==
Here are the changes found in Patchwork_10841 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
==== Possible fixes ====
igt@i915_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@i915_selftest@live_hangcheck:
fi-skl-iommu: INCOMPLETE (fdo#108602) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-WARN (fdo#102614) -> PASS
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@i915_selftest@live_contexts:
fi-icl-u: DMESG-FAIL (fdo#108569) -> INCOMPLETE (fdo#108315)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
fdo#108602 https://bugs.freedesktop.org/show_bug.cgi?id=108602
== Participating hosts (48 -> 46) ==
Additional (1): fi-byt-j1900
Missing (3): fi-ilk-m540 fi-byt-squawks fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_5151 -> Patchwork_10841
CI_DRM_5151: 65d1ff82ff3c9c20c78bd66f19f0f20f0fd46c4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10841: fa91c9f62ba9c96a7b2f86dcd39c7e6617918805 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fa91c9f62ba9 drm/i915: Hide enable_gvt modparam when not compiled in
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10841/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Hide enable_gvt modparam when not compiled in
2018-11-16 14:44 [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Joonas Lahtinen
2018-11-16 14:49 ` Chris Wilson
2018-11-16 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-16 23:46 ` Patchwork
2018-11-19 2:02 ` [PATCH] " Zhenyu Wang
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-16 23:46 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Hide enable_gvt modparam when not compiled in
URL : https://patchwork.freedesktop.org/series/52616/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5151_full -> Patchwork_10841_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10841_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10841_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10841_full:
=== IGT changes ===
==== Warnings ====
igt@kms_busy@basic-flip-b:
shard-snb: SKIP -> PASS
igt@tools_test@sysfs_l3_parity:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10841_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@gem_userptr_blits@readonly-unsync:
shard-skl: PASS -> INCOMPLETE (fdo#108074)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-skl: NOTRUN -> FAIL (fdo#108145, fdo#107725)
igt@kms_cursor_crc@cursor-128x128-random:
shard-glk: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-128x42-random:
shard-skl: NOTRUN -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-256x256-dpms:
shard-apl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-skl: NOTRUN -> FAIL (fdo#103232, fdo#103191)
igt@kms_cursor_legacy@flip-vs-cursor-legacy:
shard-glk: PASS -> FAIL (fdo#102670)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-glk: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-stridechange:
shard-skl: NOTRUN -> FAIL (fdo#105683)
igt@kms_frontbuffer_tracking@psr-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#106978, fdo#104108)
igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
shard-skl: NOTRUN -> FAIL (fdo#108145, fdo#107815)
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166) +3
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#103166)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@fences:
shard-skl: PASS -> INCOMPLETE (fdo#107807) +2
igt@pm_rpm@pm-caching:
shard-skl: NOTRUN -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@kms_available_modes_crc@available_mode_test_crc:
shard-apl: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-hsw: DMESG-WARN (fdo#107956) -> PASS
igt@kms_color@pipe-a-gamma:
shard-skl: FAIL (fdo#104782) -> PASS
igt@kms_color@pipe-b-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-64x64-onscreen:
shard-skl: FAIL (fdo#103232) -> PASS
igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
shard-skl: FAIL (fdo#103184) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS +3
igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
shard-skl: FAIL (fdo#103167) -> PASS +3
igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
shard-skl: FAIL (fdo#108145, fdo#107815) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +2
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_vblank@pipe-a-wait-busy:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS +1
igt@kms_vblank@pipe-c-ts-continuation-suspend:
shard-skl: INCOMPLETE (fdo#104108, fdo#107773) -> PASS +1
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106978 https://bugs.freedesktop.org/show_bug.cgi?id=106978
fdo#107725 https://bugs.freedesktop.org/show_bug.cgi?id=107725
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (7 -> 6) ==
Missing (1): shard-iclb
== Build changes ==
* Linux: CI_DRM_5151 -> Patchwork_10841
CI_DRM_5151: 65d1ff82ff3c9c20c78bd66f19f0f20f0fd46c4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10841: fa91c9f62ba9c96a7b2f86dcd39c7e6617918805 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10841/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in
2018-11-16 14:44 [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Joonas Lahtinen
` (2 preceding siblings ...)
2018-11-16 23:46 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-19 2:02 ` Zhenyu Wang
3 siblings, 0 replies; 6+ messages in thread
From: Zhenyu Wang @ 2018-11-19 2:02 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: Intel graphics driver community testing & development
[-- Attachment #1.1: Type: text/plain, Size: 1545 bytes --]
On 2018.11.16 16:44:47 +0200, Joonas Lahtinen wrote:
> Hide the enable_gvt modparam in the default scenario where
> support has not been compiled in.
>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 8d71886b5f03..2e0356561839 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
> i915_param_named(enable_dpcd_backlight, bool, 0600,
> "Enable support for DPCD backlight control (default:false)");
>
> +#if IS_ENABLED(CONFIG_DRM_I915_GVT)
> i915_param_named(enable_gvt, bool, 0400,
> "Enable support for Intel GVT-g graphics virtualization host support(default:false)");
> +#endif
>
> static __always_inline void _print_param(struct drm_printer *p,
> const char *name,
I'm thinking we'd better to remove gvt parameter but depends on kernel
config only in considering of current state and be easier to try, or
better to be handled by gvt module split which will remove this
anyway, so
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-19 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-16 14:44 [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Joonas Lahtinen
2018-11-16 14:49 ` Chris Wilson
2018-11-16 15:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-19 11:19 ` Joonas Lahtinen
2018-11-16 23:46 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-19 2:02 ` [PATCH] " Zhenyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox