✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix TypeC port mode switching (rev2)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix TypeC port mode switching (rev2)
Date: Fri, 07 Jun 2019 17:59:11 -0000	[thread overview]
Message-ID: <20190607175911.32140.54164@emeril.freedesktop.org> (raw)
In-Reply-To: <20190604145826.16424-1-imre.deak@intel.com>

== Series Details ==

Series: drm/i915: Fix TypeC port mode switching (rev2)
URL   : https://patchwork.freedesktop.org/series/61590/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
429dfd1e1b32 drm/i915/icl: Add support to read out the TBT PLL HW state
8ceef23351d2 drm/i915: Tune down WARNs about TBT AUX power well enabling
44c9b3647fd4 drm/i915: Move the TypeC port handling code to a separate file
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
- s/intel_dp_get_fia_supported_lane_count()/intel_tc_port_fia_max_lane_count()/

-:372: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#372: 
new file mode 100644

-:553: CHECK:LINE_SPACING: Please don't use multiple blank lines
#553: FILE: drivers/gpu/drm/i915/intel_tc.c:177:
+
+

-:613: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#613: FILE: drivers/gpu/drm/i915/intel_tc.h:1:
+#ifndef __INTEL_TC_H__

total: 0 errors, 3 warnings, 1 checks, 554 lines checked
b9b7113c4067 drm/i915: Sanitize the terminology used for TypeC port modes
23b0fde5d329 drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt mode
8a0532a98f99 drm/i915: Fix the TBT AUX power well enabling
28ab588e258d drm/i915: Use the correct AUX power domain in TypeC TBT-alt mode
378d871080dc drm/i915: Unify the TypeC port notation in debug/error messages
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/intel_tc.c:21:
+	if (WARN_ON(INTEL_GEN(dev_priv) < 11 ||
+	    (unsigned int)tc_port >= I915_MAX_TC_PORTS))

total: 0 errors, 0 warnings, 1 checks, 77 lines checked
54ac7475d3aa drm/i915: Factor out common parts from TypeC port handling functions
1f8594a207f9 drm/i915: Wait for TypeC PHY complete flag to clear in safe mode
928ee9c6465d drm/i915: Handle the TCCOLD power-down event
1bff7d4d3fc4 drm/i915: Sanitize the TypeC connect/detect sequences
04156e7cf332 drm/i915: Fix the TypeC port mode sanitization during loading/resume
fd3f8157be20 drm/i915: Keep the TypeC port mode fixed for detect/AUX transfers
-:88: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#88: FILE: drivers/gpu/drm/i915/intel_drv.h:1227:
+	struct mutex tc_lock;

total: 0 errors, 0 warnings, 1 checks, 116 lines checked
e967e51d9a88 drm/i915: Sanitize the TypeC FIA lane configuration decoding
a98e18237ea4 drm/i915: Sanitize the shared DPLL reserve/release interface
-:527: WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#527: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:3349:
+ * True if all required DPLLs were succesfully reserved.

total: 0 errors, 1 warnings, 0 checks, 542 lines checked
dbead30653b4 drm/i915: Sanitize the shared DPLL find/reference interface
406a41584fe0 drm/i915/icl: Split getting the DPLLs to port type specific functions
54d3b6ccdf51 drm/i915/icl: Reserve all required PLLs for TypeC ports
74d8ead2747d drm/i915: Keep the TypeC port mode fixed when the port is active
e8c117e05e35 drm/i915: Add state verification for the TypeC port mode
5294dc95eff6 drm/i915: Remove unneeded disconnect in TypeC legacy port mode
e8990683c8c6 drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx