Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [Intel-gfx] [PATCH 1/3] drm/i915: Extend WaDisableDARBFClkGating to icl, ehl, tgl
Date: Mon, 23 Dec 2019 17:20:24 -0800	[thread overview]
Message-ID: <20191224012026.3157766-2-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20191224012026.3157766-1-matthew.d.roper@intel.com>

WaDisableDARBFClkGating, now known as Wa_14010480278, has been added to
the workaround tables for ICL, EHL, and TGL so we need to extend our
platform test accordingly.

Bspec: 33450
Bspec: 33451
Bspec: 52890
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 1860da0a493e..0944b56c8f04 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -17827,8 +17827,11 @@ get_encoder_power_domains(struct drm_i915_private *dev_priv)
 
 static void intel_early_display_was(struct drm_i915_private *dev_priv)
 {
-	/* Display WA #1185 WaDisableDARBFClkGating:cnl,glk */
-	if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv))
+	/*
+	 * Display WA #1185 WaDisableDARBFClkGating:cnl,glk,icl,ehl,tgl
+	 * Also known as Wa_14010480278.
+	 */
+	if (IS_GEN_RANGE(dev_priv, 10, 12) || IS_GEMINILAKE(dev_priv))
 		I915_WRITE(GEN9_CLKGATE_DIS_0, I915_READ(GEN9_CLKGATE_DIS_0) |
 			   DARBF_GATING_DIS);
 
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-12-24  1:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24  1:20 [Intel-gfx] [PATCH 0/3] Workaround updates Matt Roper
2019-12-24  1:20 ` Matt Roper [this message]
2019-12-24 16:52   ` [Intel-gfx] [PATCH 1/3] drm/i915: Extend WaDisableDARBFClkGating to icl, ehl, tgl Lucas De Marchi
2019-12-24  1:20 ` [Intel-gfx] [PATCH 2/3] drm/i915: Add Wa_1408615072 and Wa_1407596294 to icl, ehl Matt Roper
2019-12-24 17:05   ` Lucas De Marchi
2019-12-24  1:20 ` [Intel-gfx] [PATCH 3/3] drm/i915/tgl: Extend Wa_1408615072 to tgl Matt Roper
2019-12-24 17:20   ` Lucas De Marchi
2019-12-24  1:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Workaround updates Patchwork
2019-12-24  6:07 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Workaround updates (rev2) Patchwork
2019-12-24 17:15   ` Matt Roper
2019-12-24 17:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Workaround updates (rev3) Patchwork
2019-12-25 19:31 ` [Intel-gfx] [PATCH 0/3] Workaround updates Lionel Landwerlin
2019-12-26 17:39   ` Matt Roper
2019-12-26 18:09     ` Lionel Landwerlin
2019-12-26 18:36       ` Matt Roper
2019-12-27 10:35 ` [Intel-gfx] ✓ Fi.CI.IGT: success for Workaround updates (rev3) Patchwork
2019-12-27 18:49   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191224012026.3157766-2-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox